From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=HE0G=MU=arm.com=Richard.Earnshaw@sourceware.org>
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
	by sourceware.org (Postfix) with ESMTP id CF3C03858D20
	for <binutils@sourceware.org>; Fri, 17 May 2024 16:22:50 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CF3C03858D20
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CF3C03858D20
Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715962972; cv=none;
	b=MM2P24vHLusDzGxiAJ3xNcQ/I4poid2+JlP3o8i8See4W6GNNXXwyl8zzFG3heG1ib/ExkJ3HmJpWTTB06/XGkTX++FY/VyIkvsqJQLznbBBbr05Q9T70l+4TRh66D6Z9yyyMXKVpErdkp8KkbzvpbET90ksvXDGYDHCAzxmLB8=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
	t=1715962972; c=relaxed/simple;
	bh=1AkG1D8GQEhs8LwB1uS5b5uiXerO+svRMZY91TieudA=;
	h=Message-ID:Date:MIME-Version:Subject:To:From; b=wZFEUi8hXe6BL7wSfEMhc4/xhad4YwDaooQ8GyCnOJTcXPpt32ccoWhXnsebycx2qkOkCPE/mp62UfjP3v8iu447Ic+zNWO9dvQvvIgyNlIYOQD7KeUC2JPQk29HITPbm+lbuGpHLCbJehamXTYiCXrqqGW+knSccfFlQeQ8HRo=
ARC-Authentication-Results: i=1; server2.sourceware.org
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 560541424;
	Fri, 17 May 2024 09:23:14 -0700 (PDT)
Received: from [10.2.78.57] (e120077-lin.cambridge.arm.com [10.2.78.57])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8B1CB3F641;
	Fri, 17 May 2024 09:22:49 -0700 (PDT)
Message-ID: <4b264e16-91b0-4ff3-9aad-ebfb78515191@arm.com>
Date: Fri, 17 May 2024 17:22:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] aarch64: Add support for the fpmr system register
To: Claudio Bantaloukas <claudio.bantaloukas@arm.com>,
 binutils@sourceware.org, Victor.DoNascimento@arm.com
Cc: nd@arm.com
References: <20240426150026.1415320-1-claudio.bantaloukas@arm.com>
From: "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>
Content-Language: en-GB
In-Reply-To: <20240426150026.1415320-1-claudio.bantaloukas@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-3491.3 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <binutils.sourceware.org>

On 26/04/2024 16:00, Claudio Bantaloukas wrote:
> 
> AArch64 defines a read-write system register called fpmr.
> This floating point mode register controls behaviours of the FP8 instructions.
> This patch adds support for reading and writing along with relevant tests.
> Regression tested on the aarch64-none-elf and aarch64-none-linux-gnu targets
> and no regressions were found.
> 
> ---
> 
> Hi,
> 
> Is this Ok for master? I do not have commit rights, if OK, can someone commit on my behalf please?
> 
> Thanks,
> Claudio Bantaloukas
> 
>  .../gas/aarch64/sysreg/fp8-feature-enables-fpmr.d    | 12 ++++++++++++
>  .../gas/aarch64/sysreg/fpmr-unsupported-by-default.d |  4 ++++
>  .../gas/aarch64/sysreg/fpmr-unsupported-by-default.l |  3 +++
>  gas/testsuite/gas/aarch64/sysreg/fpmr.s              |  4 ++++
>  opcodes/aarch64-sys-regs.def                         |  1 +
>  5 files changed, 24 insertions(+)
>  create mode 100644 gas/testsuite/gas/aarch64/sysreg/fp8-feature-enables-fpmr.d
>  create mode 100644 gas/testsuite/gas/aarch64/sysreg/fpmr-unsupported-by-default.d
>  create mode 100644 gas/testsuite/gas/aarch64/sysreg/fpmr-unsupported-by-default.l
>  create mode 100644 gas/testsuite/gas/aarch64/sysreg/fpmr.s
> 

This is OK.  But could you please add to the commit message something related to the fact that we've chosen to gate this with FEAT_FP8 rather than FEAT_FPMR as the latter only adds this register and FP8 requires this feature.

R.