From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id D555E3857C58 for ; Wed, 22 Nov 2023 16:25:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D555E3857C58 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D555E3857C58 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700670339; cv=none; b=VNOSTEt0ZdukNCcVcgshxk3AeiwMuvdNBfjDvP5c+5ygjI7SvleD4upPKvmMrkgE1+bfLUH/OM3hcwxXHHzmZRjMuY1sEculY89pPMTmuoQYF9LZsw7bNXmgZhfToJR5lrYP+RJNP5J0g7Hu3Xf9iZGSqNBJfkCr/ZolXeVL3Gc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700670339; c=relaxed/simple; bh=c5AL6VDgyEPFFyDfbvvPNu3mZVrWomJ2pNv9GScyoAg=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=vCPAYhTgJID+OYsbu6dwyt+J5oHkx+yk4Ux1HePzgdcm2yUsCbEn0O6otgmVgemkA9+ZTQ7W08zBOtY0j00iz9fkGhyLZ39j9LGARqNQJye1PMnWoMmk31PyRVbREcTbuPMWZbe5oUa2hhX37T47Frn3wqvPcuxbnfvHkZc2t/k= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353726.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AMGBwiB012039 for ; Wed, 22 Nov 2023 16:25:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=9NwIqsKb9pb7Db2jvPLXy+IfxaD72VpaqwzM1aIoy/I=; b=j+uFtmyz0g9FThG7cmpQPFzN5jEBoXJTvMt5cMc5Z3EFknP6kkM/5r6xcXVZ627Wu2V0 J5OMPdb8Lt/usBaJnKrUFz3YDck5zc70qvmXe14vPOvju6lPn6ljzeNZRlrmmbO1dsH+ W8BLPnZLmYFMaMK+pM8Mj9iZ2KAEL+qS72CEqdkg+tRviOMrzHVkdBeutcK5uE3ra+qm vWk6CslEl1qSTeLoYXV9sudKI+71H05B0pI5AkuTaK++mDaENGDMqcofPazjnmMJqPtR zM2x/bFTi3X2N82aZagwZNII/4x65JnXOn95OxwT8q1B95s+O4OMzKcfiqFu8LtkkBfK QQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uhmxy8me7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 22 Nov 2023 16:25:27 +0000 Received: from m0353726.ppops.net (m0353726.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3AMGCQTS013463 for ; Wed, 22 Nov 2023 16:25:26 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uhmxy8mdk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Nov 2023 16:25:26 +0000 Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3AMGJ8hf017009; Wed, 22 Nov 2023 16:25:25 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3uf8kp0yyc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Nov 2023 16:25:25 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3AMGPMVD42074712 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 22 Nov 2023 16:25:22 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 83A1C2004B; Wed, 22 Nov 2023 16:25:22 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6200D20043; Wed, 22 Nov 2023 16:25:22 +0000 (GMT) Received: from [9.155.201.78] (unknown [9.155.201.78]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 22 Nov 2023 16:25:22 +0000 (GMT) Message-ID: <4b43a052-377e-4476-bca3-1eeead156755@linux.ibm.com> Date: Wed, 22 Nov 2023 17:25:22 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/6] s390: Add missing extended mnemonics To: Nick Clifton , binutils@sourceware.org Cc: Andreas Krebbel References: <20231120140635.3642601-1-jremus@linux.ibm.com> Content-Language: en-US From: Jens Remus Organization: IBM Deutschland Research & Development GmbH In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed X-TM-AS-GCONF: 00 X-Proofpoint-GUID: BN2pp_X37vl--bmjGzjntd3twPfPlevN X-Proofpoint-ORIG-GUID: 2bYTOrMmjvHTU2nuYHSTFep-8ifIvBlu Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-22_12,2023-11-22_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxscore=0 malwarescore=0 phishscore=0 priorityscore=1501 mlxlogscore=999 spamscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 suspectscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311220118 X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello Nick, Am 22.11.2023 um 13:13 schrieb Nick Clifton: >> This patch series adds the following extended mnemonics (grouped by >> function) to the s390 target architecture: >> - jc, jcth >> - lfi, llgfi, llghi >> - notr, notgr >> - risbhgz, risblgz >> - rnsbgt, rosbgt, rxsbgt ... >> Patches 1-3 are preparatory changes. Patch 4 aligns the optional operand >> definition. Patch 5 adds the missing extended mnemonics. Patch 6 corrects >> an instruction name. ... > Patch series approved - please apply. Thanks! Andreas will take care. > Do these new instructions have a name to cover them as a whole ? > I am thinking that it would be nice to have an entry in the gas/NEWS > file that says something like "add support for the XXX extension to the > s390x architecture". No, these extended mnemonics were simply missed to be added over time. I did a cross check against the latest version of the IBM z/Architecture Principles of Operation specification to identify them. Extended mnemonics are purely syntactic sugar and actually assemble into a base mnemonic. The identical instruction could be coded by using the existing base mnemonic instead of the new extended mnemonic. The disassembler for s390 tries to disassemble into the extended mnemonic, if it is not a simple alias, which makes the disassembly more human readable. > One other, minor thing.  I tried to look at the documentation that > you referenced in patch 5: > > > Add extended mnemonics specified in the z/Architecture Principles of > > Operation [1] and z/Architecture Reference Summary [2], that were > > previously missing from the opcode table. > > > [1] IBM z/Architecture Principles of Operation, SA22-7832-13, > >    https://www.ibm.com/support/pages/zarchitecture-principles-operation > > [2] IBM z/Architecture Reference Summary, SA22-7871-11, > >    https://www.ibm.com/support/pages/zarchitecture-reference-summary > > I found that link [2] diverts to a "500: Internal Server Error" page > and link [1] would not let me download the document without first > registering for an IBMid, which I can do, but it is not really Open > Source friendly... Thanks for the hint! I have sent a V2 of my patches 3 and 4 with direct links to the documentation. These should work without an IBMid. Regards, Jens -- Jens Remus Linux on Z Development (D3303) and z/VSE Support +49-(0)7031-16-1128 Office JREMUS@de.ibm.com IBM IBM Deutschland Research & Development GmbH; Vorsitzender des Aufsichtsrats: Gregor Pillen; Geschäftsführung: David Faller; Sitz der Gesellschaft: Böblingen; Registergericht: Amtsgericht Stuttgart, HRB 243294 IBM Data Privacy Statement: https://www.ibm.com/privacy/