From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60061.outbound.protection.outlook.com [40.107.6.61]) by sourceware.org (Postfix) with ESMTPS id A43533858C54 for ; Tue, 9 Aug 2022 07:33:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A43533858C54 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QuquOk7+oqSpww0WBin/iwX3rxy4eDHaWiV86QYeCLDNbDMBdSXHjLiWj1Rh0oAeEfgrnTbOJHE03iU/vFXyM54BXI8w8HxjYIMxYG4gOxA/yOM+aWEW3535sN3oSwX9SDIHbJ62ttRxtAwT6eZSRwNpG+bPBDh6FEa04MKl/7o532Mkn8djTYK5qN49B6wISM+Jg2KGtkm3LsmF5aIveuekho1gpOljfA5aQf1i1BXwYT6N+Ys55ZcRW7vLnK5/5TwHcQGEJ8yQ5HqiQBKwlfJGeQ1kOaF5jvms/BPlbeOEcTBY3XYzy5sSlImYbfC8i5LbbIftv0gtH2qGcOSCWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zE4nnjw1UerzGQ7rA9pkAwC8WFILX2KbbljbBNOCzo0=; b=hFahTwY/JR/DVXbfm31Piijn9bBfkXLyUWVnxOr/ctZb+CvlNRCHORTcHwwlMvMnhT9QodlMMZFaWaJRW8U1Xeks6HbIgrVFJqLn+7EPCHQH26xtNuRurhtGm1D0m7OX3Ve4ZdtMM91o8z6Gkk1ltXuaWLcjIhQzo2hCIJIbocbAYvQ76wzWT5QO3INqk9C0hkmup8j9rpVeaM2sF89uzPlg0YBeu7IEmwVdfoU91Cf5GGIIA9i+/qLc5XgcfdYAv2a+/UzBJnWelL5MC++rTkxd7PUJ8UosC0LgbS3U8xotQmGnHgWiCVmmXFltL033EPxZDF40nxKqekQoEx93hA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB5816.eurprd04.prod.outlook.com (2603:10a6:20b:ac::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.20; Tue, 9 Aug 2022 07:33:16 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::fcd7:eaf7:5345:210f]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::fcd7:eaf7:5345:210f%6]) with mapi id 15.20.5504.019; Tue, 9 Aug 2022 07:33:16 +0000 Message-ID: <4b800fb3-57a7-ee86-c530-ccf1b42e8105@suse.com> Date: Tue, 9 Aug 2022 09:33:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 06/12] revert "x86: Also pass -P to $(CPP) when processing i386-opc.tbl" Content-Language: en-US To: Michael Matz Cc: Binutils References: <146313cd-154f-4001-05a8-6b25a90a14d2@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0063.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0e361519-c247-4097-c33d-08da79d96c62 X-MS-TrafficTypeDiagnostic: AM6PR04MB5816:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: D50YztoKhAz6MN4DGdAR5aoFNwENnpqFpZNsnJgkeJLceLuz2N/K7LnY4sJfUUE3Tyq2OpIOEABh69Z5JxyWgIPwd8TZDnhakm2ZQl5xE3jY05S5LxBJ19e2sQIVOteuvui25oDzQhlz22APjhJBgz77fLAc2cjWDf17QlzP4/9dCQ0uSbeeyiLspKm9Rr681sN8qQiQ8G34n9TK9MaVJ2JA8zF291zQ+1pGdnH629afILidqTwpeiEq8ADY9M6N7pEmHc/0IMJTTKAzQmGjLIRDhzmbsKlESqkto5eKuBAqeCpmIDwc8wpzzJFrqHm4s+AmN3W5RZMp7Pwu/92cdZziZ9dHO1MkuIKYl2/Sm5RkJF4K6azOL9YcEXGMV795RnVw4cRPrldCEvN8DIouIC6S4vFIXyk75tHctuw6909gypX4f4jd23g5+RRELF8H61aPSq7hcFiFkD15FaVtTIswESQKdTlWf5At+sQxx0y2cMwFlC0GqGddgFn7nkBB0FrjiheGeSSUFh17JsXi3Z9pJzKS4hu89QhcOH2/ibAOu7LN2tttbTH9fyw8qw9zS5IZSfNoKG99gXtIX5GecJ/18Yr4pr3ho2RJlsrc3bXCg+BEqQg0LSufQb6FRKJbOWQXioJ6WQxKMgODlZ2wkuzVBEMwceI5doy/VkzeAbX8E5vyncleikBz7hnESPoLiHge7Bpsou+Uoh9/2IbPD1uPHlX/quitmgHlhy/CMr9K37XDmufHKjnSaf/eEtGJ2Vl8hZc6C0EgNXU9w98+OHKX8M7WwKbYTsj4e3y854I3bp+6x+Xc/HIQXXKgojBfZOVtxYtX1Euc+N9K6XlGjQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(376002)(136003)(39860400002)(346002)(396003)(66556008)(66476007)(38100700002)(66946007)(6486002)(8676002)(8936002)(478600001)(5660300002)(31696002)(86362001)(4326008)(316002)(26005)(6512007)(31686004)(83380400001)(186003)(2616005)(36756003)(53546011)(6916009)(2906002)(41300700001)(6506007)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aVNiKzNZT0FTQ1g5b253U0pLZ2VpMitMK2R6M0xWbDNvU2Joa2FOMEV4SDlH?= =?utf-8?B?Wld5dFhQYmlEYzd4dVkxQnBWOHhsZjJpSmVwejBHSjBNY04vTDM5U1FtcHd2?= =?utf-8?B?ai85WGJqNVBDUHB3Ylk1aDUzbktsSWdqa2dYL0JZdzl0WkpBUUJyaUt0bXVJ?= =?utf-8?B?Q3UzSmQrRmVlSFVQQmZMOEJTYmxpV2UrajdyOUJ2NE81amZQY3Q0VzFUb1RI?= =?utf-8?B?S2tRemRBN0R6U0VVcXdsMEdvNFF5ZUtSVkJNcXkycEQrMHNqVzNsZUJ1WjBv?= =?utf-8?B?WUhIbkVGVnlqakZ0VlQzditybHpMeEJXaDc5MHJKUVd4cjY2K2ZDbHg4S0M1?= =?utf-8?B?NCtWL1RJL2tIdkJ5UHJpTDMxd2xsRWdPZ0hPMTNCL1NXUzVRZWlGSUNSRzlG?= =?utf-8?B?MzlOWkNaMVMxemdYUy9QcFFkZ1dUMEUzQzdsR2pNbGlHdUJIV3IwNTRDVDVw?= =?utf-8?B?WmpUdy9MVUVCWktqSnhCWnFRZWxRLzdKZHAyZFlKa3J2WWxEYURKTW9vdjV0?= =?utf-8?B?L3hBa0t1S0hxc2EwYmdjbXVnQnJrVS9IQ2dYcElSN3pYclQ5L05va3V2M2pr?= =?utf-8?B?Y3I0S3RLa0VGSWFpVDdrMXkrRXpiN1haUHBBTXA1K1M0QktscnhqT1A4UGdj?= =?utf-8?B?V2VTUU1Cd0thSUlxQVNIK0J2bXV6M2t2K3p6cnE1RmFKRStZVHB2ekJ1RFZt?= =?utf-8?B?bVNCb2QvbncxU2JRSUYvQmtjajJVSW5BckZCMGZjNUE5eEtTYy9yR2phQ3JO?= =?utf-8?B?L3ROa29vWXpRT3BFdkd6YTY3cFRHWXFmc1NnZnkwa2ZMNU5TVldXU3NiOVdm?= =?utf-8?B?VVdzUkZqcU1uaEJtZlFjSnJxUUNMNEhURXAzdUovOHB3TWxiR3V5L0hLb0tz?= =?utf-8?B?cVN4WjQ3SXdNSnVWME5PeXdaWnV6azIzZ2U3eHYwR1ZRTDVVNEJUaGpxdTYy?= =?utf-8?B?TWhhSDNaeFZlR1htaCsvd0pYOXZQMjVNbXdRZWVZNHBCSjNEM1dyaXV4NmRq?= =?utf-8?B?bm9ZRHI3bWErR1pSYzUveE5Cem9mdm9KMHVtSStNeVFGU3hkbWI3QXpBTmhW?= =?utf-8?B?eU0wc21mbC8vSm1ZZ2V1Z1I3Y2VIRndoa1YzTFUwbHNWZ3VEQmpOQklYZDdJ?= =?utf-8?B?TDE0SVZ5eFRMN2gvRngwVGNVcEQ5VHNLZDRFWUp3OHdwZjlmT1paWWx0SDdP?= =?utf-8?B?cEdwT3RORVM2MGlEVW1Wc3ZuS0ozaTlkOE1RTmFmS0EwRm80Z1dzMzJ3OHRH?= =?utf-8?B?cC9nSWE2blJoNmpnLzBqYWREQmgxb2tNSnRrVG9jZzY2VDVCYU9KN2w1TTFT?= =?utf-8?B?d0dqd3NoS21GK2ErbzVwMHBnVkFad1pLRzhVb2x0cmNyQ0pZUndlQ0JFU0hK?= =?utf-8?B?Q1FLRk5zVkNHM0o2b0g3WkNFWDJEdCtHV3Noa1pmcERwZWRhdkdtUzNvU0pG?= =?utf-8?B?TlZKWUd4N3VQOW0zV3NIZHJ3V0lTb3Vza1g1K0E1NXllWmEyV3pEMWR2a0t1?= =?utf-8?B?S2ExRXlPWHdmZmliYitzdlYvdWJhaTNaTXNEeWZJRTlNc0R4RmIzM0ZVY3Yx?= =?utf-8?B?YnFIdk5zczNnUURBRW1xQjZWaVNlbTY4OUxBQWc3eXpuRk5rdDZUQlR1RlFw?= =?utf-8?B?VmVybEViUnY1bTJHVDFFUFdFTzV5cnNMOWZYeVU5VFZteFlRM1AxejlQM1FO?= =?utf-8?B?bGsyaVFUanNBVldXUUlmdDRYaXkxRk5rVlAvdEszRDJMY0N4bkV2S1N6Snpk?= =?utf-8?B?ekZoclBXVHNZTGNOYU1MaDJUM2pwRkZybVJzUXhsQzJSekVZNWFNc053anNj?= =?utf-8?B?RDB4SXYxRTdZWThPN3RSUEJGYmxRTUhuYVlGSC80Tnk1M05uN1lEVmQ4TE0y?= =?utf-8?B?RXl5TVo3SjgyYzFxQm4xY3ZJc3drZU9wOXpPMFFFd01xWFpOQ2hlcURoeWMw?= =?utf-8?B?M1c4d2RIZmd2VjErVkp2aU9kYzhNdmdhSks0TkJybVQzNHJ0ZndkcnEyVjdV?= =?utf-8?B?WUV2UkJ0Y28wcGE5aUxrRkFoK3o4L0ZPVW8xc0Z1SXdOaERoWTBDQ2MrQWdq?= =?utf-8?B?dUpoTUh4Zmo5RVVRMG5TZzBrUXhLcDZPTDQ1L2p6MktrQ25wREtLUTRoOXU1?= =?utf-8?Q?OS2L1XYtOPU9Qe9UB7FNbp3mP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e361519-c247-4097-c33d-08da79d96c62 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2022 07:33:16.1028 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Kkqb2L5mdCiR/RaTUkwcTb9M4PJKSjO0fNRApYFiGQSRS8DwPhSk39VrRwXPKUW1+jkJahD6L/OZMoE6gOisMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5816 X-Spam-Status: No, score=-3030.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Aug 2022 07:33:20 -0000 On 08.08.2022 14:49, Michael Matz wrote: > On Fri, 5 Aug 2022, Jan Beulich via Binutils wrote: >> This reverts commit 384f368958f2a5bb083660e58e5f8a010e6ad429, which >> broke i386-gen's emitting of diagnostics. As a replacement to address >> the original issue of newer gcc no longer splicing lines when dropping >> the line continuation backslashes, switch to using + as the line >> continuation character, doing the line splicing in i386-gen. > > I will note that all occurrences of the line continuation character are > within the various <> templates, never in the opcodes themself. So their > content is all bracketed, and there's no reason why they should even be > considered to be single-lined. So all of this should be possible to be > fixed in parse_template() alone, and then i386-opc.tbl wouldn't need any > continuation characters at all. Well - that's possible in principle, yes. But it comes with downsides: For one, it would require fetching further lines from parse_template(), when imo it's better to have all fetching (and in particular all incrementing of "lineno") in a central place (process_i386_opcodes(), which at present "lineno" also is a local variable of). Then for a mistakenly omitted closing angle bracket it would lead to consumption of potentially all remaining lines of the file (quite likely resulting in a not very helpful diagnostic). Having everything on one (virtual) line in order to check for the closing angle bracket was actually the original reason to use line continuation of some form). And finally it would preclude further use of line continuation for other purposes, albeit I'll admit doing so may be undesirable for other reasons. Jan