From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2073.outbound.protection.outlook.com [40.107.8.73]) by sourceware.org (Postfix) with ESMTPS id A7DA83858CDA for ; Mon, 25 Sep 2023 06:07:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A7DA83858CDA Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZjSvduQsWRQMGXphH6WwleWF56XHeFqwUUoEC8/5YJMV4imqAXfCa8Jfa8UnO20Q+yFTLmMIRg51l/8rAU9R7e+pFgrae7TMV64MH8V4Yd33NJwbKeNcq4tNUhiE8pC4XDDnKwDNETSqsnV7ndqVk/BRfTE4qJMgIoW6mmxOt8M4OmgNiDIudXryQZcrGDrJ6M1HPz7nDtsPna3bQCMesRNiZ/ERSNCsdcQscoPzfTvMVyA+F6g445wldTBZj0Jr4Oa2d33qn/LlmBY2+ZzzrtYFcPYTIX2KJfrqTdVQhMhgm5dMH8o+TYxUVR4l9gXNfebzHUXIJRVK9WfgYiQ9og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bDNT3SBKP5Bb61B3RVpQ9kFp0w3kyEtAgWPdHXDB3t4=; b=emgCljwvp/0dB3c0hiPqS/saiFGBL5JS7NsWxbhqyi7cOn148DfNUsI0EH5q20QltiQQCxdM72v/U44TxiLVT3Ex+dPE+5yPwunG2lWFncps7A9/MrD4DDQIfzkudtylNE/6d/hWfjnvL8wlqPepRM6CTmtjTpCF8yYDQNFeusV9mc4gJmkbcALl/hmJbrc7YUrjg+n8eziXZkkM/CxmjneQcy3lq3+11zeiQpwgBykU0p0xsVypGSo8beWs7pbgQT8LnrIif9zefRTRAinyOJC4hC7OuCJaIZ6H4qiwbUg6B6S5a1wddkwV0xunQK7RpiNo3nal6/rp9I/1BdhbWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bDNT3SBKP5Bb61B3RVpQ9kFp0w3kyEtAgWPdHXDB3t4=; b=mWWb1PbLt1caKvNN1gueLAlQLHi5YBKWdwNDeRQzrsmI2Wdr7385iZJ8aEGSMX2kDsw5SVU4S3BLsY6s9Xbh2MeXxEgOe4otslG7VHHqDPdcuOFGIvZfXPjk0mjW2SxUeBjNwdhnhl/wtMMi8pK9dTmgIJcJuZgI7tD5pGfJJY7aC+fC9LuVKk4G3ge0caMehdlSGbEFNfvtQGkYOvW6CJkdR0zwmGyrxU9Qz4VIPOIK0aO/EVwkfGLdavlLKX9gCmDOIzW+TKSKIYrtp+bqyl7FOTH2I7TiKEvysA+d6P45rHaY/KWT92JuY9Wn45S2F2jjL4xdElmp6KOq3YueHA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS1PR04MB9287.eurprd04.prod.outlook.com (2603:10a6:20b:4dd::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Mon, 25 Sep 2023 06:07:31 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::1353:3b49:2b70:6303]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::1353:3b49:2b70:6303%3]) with mapi id 15.20.6813.027; Mon, 25 Sep 2023 06:07:31 +0000 Message-ID: <4ba4edc5-d385-77fc-d339-24bed40cc557@suse.com> Date: Mon, 25 Sep 2023 08:07:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 7/8] Support APX NF Content-Language: en-US To: "Cui, Lili" Cc: hongjiu.lu@intel.com, binutils@sourceware.org References: <20230919152527.497773-1-lili.cui@intel.com> <20230919152527.497773-8-lili.cui@intel.com> From: Jan Beulich In-Reply-To: <20230919152527.497773-8-lili.cui@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0075.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::10) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS1PR04MB9287:EE_ X-MS-Office365-Filtering-Correlation-Id: a7a664f3-5ca9-4aaf-2cc8-08dbbd8db3e2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fTY0uOwNeuztxd8KE8ilSyXsjb5JGfZKc3Q1lO3s/gB01k2xAXO5o2Xl1RoRCVP2eGdofGz8BF3KlfGAVaMzRNUTAHut7xdEFGYtFkqeU23gGbS6Ye7AKrardhO/kdaH+mSpxnucArJ0bfZYR7gBUomvl7CWRCfu4CZqmS8WCZdlZrY2P8w5krRUf1FoiNl8SbLcBf0klS2JXlJJSJdp36x+MtJ0KktL67lXmPYe0J5N6qK3FiZEtqz2ErLY0CfdmJxzR3ykAA/E4VfF1hZ5sDW9O7RLSo/4lDVXAncVwmaBgk0X3JhvOa1AJ8oNed2qOyYM5mt+ibGVJ8SGFs8dgCxKJ0oJ5vQctxyaltwexBs6OkuKO5pmf2vrrilKik9B109+p7GGw2GNXBVsbU3EkHx2CZPKG8MHNxsH6S505ho625+0cqLkrtDKH6VfBf7yCIBgsOFdbJjg7pFw4sPIt726Rmkor7Pfx+uTnKKk/wF4mGpAD8w3FBtFnC0Nui5mxYdKp2gOc1WvMjVsmooeCEPpToovHxFrQTIvfSNLWSPjlU+QVTTxiVGq0Ys6vJP5znAVnmg1fcIaAPi59rI+rqa5wPL9iaGVPentVjWpvDE5GYK/gnXX9kmnsroc2FNjdreIXXdWT1e0wKirRSa86w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(376002)(39860400002)(366004)(396003)(136003)(230922051799003)(1800799009)(186009)(451199024)(6506007)(53546011)(6486002)(6512007)(26005)(2616005)(66946007)(66556008)(66476007)(86362001)(31696002)(478600001)(38100700002)(2906002)(8936002)(8676002)(4326008)(36756003)(5660300002)(6916009)(316002)(41300700001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RytmR3AxaGE3ZGl4Q3ZWdHYyOGRmT2ZCbUNoNWFQR2lyRUpsQU5vU2ZzTzhG?= =?utf-8?B?YytsSXNtNzZxekkwU0sxdG9JZFg0OE9JcTduVDRJSjh1Y3hNT1NNOGFnR25L?= =?utf-8?B?SkxKZ3RBcDBuZCsxdjdqazdCUmcyd2RVNHJRRXZFWEdDU3owTjl2QWgxUC92?= =?utf-8?B?eDhMY05hYlNHTDdQV2JiTTJIM0xtUFpaVER4UDduVDNBN29jdU9HZFQ4Mi8y?= =?utf-8?B?OVdSV2grSlovcjRtVlM1MmU2a3pUdFpYOStRSkEzOHFoU2dhUlJXT3pJdG53?= =?utf-8?B?MllYazdLeWZhWC9QM0pEWGk2TlpkL1lMdWRPSzFpdFBkZzFtVEZiSEVoRG5K?= =?utf-8?B?WmdJTmxKaTA5cWlYVS9YalNESi9QWW54U1FuQXcrYTgvSWs1MmUzTVVINUN5?= =?utf-8?B?S24rRVR1M2RpSHdnbnZlUTJ2U2JteVppZFp3c3ArRkkwMy9Zam43N1ZKZTRo?= =?utf-8?B?alMyRzRnY3F0eFcvYkp1YWNtQTF2ZUR0TnJsWUtudTBabnpYUnZXS0tnMm5o?= =?utf-8?B?WHlKQitURlVLTTFjS25BWE13clNOUndYNlR2dXF2THZ3V2xGeGliV2p0Ukxj?= =?utf-8?B?cjlPK0Y4UnordG1KaEFkZVMybXZmNDdSNFZqRkRTS1E1bnoveUl1MU1XYUgv?= =?utf-8?B?SUdabXluK0JRREhjbVpCYWRoN2JOR2ZhVFNMOVV5MWNLUWlReTVjdjhCRWFM?= =?utf-8?B?byt3V2VicW1iVzVPY1I5Qk5MY0s5M1ozbCswbGJoT28rWTBxNXh3ZHR2NVMw?= =?utf-8?B?QnUzN3llcDdrNWFwNnhYTXMvdmN3ODU1L0phR2hTcnpwRFROdElaTS9INlhS?= =?utf-8?B?MVdVdkNHUWNia3NhZGJPMC9mUzRZUU94SlBiSXlGNFplaXM4MlQxVzFHWXBk?= =?utf-8?B?L2t5dm51S0kxeFhyZDVHZndFWXJNUEpmdmRIcUVmdlRmcC9JeFZ4aWtxZnVF?= =?utf-8?B?WVR3OW42cUNXZ1ZpdWxLb3ZrZjh5WWovczYwWXBCTGRUaExyaFBuRTgxY3VB?= =?utf-8?B?WWpHVnN0M1dLUDNNaktHbzcwQjMxVk0zL0xZQk5TMmg4U2I3QzZZOXQ3cVR5?= =?utf-8?B?UGkrNGFWYXpzVDJ3RUpKcFc2S2lJWWZVUS9TWlkyeENVS3pPQlRUbVB0UDYx?= =?utf-8?B?VXhLK2lZOVMxZm9WQmNzZ1NrMnpzL3BQNEZ1OU9UMmcvdEczZWxaenh6MXZx?= =?utf-8?B?anBobDBieGtUMCtPcHM4TmZHbVVLZkJHT09HMHFQYm5YL2Y4NzhIUDhpY3hU?= =?utf-8?B?MzVuK1JIcHp3YmNNd3hHaVhsZ2F0a1QzZFFYWVcxZmhOdUpZbzJLMGV1aCty?= =?utf-8?B?bUxLUWNSWTY2SDl5ZTZwTm8yNkZKY3R2VFllMEFxTUJhNUErTWsrSGxhN1Jo?= =?utf-8?B?UE13aWNpM2x4bGtsUlVhWDdhQlRhYWpidm55YWVUeWp3SHJqcE9wVVNIaS9x?= =?utf-8?B?dFJncjloWFJjbElOT3QyaFgzaVNod0cwTEY3QVh2SVdhYlBLN2pONmZ5Q2d2?= =?utf-8?B?Q3haalovUzN3QmZRYkRoSXZXODRQRzFyUDZTWHd0emhOK1NwbDVVRmRMVjNZ?= =?utf-8?B?d2IzRzMrU2tuMmxSdld6NDR3UlowS3FMTERxTTR6QXFiallEMTNDdzI3V2R5?= =?utf-8?B?ZkNXY1F0bHZjeXBiL28vZ290ZC93eFcxZEI3OHVhQWtGaHU5U0R6ZDJtbXhJ?= =?utf-8?B?bHBDS0J0M1hkK0IvZldUVkpyZzlZNWh2eTJtYUZpMEVNYW1ZTXpCWElZdnlM?= =?utf-8?B?QmE1Zis3b2RMbElld0JLenlNLzgremd0MW5EL29kTjdtRUxjdi9SZUJTVjFQ?= =?utf-8?B?TTVIandBVnpDWHB5eW5tWHBqTkFoem9Tck41Z2hkcm4ySG1NaktvYW5DZzNO?= =?utf-8?B?L2NMSWRoaEpTRnNDK1B1SkFxQ1lJbURPTSthYmNFY2hINVVLQ1hmVkdHVHht?= =?utf-8?B?elNEbENCNlJmTTNhRkhJSWprVk9Dd01wWmVkRTV0U09MZTMzQytINlltbVBW?= =?utf-8?B?ZHdVdmdZQ1hRUnAvUDhrT1BrbVJBVFV1NzhoWm9jT0tFYWFuNFoyUzRlc3A2?= =?utf-8?B?TmVDZFZENU1WT3VicmdmaFJDdTI1c0NCYzdoWTFlUnlhSmV6bDFaSVlKN25Q?= =?utf-8?Q?Q50Bfmx24t/p2gru1cfXb2s+b?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a7a664f3-5ca9-4aaf-2cc8-08dbbd8db3e2 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2023 06:07:31.0105 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VhlHFc11q+cBpQbW0pKQshhq03JroYznz2REroDSoZ68vpvwNlaWw9bLYGeAHFIrjFH4uVOWbLbM/12P1bRJUA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9287 X-Spam-Status: No, score=-3027.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 19.09.2023 17:25, Cui, Lili wrote: (Only peeking ahead; not a full review.) > --- a/gas/testsuite/gas/i386/x86-64-apx-ndd.d > +++ b/gas/testsuite/gas/i386/x86-64-apx-ndd.d > @@ -158,7 +158,7 @@ Disassembly of section .text: > \s*[a-f0-9]+:\s*67 62 f4 3c 18 4f 90 90 90 90 90 cmovg -0x6f6f6f70\(%eax\),%edx,%r8d > \s*[a-f0-9]+:\s*67 62 f4 3c 18 af 90 09 09 09 00 imul 0x90909\(%eax\),%edx,%r8d > \s*[a-f0-9]+:\s*62 b4 b0 10 af 94 f8 09 09 00 00 imul 0x909\(%rax,%r31,8\),%rdx,%r25 > -\s*[a-f0-9]+:\s*62 f4 fc 08 ff c0\s+inc %rax > +\s*[a-f0-9]+:\s*62 f4 fc 08 ff c0\s+\{evex\} inc %rax > \s*[a-f0-9]+:\s*62 f4 ec\s+\(bad\) > \s*[a-f0-9]+:\s*08 ff\s+or %bh,%bh > \s*[a-f0-9]+:\s*c0\s+\.byte 0xc0 I don't think this change belongs here? > --- /dev/null > +++ b/gas/testsuite/gas/i386/x86-64-apx-nf-intel.d > @@ -0,0 +1,633 @@ > +#as: > +#objdump: -dw -Mintel > +#name: x86_64 APX_F insns (Intel disassembly) > +#source: x86-64-apx-nf.s > + > +.*: +file format .* > + > +Disassembly of section \.text: > + > +0+ <_start>: > +\s*[a-f0-9]+:\s*62 f4 7c 0c 80 c3 7b\s+\{nf\} add bl,0x7b > +\s*[a-f0-9]+:\s*62 f4 6c 1c 80 c3 7b\s+\{nf\} add dl,bl,0x7b > +\s*[a-f0-9]+:\s*62 f4 7d 0c 83 c2 7b\s+\{nf\} add dx,0x7b > +\s*[a-f0-9]+:\s*62 f4 7d 1c 83 c2 7b\s+\{nf\} add ax,dx,0x7b > +\s*[a-f0-9]+:\s*62 f4 7c 0c 83 c1 7b\s+\{nf\} add ecx,0x7b > +\s*[a-f0-9]+:\s*62 f4 6c 1c 83 c1 7b\s+\{nf\} add edx,ecx,0x7b > +\s*[a-f0-9]+:\s*62 d4 fc 0c 83 c1 7b\s+\{nf\} add r9,0x7b > +\s*[a-f0-9]+:\s*62 d4 84 14 83 c1 7b\s+\{nf\} add r31,r9,0x7b How was this notation established? Is it aligned with what other (dis)assemblers (will) do? Following the doc, I was rather expecting this to be a new kind-of-suffix: "add{nf} ...". Jan