From: Nick Clifton <nickc@redhat.com>
To: Mark Wielaard <mark@klomp.org>, binutils@sourceware.org
Subject: Re: [PATCH] gas: Make sure to only add an md5 to a .file when requested.
Date: Mon, 7 Sep 2020 12:51:31 +0100 [thread overview]
Message-ID: <4bebde91-6c1a-8a48-9590-6321406ebc4a@redhat.com> (raw)
In-Reply-To: <00148260260628bc78687aaea695b57d00647829.camel@klomp.org>
Hi Mark,
>> I had to make one small change for the SH targets:
> Sorry, I hadn't seen that issue. I do configure with --enable-
> targets=all. What else do I need to catch such issues?
The targets=all configuration will catch most architecture-specific
linker problems, but unfortunately it does not work so well with
assembler issues. The only real way is to have a whole slew of
different configurations set up and ready to rebuild and retest
once a patch is applied. Which takes up a lot of disk space and a
lot of time...
I have such a set up since I see as part of my job as a maintainer
for the binutils, but I would not expect individual contributors to
go to such lengths. That is one of the reasons why I try to test
generic-code-affecting patches in my local farm before approving them.
Cheers
Nick
prev parent reply other threads:[~2020-09-07 11:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 0:35 Mark Wielaard
2020-09-07 11:10 ` Nick Clifton
2020-09-07 11:16 ` Mark Wielaard
2020-09-07 11:51 ` Nick Clifton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bebde91-6c1a-8a48-9590-6321406ebc4a@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).