From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2069.outbound.protection.outlook.com [40.107.104.69]) by sourceware.org (Postfix) with ESMTPS id EF7DA3858D28 for ; Fri, 6 Jan 2023 08:11:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EF7DA3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BSWWGcolEDfTA++/oT4cibzeKrohUjjhhUn8gBREDyiGX9nR8DZz0xpID2/AzqYmno8bs/IUs13Q8et66afmuD9r/dTw44EUbNbQpf1tkKOkUqvKmKrVQ5plWBd6XvrkhGJDz7LQ42JTZcDFo8FGxbmhyq0hNPxjJKE3fCoejjiEjyhItL9No4s+famgKWowbo/4PG83DSx4gvFOXYtwVuL/6xOmKsCxnysACW8YHcDN7CMp1EzKF+c8Pgdvtl3BasC8DW0W+pveH3MIQmV3IOBlrp2zqEaFyozk9j1jM71zl+2KDeHaqx+DZh2j+s6vM21LlF4kYA7RvEBmGb6vQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NB7VmigAZ349nX3ZvG8KsuplnmwFLdUHNX4hb+u2x5s=; b=LYBau1Pn9xzAhizzIPvtUoLPtXUsfOmv7BkYR/GB8VFXjwhDQIBZomdOEVAMLDHU/j1ncWXqnt59clMfb4BA9Qefl6qUqD2uyQleD++TiNFY/+G8fewSv2Ea0TzKKJcXgeWdiFtaf9Cjw0nla3/0b9P8ec1Qnmswu3gZgqdI0WJXJocs7VIkVL4hxFON4fgBXwxIQANrXBffAQ7ZTIJNEQrwQlAr0Dof1ghcqo+uU0keHn9hc662FJXX1N/bfarvoK8fbF831Ni7L+tA/ZE3pK/2tFkdqnxUGG9/5p96kibRsV8KwxqSMIgAd27nqYNzVs1AtfSURaXPexxxAHicOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NB7VmigAZ349nX3ZvG8KsuplnmwFLdUHNX4hb+u2x5s=; b=HbdIcEMOxGwwBo9ABVqDIORexkEWadrMeObRVW0ey9Cv96SKTXAY40enZ6Gy4AbcaAaCIk9eXPChQg7/xtBC4X8GU+qjvUwI4HNuP3EnY6mFiZ8oSMzP8ufaiFvuu+GtofBH6prqLhtSvuvgEsRM2Xtq/QvC1V7APVb5V8YgZ1pQsa0to1a5hiY+NReh8iC4FQJFxhrMC83MRWCXBAgQLNLESw84sr9lIQPWTv8I2/YNSEGG8CaLunfUZDcyWmNLqXulibEGavooF58I8o0Zl/kZbU0JlaZotD8mQ1tvlTYllxqHIwToX5NNqqiTYvBYIgPutmhccegTAW0u2S4yvQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB7180.eurprd04.prod.outlook.com (2603:10a6:10:12c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 08:11:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 08:11:26 +0000 Message-ID: <4c1fda53-249e-1877-9bd0-dfef0cd6f108@suse.com> Date: Fri, 6 Jan 2023 09:11:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/7] Skip ELF-specific tests when targeting pe-aarch64 Content-Language: en-US To: Mark Harmstone References: <20230106012509.7918-1-mark@harmstone.com> <20230106012509.7918-2-mark@harmstone.com> Cc: binutils@sourceware.org, Tamar.Christina@arm.com, nickc@redhat.com, pinskia@gmail.com, Richard.Earnshaw@foss.arm.com, nightstrike@gmail.com, wej22007@outlook.com, zac.walker@linaro.org From: Jan Beulich In-Reply-To: <20230106012509.7918-2-mark@harmstone.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0052.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:93::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB7180:EE_ X-MS-Office365-Filtering-Correlation-Id: 477fa591-dd15-4303-26c8-08daefbd9b7d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XTCTso0gOfB4ih0YDCZvWT7ogFJKNDsvamOsXcQN1fOIc6Zv7CFYNWtujeeb+S2H7DVOBdAdqax7CyKq4QGuYKeM5TNaVppAeHEb7zmGa6vh0gsv4uwmbI3VFoNm9STf2jiLBMaE2ryDa0PDuVesaW23kGqkC1ue4i9J/z9Ur/9JzeMNbhAsCEX6b8rOh1M++fKZ+z1z1E3GmTLDS50JfWqcgpB7Tr6CbYZkb74gOlrLycOIvkeIP+KjUi3thjg2CZ/gDEQKXL2JzHBufbR9GIq7pZhTl+OE18/nnoOUgxLi8iEesgg7Q/OQXTjbWXuJFN8zUHGr0ghJkMqpm3AxO4SKTrUjrPTTcEKJ1cbV0xAp7caY250CeMPSFqcsqfJThqoEMXtxlmk8VZvM+6z6a5vvVZr5gOxfysdqkLY+tGjStnI8Sh6Op6XHakG2kgQy06MntSyjSJejShDp3kEQUpGPYu+TmGPrUcrU7FTBrWiM21GRV3wJvMfUlAesbtvawDQvaElDV+ucUHpDQKL9jyObSZ+pxuVM53eyS7hgm7FZyijya5/SOdOULU8WOX5KnSbo3wXNu5yQl58TfPON30n9R3QGC0bgd83v0PSQLCLVHp11dtiN0gWzkL6yqpKmg2++0dwa2pY8cyHarEM/57IYaSmB+pmrYVglwc6x7qGV/Gm5jK88yCyrgh0ME96F3JUvlV/ko16Xw6Rh0mz5bpCkGGYMbxberTdICpkgQ9s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(366004)(346002)(376002)(136003)(396003)(451199015)(31686004)(36756003)(31696002)(5660300002)(66556008)(66946007)(66476007)(8676002)(2906002)(4326008)(38100700002)(316002)(6916009)(8936002)(478600001)(6486002)(86362001)(6512007)(53546011)(6506007)(2616005)(186003)(41300700001)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UzlHZTg0a3dpbmhrSGZLNDRISkMrVEZCN3c2ckNacUxEdVVGdXhIMEtqVExZ?= =?utf-8?B?OThFNDk0eFBweEcxVERqTE4rMGlLU2xxUjNyMWc1NmEzRHZYNzhDY1ozQk9E?= =?utf-8?B?bUlFK0lQdHVMYnB2KzBZZm9Gc2Y5UEo5SzdUTXdsTTlOVkhldjUvYUlCZUFU?= =?utf-8?B?YTlvRTJtR1VYdVNkaFhmV2lHWDdwTWRINzVVR2ROUlo4bmdYTkZ5NjlrL2VD?= =?utf-8?B?RFJsbWRrdjFWQlV4aVhFRWlBelJFNlN3SXlFVk9qZXFjKzZHUHRuWFZxWWFo?= =?utf-8?B?UVcyRnlGTEM3YnhmMW9NbHZzQ2dNOHJYemlWcG4rOUhVZmw2OWo2ZzRQZVJG?= =?utf-8?B?WTN0RzMvd3hPU2JwN0xOcE52ZTh3NlZIeEFXM0h1OWVlRCs2Z2lJcTRtWURt?= =?utf-8?B?K2RqVnpkN3FWeWtjTmxINHlMTFhXdHlVTEt0M1VjeStjZnNxaVNKOU54S3R1?= =?utf-8?B?bUhaa1FDRVdPUHAxbGNHZy91dnBoKzhUd0VUdDkzL0NDNTVPaFlUcFRiRkp1?= =?utf-8?B?OCtRbEVvYlNpZHFrNFd0bFhHWVBVUWxWTTBab09QajM3bjVuUUljd294dE05?= =?utf-8?B?V3NNckp6c2lSR2NNNTc0ZS9kRjFKRS9oaVRJbnllemJ0eDIrQU42REttWHVo?= =?utf-8?B?SmlBTk1ERU55TnB6QXdPdGFYL01GRmlRVlVuY0E0UkR2cy8vTGJNZTRBYWlW?= =?utf-8?B?UWJDQXF4RElUTG9XUElrSWN1YmFJM2tkVFBBUUdnQ3U2YURhNk15Y3NZanll?= =?utf-8?B?aHlWWUlyMm5YOXJaeFFQQ3VtR0N3M0JSZFplR0lCcFVKejdYNzFKWUs0OW5D?= =?utf-8?B?NC9OQUNYRGkzYlBkMDhQWTZyWTZGYnlybUN0Z1NwOTYyZmVrOU02QTh4aFdG?= =?utf-8?B?d1VsQVlZNmhLQnVNQWl5UUlHT1Nsb1ZpcC9oREJiT21kNVdxZHRRTVVXNktB?= =?utf-8?B?TWZrbHdBdEpGcnIrRHRGNHRoM1kxbzlBMGJWT0sxc290WVJmb3J6TUxHMGgy?= =?utf-8?B?bUVvQ3BvQVlWSGxKSy93ZzBQdHBvUnlTM3N5SnZTTUhCUHc3cFRFY1ViSmQz?= =?utf-8?B?TkVhOVNweHZHSHk4ZXZidzNyb1h4UEprOVlKWC9tbHphYWNUSCtYZGxnOFVr?= =?utf-8?B?UXYrOG84eDhhYkNXekhZVEVoWHlHOFVySWtPQm1TSHhkSVMxeFRHVlpMZ3hs?= =?utf-8?B?cmdmRjRoQ1dka1dFSGJycEw3elFZeVBVekt5UXAvSk9wVFJwbW9hRWpxQkFm?= =?utf-8?B?c001VFpFOHVoV1JIUDhQbmVpY2oxTDJYeEIyR3FwL1o5VzZiQUdsOW4wTjI5?= =?utf-8?B?ZG41MCtBWkkvMW5LbXVWY0RjY1pkWDA2Z21uZEhBTGx5VzFjTlcrbWdhbFRB?= =?utf-8?B?UDQwTkZibXMzbGEyYjF6MHVyS3p0enM5b20vRktFczJKSFpYOWtnWi96Y3Yr?= =?utf-8?B?bzZzSmIrY2dlQWNzZ3VBNWdGbDJYWjdSL1V6YTMxQkhXSTE1WXBKUksyUXVp?= =?utf-8?B?ZHBWUzVTZFNOSERNTllJREUrbHNxb2djN1hUQnZva1Z5RTJYaWhzY0d5ZFJQ?= =?utf-8?B?ZUFva3pwc0hJSEVjd0s5UXpVS3JiVzdKTGZQRGNzQmhaM2txbW10MnFoUkM0?= =?utf-8?B?SGQzRVIvYVRUMFkyOVJZT05hNU5mY1Uvd2YrUW9laStHZlFVZS9Qc2Z3bE9M?= =?utf-8?B?eVhkay9jRUZEZ2tSWlJjcXJRaXdkUVhadTRQeXJORlNmcVB5Y0c0ZDNrRzN5?= =?utf-8?B?WXdQbnZMN3RtU3RMU1lCV1QzREM3S0hKdGFoQWJUbE5PZjRpZW9INUwxMGc3?= =?utf-8?B?eElIelJndGZaWnJiRnluRGdvMWU1QW9HdzN5MjJKbXE1Y3BOdm5yMTU5cFZH?= =?utf-8?B?L3dxT0srWnRURWNlaFU0bVdRWVV4ZnM2d1JrZHAxRzBGN2VjZ095R2Q4RUFw?= =?utf-8?B?OG5mS1k1aXNLYURidElyY3RSV0dzUjFMeE9BNXZRQkVrR2FNeHJEVURaTFRJ?= =?utf-8?B?VFVMdHVxVlovcnkwalRHbXA2dGNXWW5XeCtXczFWOHFtMlgrZFJtbFJMVzlt?= =?utf-8?B?ZzR3STlTaTZkN3ZtVmxZaHFhdXlnbGNSZWV2aEJnNmw3VGdoUGo4eTB1aTVs?= =?utf-8?Q?m62c6IJ64QkwzezN54Q8hpYxZ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 477fa591-dd15-4303-26c8-08daefbd9b7d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 08:11:26.5686 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NU4UYnVYD/jF5vz6UhmDEEjtFHN6ZutJc2tXDOab17MWbYExIbXfIYlYODfVdmN59oBPY5zQh9hGmKBLOtPyRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7180 X-Spam-Status: No, score=-3030.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 06.01.2023 02:25, Mark Harmstone wrote: > --- a/binutils/testsuite/binutils-all/objcopy.exp > +++ b/binutils/testsuite/binutils-all/objcopy.exp > @@ -1411,6 +1411,7 @@ proc objcopy_test_without_global_symbol { } { > # The AArch64 and ARM targets preserve mapping symbols > # in object files, so they will fail this test. > setup_xfail aarch64*-*-* arm*-*-* > +clear_xfail aarch64*-*-pe* aarch64*-*-mingw* This change clearly doesn't fit with the title, and hence would better be a separate change. > --- a/gas/testsuite/gas/aarch64/adr_1.d > +++ b/gas/testsuite/gas/aarch64/adr_1.d > @@ -1,5 +1,6 @@ > #as: -mabi=lp64 > #objdump: -dr > +#notarget: *-*-pe* *-*-mingw* While it's up to the arch maintainers to judge, to me there's nothing ELF- specific in this and similar tests; all you need to do is adjust the expectations to also accept the COFF form of the respective relocations. That's what we do on x86, for example. > --- a/gas/testsuite/gas/aarch64/advsimd-mov-bad.d > +++ b/gas/testsuite/gas/aarch64/advsimd-mov-bad.d > @@ -1,5 +1,6 @@ > #source: advsimd-mov-bad.s > #readelf: -s --wide > +#notarget: *-*-pe* *-*-mingw* Tests using readelf, otoh, are appropriate to exclude. I wonder though whether that wouldn't better be done in a more generic manner. Jan