From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 0973A3858D32 for ; Tue, 21 Feb 2023 13:26:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0973A3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676986008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b8rKzrzrKELJDmboZ2R2oaU82ix+AUAuV+nEnZzL5EQ=; b=Xse7O5cESWN70TDtegOUHH6ytaKBOY7F41z8VA87/e1Ujw7hQEgImkTUNAcnxeqsqIglnw uYdmxvc4WW9ZuIVy6Jheo3bSzTKqGkDUDJUjGLgSpGW3S09wcl0IZN3Hs+9aORzSY1V/7m 8iRjMErF2JEltNE+98r1RR5DT+tkHNc= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-549-LENkqsniM5iKJhHkUOZ4lg-1; Tue, 21 Feb 2023 08:26:47 -0500 X-MC-Unique: LENkqsniM5iKJhHkUOZ4lg-1 Received: by mail-wr1-f70.google.com with SMTP id n14-20020a5d67ce000000b002bfc2f61048so1082114wrw.23 for ; Tue, 21 Feb 2023 05:26:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:references:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=b8rKzrzrKELJDmboZ2R2oaU82ix+AUAuV+nEnZzL5EQ=; b=qDIo5OVuClkOQ84ysk0MWHbLyqHGr7e7Ew0KCbW+zFQMeBHXAlFdrzIDDCugBT9h+x 8yOEOyzgezJTEsTXwm4kDhocK/OVDoocsV/k2nI9iZ4g31tVsoQAMEHSUvAbCMPUUb2Y 3B5pxpsfjObGuiU6hxTcSb3CaTqOv563vP0ZQcF+ZB/ISM5Z2y9Eg33Qny8kw1SqQbRP m/tD7D22ksZd/1h5ISLhLAloHU9bw0nJRWIryrxWQxjHJSPRrLBJlTgbiby3FM3aS+xH YmWHul8yY6MdjbiGcoqaiJaGPSCElBMpsb2hXIwj0h7koo1civ79rmtGC3kefBd3VCXx xn+Q== X-Gm-Message-State: AO0yUKUfB3OYpnhvNQDrhQ2g8kKrRYgNxeTgnKZIsDgUYCAn1Hp5V4ka SCVPypmPvwQ+d+aXVETKkygVjStE4zxAl9/+hNQpAHXAWVE0P2RgqbhAF0RrqJgpt7lO5W3mvkT 8YTEr3GyBG3sStRhNmU2dMVo= X-Received: by 2002:a5d:4acb:0:b0:2c5:9a0d:709f with SMTP id y11-20020a5d4acb000000b002c59a0d709fmr4828301wrs.15.1676986001811; Tue, 21 Feb 2023 05:26:41 -0800 (PST) X-Google-Smtp-Source: AK7set8+hDLsMaA9Kf6QgTgaeKgfVIhGxYxRDHwuMVW2X51dN1UVop0dDXRd2XQDqIpktiC7kwnYsw== X-Received: by 2002:a5d:4acb:0:b0:2c5:9a0d:709f with SMTP id y11-20020a5d4acb000000b002c59a0d709fmr4828287wrs.15.1676986001577; Tue, 21 Feb 2023 05:26:41 -0800 (PST) Received: from [192.168.1.18] ([79.123.86.193]) by smtp.gmail.com with ESMTPSA id i16-20020adfefd0000000b002c552c6c8c2sm2495456wrp.87.2023.02.21.05.26.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Feb 2023 05:26:41 -0800 (PST) Message-ID: <4c21a7ab-9383-f4c5-c300-dc35e24c3ebf@redhat.com> Date: Tue, 21 Feb 2023 13:26:40 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 To: binutils@emagii.com, binutils@sourceware.org References: <20230219194549.22554-1-binutils@emagii.com> <20230219194549.22554-6-binutils@emagii.com> From: Nick Clifton Subject: Re: [PATCH v4 5/5] Calculate CRC64 over the .text area In-Reply-To: <20230219194549.22554-6-binutils@emagii.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Ulf, Please try to follow the GNU Coding standards when writing new code: https://www.gnu.org/prep/standards/ Having a consistent style greatly improves the readability of the code. > + einfo (_("%P:%pS: warning: Only the first CRC polynome is used\n"), > + NULL); Is there a particular reason why multiple CRC polynomes are not supported ? > + for (bfd_vma i = 0 ; i < 256 ; i++) You could just use an integer for this loop.... > + /* > + * Get the '.text' section > + * Is there a risk that CRC needs to be calculated on more than .text? > + * We do not support that... You definitely should. I think that I will save a full review of this code until the formatting is fixed up. Cheers Nick