From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id B18AF3858C5F for ; Thu, 8 Feb 2024 08:09:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B18AF3858C5F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B18AF3858C5F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::432 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707379770; cv=none; b=vocTHAsnjIVCxYwBeDdkXR3fjADmJ1iBqAY7Y4YSWg5RN37NEtyd3x2e0I8E3R4sb+TVnr2r+bquHdzMFnM7aQvRBzrUnZe2sXpcX2iWK63GeTSaUVnX6NapKO9qeoAf6GQkOTgBsY3ffqAWGXa0QxkSzsH44BllIkCiNFdBx+o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707379770; c=relaxed/simple; bh=INX8YIpQE5+fuvrBpOOVRNzl+uHupXPxhHA/Bv1A/5U=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=fnKCUXQlQTzNDjhJA3wEcqQ79E9CmXNe4vQXe2mRe/40XNg2WE5ffP2cR12h0EBYvNQ1NYvAxVx8gzOFP661zG16lKQUsH7un0GfSgVqWYJHLvvNumOXCf44ecUF1xU2RbfzalIddmD0453gP7LUT1ZNk8kFrE+fpMx0+Yltv8o= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-3392b12dd21so972064f8f.0 for ; Thu, 08 Feb 2024 00:09:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1707379767; x=1707984567; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=S0Qk9bnjRRs2DkBQ/n7xanaTep0SxeBdT68A5cGq5XY=; b=PVDiGefAQD56e7kHeKm4t+82y1iD01iRywmYEX8JhGDssgChZ9T1ZSYGvE9snDvRDR 76a7PohqdUacNKd4jtL6uP8ivC9y9q1k3cL7+FCrcUXtE0qnQ66xZZHi/rssAgxdllO0 NemVcn29uMbUkO4o+CyxU8GkQ5HTYLfjbIgII7pzoTTChMZ3q1DVQnXIjGPihp9zZVbH Pee2ACKpb+TVdYeNoc+NcMG5P6sKcK5e4lM4dyaGvq94lrfw+19/vHFSpfFvlULcmUrs sYm87/B+iDL2gWuK8N53lF/FpWq7UH7WLhZoVTg/zs/nT4sxksSwbBYofkAxUGwB3hv1 K/Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707379767; x=1707984567; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S0Qk9bnjRRs2DkBQ/n7xanaTep0SxeBdT68A5cGq5XY=; b=vI1GLYbjWEttYuoNhV70b6DmIUAAipQyZR4YQtgCeiU1GoBxSIEE3bv0o2F6sQ3k46 JeD1l9ikbSz2oKVDvI5ZObpGgGh2CnwOUUyLEOTavpkYmSdHyDpKauk/vQP1PwsCpSwJ 3kHljwObh/DZmdoi221PBar8qxJwezDOeA4DNPYRUNt2udhu9JinOaQCnAE93KG9t3To 6VHDE2nBLEp9A2SJb4/hI3myseqR4jDXx0vkh4rgtCTJb2X0te6p311/RdsaN4oSEGBM 4lBX9dovvZadvYirEr9fKDYqucaQwxzaSaJmQUvtfIMgNYh7smSSNs8S+LoUZj28ON1L u+BA== X-Gm-Message-State: AOJu0YyGO+wD6fnQv6OsR3p3KUjzgFg3YXeN+VXc3rfOnrQPqVrXdZNz 3DI6FA5hRwZe127C89Ir9rr97ghyMPsNmJipvc7D7VNzarDRIG0MnbbLRKKQbw== X-Google-Smtp-Source: AGHT+IHYEt4cOtxR1JCL+hc/nJN+6fcno9xsTfloXnBCfqmwH7F6BQVCkiR5oHgQ2SxfdeU3mvAKIg== X-Received: by 2002:a5d:6d88:0:b0:337:c454:81a8 with SMTP id l8-20020a5d6d88000000b00337c45481a8mr5533249wrs.55.1707379767396; Thu, 08 Feb 2024 00:09:27 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id f13-20020adff58d000000b0033946c0f9e7sm3041882wro.17.2024.02.08.00.09.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Feb 2024 00:09:27 -0800 (PST) Message-ID: <4c3f09fd-c730-42bd-ab93-10eca7cc3872@suse.com> Date: Thu, 8 Feb 2024 09:09:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH, V2] gas: scfi: fix failing test on Solaris2 Content-Language: en-US To: Indu Bhagat References: <20240208071030.3712545-1-indu.bhagat@oracle.com> Cc: binutils@sourceware.org From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20240208071030.3712545-1-indu.bhagat@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 08.02.2024 08:10, Indu Bhagat wrote: > [Change from V1] > - Include a check for --32 as well. > [End of changes from V1] > > It has been observed that the run of scfi-unsupported-1 test with --x32 > arg on a Solaris2 x86_64 system fails: > > Executing on host: sh -c {../as-new --x32 --scfi=experimental <...>/scfi-unsupported-1.s 2>&1} /dev/null dump.out (timeout = 300) > spawn [open ...] > Assembler messages: > Fatal error: no compiled in support for 32bit x86_64 > regexp_diff match failure > regexp "^Fatal error: SCFI is not supported for this ABI$" > line "Fatal error: no compiled in support for 32bit x86_64" > FAIL: x86_64 scfi-unsupported-1 > > Fix the above by adding a check for --x32 support before running the > test. While at it, also include a similar check for --32 support. Okay. One further observation (not for this patch, but still related): > @@ -40,8 +56,12 @@ if { ([istarget "x86_64-*-*"] && ![istarget "x86_64-*-linux*-gnux32"]) } then { The condition visible here makes it so that on ix86 targets, no matter whether they're capable of also producing 64-bit objects (via use of --64) these tests aren't run, despite scfi being usable there. Jan