From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2041.outbound.protection.outlook.com [40.107.247.41]) by sourceware.org (Postfix) with ESMTPS id CAD3E3858C52 for ; Wed, 15 Nov 2023 09:34:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CAD3E3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CAD3E3858C52 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.247.41 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700040880; cv=pass; b=PGOneglGW3xW7JZKBFtXSbTaUI4+JYVoeB06vPjCMlM4vTcL3z/AM0d2uks91E4MmYzkovZwbEWYxeJPiIttYLvwYcaHdKQq5rkhzguSB5IRho2DPQP6ii1K6+a6Uy1ABD8f+GrgkQMbqUr4Pi1BVXdlPc2N5zC7aUYC6n/Ulo0= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700040880; c=relaxed/simple; bh=HqMbZRgaVPVht0ug44BxShlYwdUmmDoLzTjiYXAMkRU=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=SSQfYsL/LsdWqamgs6PqSZOgnedX7hwSQ8syO5tbQY8hQxJJlCNl9EpLQw5xpkKY2EvaNJB5jdH4T9UULsfC7d+znHoVBP0IOM1M40CuuiXeVCy/c6vxQyvTLX0Eqc+a1LsgIsPIg4I81wnIF7FmI7+y53iDJ9g8sGqa0jVpxy4= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cIXu2ig6dDYiT+uL8je2nF3A4/vyWntVvn1saCJ53/NaUFA5rZaGqtmYw5IMy0YQr6U6IwVxy6Bzyd4d2AeW5uNgBe/mLqgywJhAMKj8vZgDu7U4260AXUFRcEKJfjbPoubGtbwlnt9O9glvuvbXU+XJ8lmgkUZG/fTKtzJCzboFpDdXd94FQy4hTwnGF/gcMylYyoEh8KQoc8BazFevnThG4JMqc5O6hqynisNdifOqU/4g5KxYXXG2nD5yfE80E9X5E5o3OKaIBeUpUyjgKm7jH6lJvOkJIX/lG35pN3h3QuJcDrSWzqmse+v7OUeQure1D/SvFEeCKOijVY25FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9qi944ri65yxvxC+BAowP5TkUA8G8DM4r4ZSZ4NyJ3A=; b=YKBeKaJGDW5u2B3Em8Y4wFgn30y/ME6dFUn1LL3Gp6VEE0dxe6tl3twWGv7OjIQB/qazrkJbipjEQWb/YHm0hkHUqvbJTNSIfFd7nMraMCWaFqInZRXsSEsyOut/i3BBTW1yhrgeArFL7YoY8ls58LsgIw1gFXggfA/nxVbaj9Z4t6iw8ZDClc9d1yP/ANudBsKGiQwQKckM2b+u4nMuzZtMD1Zsl3zSKJi4ARAEQtTPAKikT6kde2lbCv+5npLWwx2JOMk03+H75ILYrznCJIKM0Gf0yrmLF81OzqRNosYQBgIoJHSnBXYqlMczm7VAX66x+5Z0DDQpg6u++Hfjcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9qi944ri65yxvxC+BAowP5TkUA8G8DM4r4ZSZ4NyJ3A=; b=E7yKgdPszvKytWsH0plUGmRTgn1bvNPglGT2X+9s9hb9grhl9ZuGJjY507uQJmmsutzjdeEvUCDeMoofxET+CQN+fQy5iMPiWqnFwpS/3B0p2t67pjvbegJbnafiYXm6dGePly1B0E3HX9OgBpehvIZuiZZIcmSC2Mi88givfUgeozUthJv9F57TcgXjzdv64BmRNhTKtTFKi6rPWESEuxnpjTgPRros0245cGMQCybNuXAsxXilW2mV3yNgkyDLG4EKBDAiOqDojsTFpKHPD+4T1h9aocufi1jvjPUjnuQgb5gLK0b41EtWbwIpySVBONr2DA8fQ3AFe3CY8FjbLg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM9PR04MB7635.eurprd04.prod.outlook.com (2603:10a6:20b:285::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.15; Wed, 15 Nov 2023 09:34:34 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44%3]) with mapi id 15.20.7002.019; Wed, 15 Nov 2023 09:34:34 +0000 Message-ID: <4c7a8e8c-de67-4d40-9cba-8fc04de1e309@suse.com> Date: Wed, 15 Nov 2023 10:34:32 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH][v3] Support APX NDD optimized encoding. Content-Language: en-US To: "Hu, Lin1" Cc: hongjiu.lu@intel.com, binutils@sourceware.org References: <8ed3b7a2-8cba-6428-1c01-5b6c28ca4a89@suse.com> <20231115025925.2891038-1-lin1.hu@intel.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20231115025925.2891038-1-lin1.hu@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0095.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9b::17) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM9PR04MB7635:EE_ X-MS-Office365-Filtering-Correlation-Id: 266001a1-49fe-4989-530f-08dbe5be13ab X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P2QHW4ZsHpl/FuXT04k2TRnaFZuJ9dHj6YtTMBveZTSMa0mk9MoF4lxVIYrKRHNN+kFcHF0B/kzxco0id4Hv2zbSD9JXaOhfipCcXkwE3OgGx6iSPYyPK3Br9JPCDLv6TPNejR2Q8R9/JuuRbCFXLDwwBrab2pM1XrYlLFZjiw23nrIGOlPjB9KsRMm3ThFOfuwCr2qKGNB+NW3VanzkVCpReFRd/eh783HfXyiqRfXCCrXLyYq6znw6iYS3V01EPJ+GIcamWqNnd15Yn0OdS31fgP4yjOX8BPLY/RhIWTgFy1AtMqAuNgesx3sieBKEEOvPIHFZf/xlel8na/Xb6fbucjKaki10GgdmtMISUi7buHp2GcfS3qLKgI/HJvX/P/8q9m1gZGFWgs1moSy4ZbV52DXb8ddVYIorTu9tsUFnJYEzSV3wbGf5WaTuq4x6rx+KHk7vltaEoaoQ0qpPc3Ej/OFB942aj8t6nS9nGXNFRKP/v+FaqlBhad+w9YvoZZNSU4JBBehH9/dN9DYkQ3AV2dy+NyE0Emo/VFECvtP4nkyutWRvaUZMHztqDjZO7f7bkHTFCVzrhOxtEkgcRalM6hm829gdO7jxRcbRWkcn4ZjzGbHSSc+cB6gXdtPOH9TsJbrr5rdtb4yrxqS4kQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(136003)(376002)(39860400002)(366004)(346002)(230922051799003)(186009)(1800799009)(451199024)(64100799003)(31686004)(26005)(38100700002)(2616005)(53546011)(6506007)(6512007)(6486002)(316002)(478600001)(66556008)(6916009)(66946007)(66476007)(36756003)(41300700001)(4326008)(8936002)(2906002)(8676002)(86362001)(5660300002)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UDgrd1pld2h4amdyRTk5ZzkrWjE2SllkY24wSkVvYVdQb0xmaUNmWkhCeTRY?= =?utf-8?B?bUhReVFnZzRGK2NwSGFNSkdYZFVUZjM1aU0zMHpacmNkL1FlYjRiM2g5V21P?= =?utf-8?B?SktwM2tzMDEvZlJ3ZFd0NEFPUlBsY0dTNWVGajNQbzRVbmxPeml3aFpNYVAx?= =?utf-8?B?NTd1MVFWZ0c0eDVvREZubngzZmsvdURyeVpMeEFiZ1FqTjBHZjVQdkVGN0VI?= =?utf-8?B?bGdKekVKRnRSZlc0eml4UHdrbncxWDhtaVpPQWFvUzBCUTlQOFNuR2FTMk1s?= =?utf-8?B?MVVWQkNub2FHakk5NkMva2w2bWRra21xN3pyQjZ5YWhXOFNXQ1l5enUyUWxF?= =?utf-8?B?OUcrelJaSi9aRHpHK2N6T0hTQS93VGtXVU0wbk01c1FjL3I3b1RIZjJOdFNY?= =?utf-8?B?M3IrOGhWWTFDOGRpMTVpZU9GQUdSYmdNR1R3dkkzK1lPakhlM3ZxRFRsckpF?= =?utf-8?B?d253bXE2OVhFd3dpT3lTZWFBb1J6N3lraFZZdFllT1RrZnRjQndJamJ5OVNh?= =?utf-8?B?eGpkNk5meWdRZUt1ZVBYM2FPYnF2cTZOa2VMbHl1SitzcVoxTlk3Sm1Dd2g3?= =?utf-8?B?YlFRQklVdFRmSDFVdC9ESXIvTGQvWGlPcjZvY0k2dER3ZGE4R1A5SE1maHhu?= =?utf-8?B?eVVHR0V0T2w3MGh4S1YxWjZib1RhOVR2akM3ZDF2d1hlRjYva1FYQVNWMlE3?= =?utf-8?B?a3FEOHpkVWxKK0hxMkJkd0UzdlZ6UUNHaVZXYW1xcXo0MkczOEE5SkoxeUZl?= =?utf-8?B?TTBiWlZPNEdySE41RmhoZjJuazFXbnRnOE1KbTIrbXZ4V3ord00rTjZ4eWhP?= =?utf-8?B?QVhEY20vYUpRS1J6VWY0NUJGVEJEUGRXdGdNV294YzJvTFBaQmZOVVhMVGxR?= =?utf-8?B?YXdEYnA5VWsrYnVHM2YwYzEza0I4YzlJWTBMUWlCQjIwSWpHMDRrWW9HSEFH?= =?utf-8?B?Vk0zQ0F5M3dlcmo1RTk1SzV5MkpoVGRGTllVODl1RGhkTkVReXRVUGQzTGZB?= =?utf-8?B?bkcwNHlOd05RNzVlUi9IRFU2c2pRdk9PTFZ5cTRUK3dEei9qMm5iY3J1VnJl?= =?utf-8?B?WS84c2d6YVNpQy8ySjRZeEdFMjVVWU5UOVNwVWJCS3NuQ25FTnY3aldNWUNo?= =?utf-8?B?UnZLVGdwZ1pmRDlLSFFxRDJBcGJqQlRtWmdRUm53YWQyQUI0K3EvMi9BWU9p?= =?utf-8?B?YktlRXNmRXdwZUFZTUt2bzJnZGc1L3o1ZmtWSmMvcFlFQjBLdzIxRU1JTk5O?= =?utf-8?B?MVJrZkVGSDlSdmwwS3ZYK1NZUmhOeU5yN1p4NzFaU1Nlc3BtU2kvSENsVG5p?= =?utf-8?B?VGZPNE1JWEYvRHNicnNhRUl6SU9HR1RoK09zS1ErckFndG9BVnVkdVoxVUFt?= =?utf-8?B?TS9QcFVBYkRUQnRPRUd5RjlMbGhRaGdsOU1kcHVheHJ2dFVmeUpYM1NzcFE4?= =?utf-8?B?anVQQVdWMnV1VEtRZHJRUG5Gd1RDd3NLL3RlY1RoVUVMWUpoenlIOG93Y292?= =?utf-8?B?dzdtV2t2Q2JyVTBxVWhXVXRlaVdRTk1KMkxOQzcxR0VTYWhxR01kbjdMQnV6?= =?utf-8?B?YWdpbHI5VDNFT1p0ZmIrZmdYNzJTVm9taGd4bmswZmE3Z3YzODRQbUg4Rk1N?= =?utf-8?B?UC91WlB5azRGN1ptZUNZTzJNU2h6TXVzaUFxRitRSjBsRTk4d0lwMlJDVUN1?= =?utf-8?B?MkV4dE0wcUdoMGlYQlFtTEFkcVg5c1NMcTI1MXQwYzFGZFIrVmhoZ01BeWVa?= =?utf-8?B?ZjVWZ3A0Mm1nK3F3VEZxQUU4N1FaWnBoQWg1cGhUT1NWZll4ZUhsV05vNS9h?= =?utf-8?B?ZU9MVDRmUk43NkNwRzB0WWswNWRYeG1hWEszSUdVOC94YmVDdmRZLzNnQjZu?= =?utf-8?B?NDFlbys1U2EwdVZnTExTcTdNMDVVNFhSU3VmNm0xMGhaSUhNN3B2TnBsak8z?= =?utf-8?B?ZnplbkMzbUFBRHVlQjNaRUhZOUpxLzFxZVhnSGxwNnZXeGhHenI3UU91b3ZB?= =?utf-8?B?RnJXRm01WngreE1ESmFtNWpKZVp0QU1PVVRhU0lsTTVZTTh3YTE4WjJQQWlr?= =?utf-8?B?aVkra2pnN1JIMU8vMkN0WWx2UmxJWDlLNUh6OTdqeDZHNkZ5V2lsUlg3N0Vt?= =?utf-8?Q?SBNWhJ1fF/89eceshjY38UQcE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 266001a1-49fe-4989-530f-08dbe5be13ab X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2023 09:34:34.0980 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8IzUA2pgymv610870SXF7GWouKQ1FiJpcIolvQshZI1ZEuQT8I4ssz1CJ98e9rHXN+e2DTHxT1W4Ba1BJB4V7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7635 X-Spam-Status: No, score=-3026.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 15.11.2023 03:59, Hu, Lin1 wrote: > --- a/gas/config/tc-i386.c > +++ b/gas/config/tc-i386.c > @@ -7208,6 +7208,43 @@ check_EgprOperands (const insn_template *t) > return 0; > } > > +/* Optimize APX NDD insns to legacy insns. */ > +static bool > +convert_NDD_to_REX2 (const insn_template *t) > +{ > + if (t->opcode_modifier.vexvvvv == VexVVVV_DST > + && t->opcode_space == SPACE_EVEXMAP4 > + && !i.has_nf > + && i.reg_operands >= 2) > + { > + unsigned int readonly_var = ~0; > + unsigned int dest = i.operands - 1; > + unsigned int src1 = i.operands - 2; > + unsigned int src2 = (i.operands > 3) ? i.operands - 3 : 0; > + > + if (i.types[src1].bitfield.class == Reg > + && i.op[src1].regs == i.op[dest].regs) > + readonly_var = src2; > + /* adcx, adox and imul can't support to swap the source operands. */ > + else if (i.types[src2].bitfield.class == Reg > + && i.op[src2].regs == i.op[dest].regs > + && optimize > 1 > + && t->opcode_modifier.commutative) Comment and code still aren't in line: "support to swap the source operands" really is the D attribute in the opcode table, whereas t->opcode_modifier.commutative is related to the C attribute (and all three insns named really are commutative). It looks to me that the code is correct, so it would then be the comment that may need updating. But it may also be better to additionally check .d here (making the code robust against C being added to the truly commutative yet not eligible to be optimized insns). In which case the comment might say "adcx, adox, and imul, while commutative, don't support to swap the source operands". > + readonly_var = src1; > + if (readonly_var != (unsigned int) ~0) > + { > + if (readonly_var != src2) > + swap_2_operands (readonly_var, src2); > + > + --i.operands; > + --i.reg_operands; > + > + return true; > + } > + } > + return false; > +} > + > /* Helper function for the progress() macro in match_template(). */ > static INLINE enum i386_error progress (enum i386_error new, > enum i386_error last, > @@ -7728,6 +7765,21 @@ match_template (char mnem_suffix) > i.memshift = memshift; > } > > + /* If we can optimize a NDD insn to non-NDD insn, like The terminology here wants to match the function name below, i.e. (as indicated elsewhere for the name, in reply to your question) "legacy" instead of "non-NDD" (assuming the function name is changed as well, in line with that). > + add %r16, %r8, %r8 -> add %r16, %r8, > + add %r8, %r16, %r8 -> add %r16, %r8, then rematch template. > + Note that the semantics have not been changed. */ > + if (optimize > + && !i.no_optimize > + && i.vec_encoding != vex_encoding_evex > + && t + 1 < current_templates->end > + && !t[1].opcode_modifier.evex This is more fragile than it needs to be; it would imo be better to indeed go from opcode space of the supposed alternative encoding. Perhaps that's going to mean checking both. Jan