From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by sourceware.org (Postfix) with ESMTPS id 3139C3858C50 for ; Thu, 4 Jan 2024 12:55:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3139C3858C50 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3139C3858C50 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::233 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704372932; cv=none; b=CrYHdFI2ptUByX/BT6lCIcbB6Vz2mh+eMccH9FmTSiSqqxkOe42xNIU2nseZWulcO9nv0zHeZikPLI3Z0+kBW3SPVU96z0PrCeLqcV6FWWPNuZvk9aVxUfHANnOj9IAtd5s6mm8wdEaYd81zaXlWKK7+s+udvZAIgX/UzcM+Sfk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704372932; c=relaxed/simple; bh=93kk4XzQkUbgvNo8lP77KW2C6orM7gPhekVkpUavb44=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=NXSObMfk9lgQQKa79WmMFz9qU8a0cbFGitMef6sDuNnwMf7h9Oir5/UBJS4XYc/v7FpCogD+9MRCirdigEJGqBJ0wl3TuS887n9QRNkOzP+n4e7ghaN9whhEO/0G9q2btsDcKhjEgzV3I3X5o1m614zPRhEn2eC71PxjfLJCBQE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2cc9fa5e8e1so5647711fa.3 for ; Thu, 04 Jan 2024 04:55:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1704372928; x=1704977728; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uw8eNFzdTpm10hB0YqNq90ixwaDpLPj1KmGfZkBKbnc=; b=K543aC4Km2J0Ndj3z9kS/ZmOwd4n826I+LFP//FSlwb42DOQ6wp/LpXlVbZGZU0w7o GLU/O67+aAboobqzstI1/V4ffTya5CK5RajykIP1+3j22wPum2g5Q47vncg3w0bzElRG GCKXphHzeMEXbYbnUFdOHdlrLYDF5bvT6tx0KUZwiIbFdsmBofJylSyn6wYSZYoLehKP 8CTg7QDRZnN9pMkvKDFYUxrAspE18OgwXjJCztrofWDqz9cfTuGNdosRsSVyfuGkmkmf EAwG1/IubIZ2YxGzQcVxC9aa2Mzi6/ry1dO1O31IJG063pkUZugtWEpL7ZeNNsvrrIld spmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704372928; x=1704977728; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uw8eNFzdTpm10hB0YqNq90ixwaDpLPj1KmGfZkBKbnc=; b=INURmgyrhjhtNE9qAEyORSIJG0d0vtpsEZQiGzq2JHZ8UaRTFBPlhaKSQFCA0Kis2D DgQDdavg0dPqiC41R3GC+MXxF7ICz93A+7DhUFZHp6toPK9b2pcrUQLfpveJKipSPt5X 976f/2cMQ9GDZHLxTxZEdowZOVXLX96NK/9d80A8HCXEhZ+lqzwQEm2aqNXhHSfK+M1m 7YN4Hz8FxKvCnO7KHvoST7C/Gd8E7y3015eqFrLfOHW8vZowmg2v1IGCJJ6nvn9d65Rn 6eEniaxsqk5HDsmnTQu0YcQmqah47RiLBmVo+E8Wfh2gFSIPHQoSSed2Ke3JzZfyRSi6 tuCQ== X-Gm-Message-State: AOJu0Yz8GDxBOLAcXiG1H7igu6iqsjqn+fe0o+wuX6j8BYsT2TBS46pf aJ8yitGqhrftqZTSXc8NDpPqO2KxsSx1cQpZeCrvI3d0Hg== X-Google-Smtp-Source: AGHT+IGlGblGfbKr3TnAvSAGBie2BZuX1szZm+ryzRW7ws4m6Vpbxi27vjSZgJV0HxvBlDvkBxQTBw== X-Received: by 2002:a2e:a313:0:b0:2cc:7127:ebaa with SMTP id l19-20020a2ea313000000b002cc7127ebaamr259202lje.94.1704372927980; Thu, 04 Jan 2024 04:55:27 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id o5-20020a6bcf05000000b007bb8e90726asm2382596ioa.1.2024.01.04.04.55.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jan 2024 04:55:27 -0800 (PST) Message-ID: <4d182eeb-091e-48df-aa1d-c88b2dfec811@suse.com> Date: Thu, 4 Jan 2024 13:55:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/9] Support APX GPR32 with extend evex prefix Content-Language: en-US To: "Cui, Lili" Cc: "Lu, Hongjiu" , "binutils@sourceware.org" References: <20231219121218.974012-1-lili.cui@intel.com> <20231219121218.974012-4-lili.cui@intel.com> <1a796802-5267-4c88-abc4-dda4bdd262cc@suse.com> <23d613db-1b3b-49d1-96d2-2c17a5d63a46@suse.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3026.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 04.01.2024 13:32, Cui, Lili wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: Thursday, January 4, 2024 5:08 PM >> >> On 25.12.2023 13:23, Cui, Lili wrote: >>>> On 19.12.2023 13:12, Cui, Lili wrote: >>>>> #define Vsz256 Vsz=VSZ256 >>>>> #define Vsz512 Vsz=VSZ512 >>>>> >>>>> +// The template supports VEX format for cpuid and EVEX format for >>>>> +cpuid & >>>> apx_f. >>>>> +#define APX_F(cpuid) cpuid&(cpuid|APX_F) >>>> >>>> I think the comment wants to go into further detail. Please can you >>>> go back to read what I said when I suggested this construct, in >>>> particular regarding the stripping then done? However, with you not >>>> having found a need to fiddle with cpu_flags_match(), I wonder if this >> construct is needed in the first place. >>>> The earlier suggestion was entirely based on the assumption that >>>> stripping similar to that for other combined VEX/EVEX templates would >>>> be needed here, t >>>> >>> >>> Seeing this, I realized the problem and checked opcodes/i386-tbl.h, >>> for the following entry, we want to set CpuAPX_F and CpuBMI to 1, but >>> gen.c doesn't seem to support the format "cpuid&(cpuid|APX_F)", >> >> I suppose you mean "cpuid|(cpuid&APX_F)"? >> > > I tried cpuid|(cpuid&APX_F). Currently this format is not supported. Right, and it cannot be without adding yet another CPU field to the templates (which I'd like to avoid). Hence why I thought you mean this form, despite writing the other (recognized) one in your earlier reply. Jan