From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by sourceware.org (Postfix) with ESMTPS id 428893858D1E for ; Thu, 28 Mar 2024 10:10:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 428893858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 428893858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::536 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711620660; cv=none; b=Z6OqPi4oS8LyQvKm4/A81RSCJOGyadL4SrUYYWh/shis9g1DpZ2/irt/PC4qXynIy96kvrBOVeRPvYQYIpMjk56WXw11FiC/cx2oQeB5j39Z1pG0OY3Aa2amitqCeXGkzELoC0Z3/R5naeKcl6Fz8V8y+bECgnUoNnZGYDECON0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711620660; c=relaxed/simple; bh=vAJKrXDmaEtUph4DwVwIyWNQfCLouCF2psiY6AeMTU0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=MqU2P1htwqH9iFHZj6ky4vARMZq7OP3mQeqHFVX5F6ZA+7Z+1sI/7LtI7H2EjtekgC0+MCc13W1h0ze8SH2HDuzIt+IgM/4coWBpPrjhYFri4hDywqNlWhDjhysAAZAa4vYs8gA7wxe42udh4NYAVKoUVjiiBrWIAH8CZiRqWD0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-56c404da0ebso1166569a12.0 for ; Thu, 28 Mar 2024 03:10:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1711620650; x=1712225450; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FIDZZGN1wBclXyTtJ11c38hXCa8uSWHeWLkQQn/iKC0=; b=ZcssJAD6BjY5ER0Op6cIPgNoQXaMCz2jYbJSDVQtIOX8bkso9gKPK7M0LyMXfV9vu0 a36i7NhJY2EqsQFy1sLM/BKur95s9fIVHdcstWdgahu6u1IzpLw5PTAID5BugDfmByUa OVMbV+fQt8wtRISsGzUcocQ7UtMLzSVsue9YuW8QEH0rY8B+n0nCrXNmZqgwj/hN09Wj oUyB5BvCAeL2QPWnR3ogWPu8Vi49vfY0wFx75hpFcAQaEANItXw9nuxGQwrAdc94XfeH rcQ4yp68NIP3AI8wL6Vcrg/042vOQKLXX6sAx8bxNumIgMhwHiz+ss6K0nKImJKf3U1E jOtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711620650; x=1712225450; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FIDZZGN1wBclXyTtJ11c38hXCa8uSWHeWLkQQn/iKC0=; b=d4HtEhgln0oMMATLFM4mVHxYmA3+3my22ftHiul3TIuYVVoSSfno045Osi8ByW6I3F KaIzQ1MFZ8iJPFYlfjUrOAfYp1QyQf+hUqGEtA/U//pgAcia0oBcOg1AK+kg9/bXLB6k A9NwKat/CXUd/uUD+7ZZsVN6FxJ3ecc7NWTcQP4fqKwM+ZAV/vCmo/nkYbE6PAoe0aP1 8CND0pz32/u45CWIe3eYoj31+bJ/nkLTGuYaBC50XCzoiEt8T4Mu8I4+5VgYGgukBrpI GsqQyjQCWDvfJYfk8vrYLfC2UVyL9p6/mpsHfdaU4IA0C8oinNGG3P4B3kW5R10l0wCd 4euQ== X-Gm-Message-State: AOJu0Yx/6imuVjFU++BR+snF8nmrub5YIb7UJCsjf9s3WJ7CZQyan3sS PT/Ax0W/PFShujaNi9Srb1cTwgS/hKufRnMa5qgct0ek+lQAw0sG9qJe0DPoCjn1egjfie5imRY = X-Google-Smtp-Source: AGHT+IEY9tnqTE9om6oPzzobXfQZfrNQzII1v+KcHFB4LUIxPB7x09Y1zyUZ7McZfmWtubkN39PKhA== X-Received: by 2002:a50:cdd9:0:b0:567:2cf:1ecc with SMTP id h25-20020a50cdd9000000b0056702cf1eccmr1584787edj.30.1711620649895; Thu, 28 Mar 2024 03:10:49 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id p14-20020aa7cc8e000000b0056c4372c161sm657323edt.55.2024.03.28.03.10.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Mar 2024 03:10:49 -0700 (PDT) Message-ID: <4d4ea89d-09b4-487d-8507-4a7ed3a6fdf4@suse.com> Date: Thu, 28 Mar 2024 11:10:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH, V2] gas: gcfg: fix handling of non-local direct jmps in gcfg Content-Language: en-US To: Indu Bhagat References: <20240328075909.4134867-1-indu.bhagat@oracle.com> Cc: binutils@sourceware.org From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20240328075909.4134867-1-indu.bhagat@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 28.03.2024 08:59, Indu Bhagat wrote: > [Changes in V2] > - Add function level comments for ginsn_direct_local_jump_p. > - Add a jmp to locally defined label in the testcase to make it more > complete. Also, add a jmp to label defined in another function. > The testcase now generates an additional warning (as expected): > "Warning: GINSN: found unreachable code in func 'bar'" For this - can't you simply omit the unreachable pair of insns? Other than that, looks plausible, so feel free to put in. > - Use formatting style consistent with other testcases. > [End of changes in V2] As a minor remark, this entire section would better go ... > The ginsn infrastructure in GAS includes the ability to create a GCFG > (ginsn CFG). A GCFG is currently used for SCFI passes. > > This patch fixes the following invalid assumptions / code blocks: > - The function ginsn_direct_local_jump_p () was erroneously _not_ > checking whether the symbol is locally defined (i.e., within the > scope of the code block for which GCFG is desired). Fix the code > to do so. > - Similarly, the GCFG creation code, in gcfg_build () itself had an > assumption that a GINSN_TYPE_JUMP to a non-local symbol will not be > seen. The latter can indeed be seen, and in fact, needs to be treated > the same way as an exit from the function in terms of control-flow. > > gas/ > * ginsn.c (ginsn_direct_local_jump_p): Check if the symbol > is local to the code block or function being assembled. > (add_bb_at_ginsn): Remove buggy assumption. > (frch_ginsn_data_append): Direct jmps do not disqualify a stream > of ginsns from GCFG creation. > > gas/testsuite/ > * gas/scfi/x86_64/scfi-cfg-3.d: New test. > * gas/scfi/x86_64/scfi-cfg-3.l: New test. > * gas/scfi/x86_64/scfi-cfg-3.s: New test. > * gas/scfi/x86_64/scfi-x86-64.exp: Add new test. > > gas: gcfg: address review comments for local jump issue > > ChangeLog: > * gas/testsuite/gas/scfi/x86_64/scfi-cfg-3.d > * gas/testsuite/gas/scfi/x86_64/scfi-cfg-3.l > * gas/testsuite/gas/scfi/x86_64/scfi-cfg-3.s > --- > gas/ginsn.c | 47 +++++++++++-------- > gas/testsuite/gas/scfi/x86_64/scfi-cfg-3.d | 32 +++++++++++++ > gas/testsuite/gas/scfi/x86_64/scfi-cfg-3.l | 3 ++ > gas/testsuite/gas/scfi/x86_64/scfi-cfg-3.s | 43 +++++++++++++++++ > gas/testsuite/gas/scfi/x86_64/scfi-x86-64.exp | 2 + > 5 files changed, 108 insertions(+), 19 deletions(-) > create mode 100644 gas/testsuite/gas/scfi/x86_64/scfi-cfg-3.d > create mode 100644 gas/testsuite/gas/scfi/x86_64/scfi-cfg-3.l > create mode 100644 gas/testsuite/gas/scfi/x86_64/scfi-cfg-3.s ... below here, perhaps with another --- separator. This way it's clear that the revlog isn't going to be part of the commit message. Jan