From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2048.outbound.protection.outlook.com [40.107.247.48]) by sourceware.org (Postfix) with ESMTPS id DFE1F3858024 for ; Wed, 23 Nov 2022 08:36:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DFE1F3858024 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kLUlPWT0p4j1FmAsNxoJXBJszhwGRC5LaIk1iph8PcqTMFxph7RoV89Lf2IFlUcn91vqaH21FtKjU8rFy2QhlcUUvoqXM1qaUjiCw6C01gxlFTAZogy51GJrhQuBLBrbTJbawvaThi/nCHiJFmqS2RBAZpIa+oQXSb5CJANSH4YmICwK+6IKRoI19Sn0epv0p6R85kb9c56sx9Mh7UISluscK0uqZUr8DBwFjNIbRNHJ6QHftFOlOKc5u0f+waz1GffuhZUaOo6du6gJCAk7mFb4GgagdKUvbptCqodjQ/HxWxXpYAt3ARDRofwBVJoFnmKMbkiT/X6TjqM6iX3r9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EvOxQqXZ3wtlA35nzMphz4vq3vvp6NlIRJZbiYjB3Cg=; b=oQb70otL+l8pMac8Z/Azpt8KSLQGoM2JPzIgwS6Bp4GTznRQj0e9lON4u2Y3d4cpStbSbd8kTbgNqT4pIiJCz0ZkBh7cA/W/oAiLP259ire1AOTpqJwrhwHF4Rt+dNQoMOrXtYbP3NAYs2M4knwvgsxHmlnmZQ78BeWCGwJ18w9k9vqI82H8EbKFPl9y3jRrmOqKnhW9hSSyVecnTdQnco6bkgydHc9LKSL4pmuU8uhLxnok1cMG7Ud2EE/XnPYF8Vbay9Pf9jla5iiXSTs+ycbY10mN6JcuaaGEUoFmkhjpqaL35y++vVWpcOvFdD5UNTfQuvh/f6m77ZiIk/I38w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EvOxQqXZ3wtlA35nzMphz4vq3vvp6NlIRJZbiYjB3Cg=; b=vIWHmys7Y+PrQ2Nua8k7mNP45yb1KgM88TPGel35V6yNPiCquPZUbHfUpU4+NutP1xlqyazcBKi1XSrroOf1UgumTj1jsYISyrqdm87E5+LHkhvGTxZyneTGwOUpAxLOMetttKYrkYAO32M9xjVZovZrhkOvwovCWRLToAVbQhj2GqUXk5P78C7PYjGohyGTYW/ifb/1vLJ5B5AuoXXT6TaI+bEacTtpX76ZiCDwxfJtPk+OjzVXynnMTCSzhgRJGJ6cYyHUl57nYLURn47s9+RU8TX8TVEu0l7kSpfb4NVXCq1XwLA+RF83c0QJF7d3mzOmc0rafejGSkLJC72UgA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8934.eurprd04.prod.outlook.com (2603:10a6:10:2e1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.11; Wed, 23 Nov 2022 08:36:15 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5834.015; Wed, 23 Nov 2022 08:36:15 +0000 Message-ID: <4d995c45-7e4c-4f66-5459-1b1c33aa4dd8@suse.com> Date: Wed, 23 Nov 2022 09:36:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] x86: Remove libopcodes dependency Content-Language: en-US To: "H.J. Lu" References: <20221122181927.251937-1-hjl.tools@gmail.com> Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: <20221122181927.251937-1-hjl.tools@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0021.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8934:EE_ X-MS-Office365-Filtering-Correlation-Id: 5422a485-bd99-4800-d1ac-08dacd2dc8a2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NU2qaZOsVdTpzukVS5Dxp4DK33Blrkhpm4F/JycQjULK/5tTy1Nv3wOIfHFGk0fqAnmZTpa5uhlMBLWkf+hXFuEB2Jc8EENXZlUpBrm1y4IThGdZ74JSpr5x5GXfCwKei4j61HoComfSSH8NdM332g/fnnUqmrpYWgJA9pFtsZP76O+scsxu99tzf/os7xh3B/vQCA7RwKeBBcJWqMsA1KjU1Zv3YkDhQJi68gu4wffxdxIQxvHePoNXm1alviOclVDOG/b6EEObeMKmsELm0FuVeN/Gpn7Eg7iJ5GaOGfLI+G40LEkBlM8vbQ75S7Ay+qdm8QJQek6upv+RFEWodVVvypCQ9jAVCcCDD2c3e2nK+zpWRnR+ypSRMj9NRFaCeYQAm3ebjuLnJC6ST+OhJ/N2DHwVKqtE0ELzGaQpagaeorvyzLfwEEnzB9wcsqWAlogUYD3d/br5GHRqIWjI99EmZPZwh/06xw0jZPoIPpMJc2rPF/LvPp7sAlg9xQPZHtosuZCqR+xwu1ESYAFWGN6yaRcHRMSePVszuWnSDzWg8pQfktOg/lSMlOFq5G4hV01iZDuh4H9kJU0piKZAxFY8aJMVgJ8fbkkaMDAmA6u50JjcJs4A9t3qLECIf6Bk1p/SQWV4dm3mdM1Er9o4e7bxplgwCudPNLSGppR4cuZgCAjVFQa0XvCTpxpB1AhVWGQiFuJyfFGT7ef98m9HlfglVNAy0mZE1tufHU7ze4M= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(136003)(376002)(366004)(396003)(451199015)(31686004)(36756003)(86362001)(31696002)(38100700002)(26005)(186003)(2616005)(2906002)(6512007)(6916009)(8936002)(5660300002)(478600001)(6506007)(53546011)(66556008)(41300700001)(8676002)(66476007)(6486002)(316002)(66946007)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T1gvS1hSVjl0WHZoK2tRUHhkMEptZmsrbWVZeHhxTHg4WGRaOTRGNHZwQng5?= =?utf-8?B?d1FxSW40VldEb2V0RU5JR2g0SlhaMS9LTkRaYkhtbjZnYXgxYktQeGJJTkdB?= =?utf-8?B?a0F4b25yZU5iVlhNZWVaVlNpN3o4V1FOYy84UzVKVUw4TWoxZktDT3BqUnls?= =?utf-8?B?WFNCdHhiWDBlRmlQRnRZU0c4cnJ0WHFJdnhvZnE0L0tPMnAxZlIwYnFTRUVH?= =?utf-8?B?YWpsMVZxZml5eDFFUG5WZ3VYME5uOG02TGRybmNNNW96NHVkbzljcGdWZHdz?= =?utf-8?B?ajI1bFhtSlcwR0VvZ0xyWkxqK3RVRnovWUtHRkNiWklKaE5VOHJoVW5DYUgy?= =?utf-8?B?anlUVUxjNG1sZTJmcG0vdVhwOE9JNTFDemxRSlhvQnpUWVJXYnJBaFYyS0NW?= =?utf-8?B?ZDQva0dkNzFPRk1ZejAyMnBSZDkvRldCa3Zpa0JybkJ6a0EzSndyTURKTkJN?= =?utf-8?B?QzBRNnJkTnc4Y0txdUpvUzA4STg4VkZ3SzFzMWREcHI3WUxUNno4am1xTVJQ?= =?utf-8?B?SnpNK1FLLzg5QjhjbDA5ckxxcGp2dGRvb3hscFcyWlhNU1FIRjRrcEovaUY0?= =?utf-8?B?bmtFQUVTRWtNVGlpSDlBMHZpQnlDcmttbE1STllDbkdlQ0VLZEx5RFJKYlRF?= =?utf-8?B?R0xOVDBCR042RUEzODB4a0xsN2FCVjNUVmcyTnZ5bTNpcURQeVlyQXk2MGRl?= =?utf-8?B?SVU5d24vUmdBL0pHbnRicXJtaGg0bzFRMERkUEtYWFRTSWNVREdJTEYwcWc4?= =?utf-8?B?SFJpQlVSWFZXNEhPRWZjeG03Zms4RVhlMWNFaVB2eFpvb1FnaGZ4LytSdjgr?= =?utf-8?B?TDRNNkhTMVIxU29KRTFyUktaZEVvWGR4SGl1cEpvNGJxdmt1RHhmTE9VNFVa?= =?utf-8?B?S3Jnb0IvK1gwTDArZjRUQmcySTh1bkh0VzNwYmJwaVNHcHJkaUY5Z0h2Q01l?= =?utf-8?B?Q2NKdEdyZ3JsdDBjM3Z4bEFwQWNTa0ZIVkFUMUNDRjU1cHVCUnM3dHZzenhI?= =?utf-8?B?Wk9jNUlaVWRMdTE0dkgyczFEbW1LVGMrNGgyMjVkYXZ6V2FDTTk5cTVtcENx?= =?utf-8?B?a0g1R0svd1BFblB5VVJoNDJldS9qMDdoZisrdEEyTnlxd3RWRG0rck9Gemtv?= =?utf-8?B?bFpIK3FJbmN5NVkyZ2Q3eGJvSFNpODB2UTlTNjM2SFkyQ3dMRmtMbEp5ZitL?= =?utf-8?B?aFprRTFlKzBNR045bzFGSXJESUdXVzBWWm85d2pQK3ZZelBPVDBSdmQ2RENK?= =?utf-8?B?L0NrODhsaTVJa0ZvWmIrbWhmK3pRKzcrL2k5djQ4ZDBOMzBQK2pPbHhFc0hh?= =?utf-8?B?b2lwRTFnK2ZqcEJVVFdTa2JZZnp0Vko4eDNLRFJUbG1kT1g0ZjQvS2hKOXZT?= =?utf-8?B?eGVya0pzb2tDamdDalVBRS9ZRklTVDBTM3JLZ045VE83OVAyQzlhZ3QyREtT?= =?utf-8?B?Mk05Y0xNMlBXeHJpUDV6aWV2RWFodzdKclNFOGpMQXVueTQ0MnZyN0RFUVAx?= =?utf-8?B?dDQ4YjZxVy9RbExDdFRLbGlWa3hDWGplem9PWFh0OVNJVVptT2krUmFoWmtO?= =?utf-8?B?MzdFMVIwdUtUMThoMlRncktTa3psbG8vaXlkZ2hjb3hjK0VTMkZWT0JVazhk?= =?utf-8?B?dXVGQmc4QVhlWFA3aDJMM2xOa3F3djFSbEVya0k2Y2xsTDhkeCs4ZDh3dzBh?= =?utf-8?B?aGsvaVp4VmppTFo0SzBKM21sRVdiMHZDSHEyalZVSXZMZUlRTUlCamNnUytD?= =?utf-8?B?R1liSlUvdnllWUo5Zm8xTnh4amhsaEZrU1BCYWM3UFpJbW05UnVZU0V2bWRy?= =?utf-8?B?MXI4SjNoUjROTE5qZlNuNXZLVk1ySmxOR0JDam9NV21PNmphRDlhOWJ5UHRM?= =?utf-8?B?S3hRdkN6dnQ4TXA3VWkwTjcrM3pCVUtnaTUrY3NMb0lYWkxhK0RoZWRGbkdY?= =?utf-8?B?bmtJbWJJZHpIMElPUmpkam0yTExPai9wUEcyZk5SQUtJbUFRNmVXWE5vb2dx?= =?utf-8?B?Z20xZlhjV3lYYkNiL0dSZ0cxVm5RR1BpL2F6L0t4djRqNEdjM0c3emptRlFU?= =?utf-8?B?QUZBYS84MFRnV0xZbXhNY01FOHErbWFWUml3TkN1SnhPUllIZ1VpdjdTYXFv?= =?utf-8?Q?ucscNFqcd69SxFJv3qnYkd8wP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5422a485-bd99-4800-d1ac-08dacd2dc8a2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 08:36:15.1244 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: inak8Dyi3MNiP4x9AHSDN/BugB8y8HZHWalkFLnxCbwCOOEt1OFsWqkVgcB8UQBLAlfwC0TEhzDYgbOfRihvMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8934 X-Spam-Status: No, score=-3029.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 22.11.2022 19:19, H.J. Lu wrote: > --- a/gas/Makefile.am > +++ b/gas/Makefile.am > @@ -446,6 +446,12 @@ development.exp: $(BFDDIR)/development.sh > $(EGREP) "(development|experimental)=" $(BFDDIR)/development.sh \ > | $(AWK) -F= '{ print "set " $$1 " " $$2 }' > $@ > > +$(srcdir)/../opcodes/i386-init.h $(srcdir)/../opcodes/i386-tbl.h: \ > + @MAINT@ $(srcdir)/../opcodes/i386-opc.tbl \ > + $(srcdir)/../opcodes/i386-reg.tbl \ > + $(srcdir)/../opcodes/i386-opc.h > + cd ../opcodes; make gen-i386-tbl This recursing into a different directory (and then even using "cd" and "make" instead of "$(MAKE) -C") is what I have specifically avoided in my patches. This is deemed an anti-pattern by many people: If you consider running make in just gas/ is an okay thing to do, then running make in just opcodes/ is, too. Yet with such a rule doing so in parallel can result in strange collisions and likely partially broken files. Therefore with my general maintainer hat on I object to such an approach. If you really want to generate the files from gas/, then you should do so there, i.e. also going as far as building i386-gen there. Once again I did consider doing to, but deemed it awkward: Even if we don't use libopcodes.{a,so} anymore, I think the opcode table processing would better remain in opcodes/ - we'd use that library no longer as a binary but as a (generated) source code one. If you think differently, I wouldn't object to you following this alternative approach. As a formal remark: In the description I would expect to be credited at least for recognizing the opportunity; really you've re-used some of what I've had in my patches, irrespective of you perhaps having done things from scratch (and having spotted/corrected an oversight of mine, which I was about to submit v3 of my series for, but which now I will wait with until the above is settled - sadly meaning yet further delays for the growing pile of other work I have pending on top). Jan