From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by sourceware.org (Postfix) with ESMTPS id 5E0DA385841E for ; Wed, 22 May 2024 06:21:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5E0DA385841E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5E0DA385841E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::529 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716358885; cv=none; b=vrnTLwyepwm71h7LCLM4KdwUuZ/qG9m+fcIuvl3Bml5lJoOdL6uJbnBeru3FiG8AWn3+XNF8atpw9kTue8blHsCyiX/rBkv/LU1aPzvA5ywlSKiNqCSwutddvVM/pYkRwKfI7/DYL1jGr5CiMaiHd/r2oUOqJUWahV+jK7vlC/E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716358885; c=relaxed/simple; bh=Xc0Cf/KmQkMDd+3YM15XHf5L5j9HbLYylZwUaAON0G8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=D44GHjyw7vZ6swlRxdDvJTBYcJpAe+kNosGhl/JXtkG/+Amdn6PjNzuoKOqS5Ra7evOPgX4skpmPsfUUnLFI7OVWxIX3D3UKdmxt8IG8bKx8X0AvW3s90esFK6KRsPHWN+AXeCp0BaoS351HHoLd3XPILUtpb2qe1B+5bk5Mdm4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-572f6ee87c1so9258277a12.2 for ; Tue, 21 May 2024 23:21:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1716358879; x=1716963679; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xhsEq4WhEoN2q0k6w43HSrdoTkXh9+aJGIpDGu/H85c=; b=RaV5/+tpW8oJukbR4PFBqhVkXdHeqpAPvO2kt3rvU2LhfNhBrL5+EDgCDvAUi3WB9W d6JqfuHHRvA1P7YIaSzJBaBIAa7Tx7M180No6HE5yWsYNUhgnWERwhdIf/qZlS6bd1L/ 5Yc69ZQVNrf+aG7i/hXQZ8E1h/G+LJqFLohYonAYovNrlk4delaBcJOa1v6v13dSoX9f bLykf/YVGouN0Xf9hiJLtUqz7V5BoUopTr1rHasystH7uiZ226Q0GmwTVhYLVRexyKwU arixeW2DOf563ImDYQNcOKbFFMfC2lJ9uQQOXBY//M05YCct67IKc9LZcHUt6FZ648S0 1y3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716358879; x=1716963679; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xhsEq4WhEoN2q0k6w43HSrdoTkXh9+aJGIpDGu/H85c=; b=RF7MbEYFAm4qf5Rzk+HdriCOSUO++d2N/LlBg6eDBx/7rWxENB2xZejgDe8RckBzk7 l5TX0pjcChGWS9Yx/Vdt3nut94/kLknnfLeLF6f6eyhKmimslaQ99YsjGHLm6qvxlP6g JQVLpsUg2Jo1KJF6Q6bEulT3U0iHwCPlYp6sroVfCjQPwaIe3BtHXkLvW8xsaOQU3vSs HlEhr/F4TycITxKI0WzzbIBakvjMDLBQhldvifqZmPYD0HBW2TvO052n5mAwwlsOjcMp nflQfaOZEJIvI8pSowotaRgYwTU6DJJLWcuAHU2z4QNy010JD5otT0Ca4PRzapS7QRwO nqUw== X-Forwarded-Encrypted: i=1; AJvYcCXCRpiWeakTOu0GrXBSsAyme3rE5LHW6ga8VKb1Ys4OehWRgvnqAZ2anFA4w69C9ZAGn3AGRTXNlUV7ZN4zNzK9gOWDZboNuQ== X-Gm-Message-State: AOJu0Ywxr9woHJJDUjU0geSXxw/QOjo0i4NUO4ADKuaDU7X6N/IMVddl nocNqNA7RqDYNTJ+gs6TkkrEC1YWRBlsFswAFdAVwtFtsUgD29cITNwjcac9/A== X-Google-Smtp-Source: AGHT+IFUMeitepf2yk+4UnjzzXUm3Jv4cItYWG/iq4OaBz/zlmXL3xfstSIJwPVxzorA8w1Ix6xMlg== X-Received: by 2002:a50:9ec8:0:b0:56e:743:d4d9 with SMTP id 4fb4d7f45d1cf-57832c6c0c6mr443603a12.42.1716358879058; Tue, 21 May 2024 23:21:19 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5733bea65aasm17808715a12.5.2024.05.21.23.21.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 May 2024 23:21:18 -0700 (PDT) Message-ID: <4e246773-03e6-4c02-b0ef-fc4893322626@suse.com> Date: Wed, 22 May 2024 08:21:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] Support APX zero-upper Content-Language: en-US To: "Cui, Lili" Cc: hjl.tools@gmail.com, binutils@sourceware.org References: <20240520062202.1297234-1-lili.cui@intel.com> <20240520062202.1297234-4-lili.cui@intel.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20240520062202.1297234-4-lili.cui@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3024.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 20.05.2024 08:22, Cui, Lili wrote: > gas/ChangeLog: I did specifically ask for (at least) one thing to be added to the description here. You put that in the cover letter, which means it'll not end up in the eventual commit. Please put it here. And as before, please try to get used to not, ever, submit patches without any description, unless the title alone really describes it all (including e.g. implementation decisions taken). What you ... > * config/tc-i386.c (build_apx_evex_prefix): Handle ZU. > * testsuite/gas/i386/x86-64.exp: Added new tests for ZU. > * testsuite/gas/i386/x86-64.exp: Added new tests for ZU. > * testsuite/gas/i386/x86-64-apx-zu-intel.d: New test. > * testsuite/gas/i386/x86-64-apx-zu-inval.l: Ditto. > * testsuite/gas/i386/x86-64-apx-zu-inval.s: Ditto. > * testsuite/gas/i386/x86-64-apx-zu.d: Ditto. > * testsuite/gas/i386/x86-64-apx-zu.s: Ditto. > > opcodes/ChangeLog: > > * i386-dis-evex-prefix.h: Handle PREFIX_EVEX_MAP4_40 ~ > PREFIX_EVEX_MAP4_4F. > * i386-dis-evex.h: Ditto. > * i386-dis.c (struct dis386): Add new micro 'ZU'. > (putop): Handle %ZU. > * i386-gen.c: Added ZU. > * i386-opc.h: Ditto. > * i386-opc.tbl: Added new templates to support ZU. ... mechanically put here is useful to see _what_ was changed, but it's entirely unhelpful when one wants to understand _why_ things were done (perhaps a certain way). > @@ -10877,6 +10894,18 @@ putop (instr_info *ins, const char *in_template, int sizeflag) > abort (); > } > break; > + case 'U': > + if (l == 1 && (last[0] == 'Z')) > + { > + /* Although IMUL/SETcc does not support NDD, the EVEX.ND bit is > + used to control whether its destination register has its upper > + bits zeroed when OSIZE is 16b/8b. */ > + if (ins->vex.nd) > + oappend (ins, "zu"); I find in particular the OSIZE part of the comment somewhat misleading. For SETcc operand size (irrespective of any further insn attributes like [embedded] prefixes) is 8 bits. Nothing to say there at all in this regard. And for IMUL while EVEX.ZU indeed has an effect for 16-bit operand size only, what about the bit being set when operand size is 32 or 64 bits? If the doc is to be trusted, the this is benign, and afaict you follow that by emitting "zu" in such cases as well. Just that the comment suggests otherwise. Once again: Okay with respective adjustments. Jan