From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70082.outbound.protection.outlook.com [40.107.7.82]) by sourceware.org (Postfix) with ESMTPS id AD5EB3858C20 for ; Tue, 16 Aug 2022 12:15:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AD5EB3858C20 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=QM07u9Zx/wLj4Kfsf12j4ZZFr5fOBa4/aChMmmD7doyDH7oRkwCVEwHV3027oYNpel4kuIZvQlEqbuj9T4thpFjr4N0j0SJIh8v6/O2zurY+2RuU0agK1jnCvyi7fwYOomaOXQfm6juVwG6lAhw+odX/RTeO1CmpdevyVA5704Zh/qWm8wKPtriba3VrNwRFLCcSe/V++vS6SjI8CEwdUpwZGw0w2DWf2ot48rJll1ml9bJJdzGD1RD43vhOAvGNXojApcOQM2GyB8LP64LErMEzU+aXtdqYwvAXlWalRxcw7ye+OUJY4RpmOKnmM0CGnseJI/rREHFud0X/nS6ylQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uaKGqM/tRiExzj+8BkaSwKgbPx5wZPFn9ZjJk49D0/Q=; b=Mi0qB7TUzS/uHcEy+29XwqgSVGHbskQmhC3zReMbzwMJCQNxBnbe2VdbQjeUmLgdi4k8UERP2o0VeDaRgOHW6KuxDbUpoujfbHh43rmi6/EtlUMB3c5W/r5IT8W4v9d/cbvGQacGcaQRmY9Hcb1J9EbrhGSKrZVHhN1sUAjKwRMR03Kzaj5e+xHGv3cz45j+YZnp/t5YRMWsnwm0+UZvGDx6s/QwP094yBcJ0MicVTGhdfC59W4YHbmu/bQsADxrgEEpkX9vLIAvJRtcepChnhIngC26+g+vRveOpWYlbNPxc6CVvayaRLvZ315KFdqtvqUEDA97Jb1F4xPzZKq9HA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AM6P195CA0054.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:87::31) by DB8PR08MB5433.eurprd08.prod.outlook.com (2603:10a6:10:118::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.15; Tue, 16 Aug 2022 12:15:34 +0000 Received: from AM7EUR03FT008.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:87:cafe::85) by AM6P195CA0054.outlook.office365.com (2603:10a6:209:87::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.12 via Frontend Transport; Tue, 16 Aug 2022 12:15:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT008.mail.protection.outlook.com (100.127.141.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.11 via Frontend Transport; Tue, 16 Aug 2022 12:15:33 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Tue, 16 Aug 2022 12:15:33 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 49a97f1295cc3dbb X-CR-MTA-TID: 64aa7808 Received: from 085cc51e229d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4A7F8DAE-2C2A-452E-A4A6-A20D77639920.1; Tue, 16 Aug 2022 12:15:26 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 085cc51e229d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 16 Aug 2022 12:15:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D740jukUOrPpzRktgEgbZHRp5W/SXU3N6cahaVTOkd2ubEbRnUaOf6aW85OHx/nc6+ncpjVLQOYBYLdIOZRhOCxDimKpPaQoLXfe7/OQmbIwCc8z7ue0thcLgLLFtBZkwXi4eyjDD6nJNQp7Aq8ixvg1IrmUCUf3ScIr6THlNQtcE/ewERHTnMZrs2vzJQ0E7B7Q76LIYpzZy1VhrVA1wVGEE7rF5f2hy4/PD3Gm/dvYSozz5nELmAEZtWjkaDHZ+ZJnd6EIv+ErDhNetsJXZMjJWapLFyIqrbV578f8dLyYAajgZ8joOScuOaa5Y55P5L8KlExFEIs0aQQn9ofZdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uaKGqM/tRiExzj+8BkaSwKgbPx5wZPFn9ZjJk49D0/Q=; b=VmUHlBZ0WxOhdK5Xs7kD7+HpO7rHTIwPYAALtM9ctBvfSn7JUILXxC4Os+0/mXR9o5+lOPpTP3F3FoVuKzdA4o65U2zmRznY3YoRRrInXM3T9Cd3WWdo6TRXyvZ9E1pK62TTUwZNrj2ALUHuYkJqDDhqeE1LJ0hLKY0aQ3YGjDEt1wxR+1Q/gLZDK/NV3nKvxdyiHlEgjgz2GQQLcVFG/evEBHomeL9AIa1tl4JKnfpzgesAXD2g7KJeIPldc779Qb8QRQOuCbF1VqKdShV7h5bum5J6iO4nQ1DkbzsNNFeTicT32bv88DH+zflSpC1huzn70gKYM+/Imvxwcck2pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by PR3PR08MB5578.eurprd08.prod.outlook.com (2603:10a6:102:83::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.11; Tue, 16 Aug 2022 12:15:19 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::cc64:9170:b12d:de8]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::cc64:9170:b12d:de8%4]) with mapi id 15.20.5504.028; Tue, 16 Aug 2022 12:15:19 +0000 Message-ID: <4e48346a-14ca-b536-403a-3f2b345778dc@arm.com> Date: Tue, 16 Aug 2022 13:15:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] bfd: handle codepage when opening files on MinGW Content-Language: en-US To: Torbjorn SVENSSON , Nick Clifton , =?UTF-8?Q?Cl=c3=a9ment_Chigot?= , binutils@sourceware.org References: <2fe3fe60-4039-b9e8-4212-4d9f62e270cc@arm.com> <9a97b2fa-2aaa-95b6-b491-70c05cd6aa3a@foss.st.com> From: Luis Machado In-Reply-To: <9a97b2fa-2aaa-95b6-b491-70c05cd6aa3a@foss.st.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0034.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ae::8) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 7e109fa4-4322-4ee9-40e6-08da7f810517 X-MS-TrafficTypeDiagnostic: PR3PR08MB5578:EE_|AM7EUR03FT008:EE_|DB8PR08MB5433:EE_ X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: /oCi4EqFKoLlD0Qc+yze88VXcWfChlamuBCgLcEUeUnhHDEIxSy8RoQ/HH0OA5A4ZL7ZSYnKOUY5A4JWTUslHvPn5eQ2XV3hA1lWx4MmgBs+taka25PSYkCbEhDFRCjWVb9+6IQXN46NUPwWAMwmbommjyAKAXf/G7Rb2x/OIXVY8jmJcf68NXKSv+H/aYwYSwUr/xiy2IG7gSs6MobQ8fgX7n5gl9GiMLrgcsUb6bvebFKvFpO8G5Gk7V8uli4vHsiUQFQmqcZfJOPR2Sl9b64QT71il/vN8g4V8JsBku/0xTIRiN8vMKQWoz5EmQoG7wZGYeSGB51hFEKWJLGXbZkiBLG/7i0gfmX8ElfvuKs8Y+sk8BIUerUobN2m3MoACdECW0aM6wcjHQ4bkucDQXmZQ9gMsXKaDNy5gepSLRT+kKCxYQARf+iQjE5tvGnNU1WYpT0DkhjdXvUonDVplDSDDNXrRiYX+hrW8Jo2rxMtap37wHE25wH0DD6JVA5b+7XZaZJyHQSZXUrtOPEeL2aAYsfm10QU5wVo1jkDcokFIVqtBx7B9fXG8waEYXfdKTaDjJRfaOYxbxc7tZG1VNMTuxmVB1ZWOdgcPgBYMPs/Wntfu4zfTHOptz0Bw90y0j+4ThYUIVbyuzorFjc3gv5ee917+klc8r0Rkbw/9PS/5nYtq3CEFEhokSGSFq3V5BUODPzuGC7terWNeSLtD/7HOi1r7nEqAtGBJq6OZnMPIlSUrfzLs1x2NCNF4BdCxCVvBBR49lHBjbLLCLL2NjvENjj5n6M6QVfBbaUed6XU3fLK6TD/f2OQm0n7LXNCPNYPl25m3uGQb+KCEfS2X5mldvuOp96dpYAeFpjXc0c= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(346002)(39860400002)(396003)(136003)(366004)(376002)(2906002)(966005)(44832011)(6486002)(5660300002)(478600001)(66476007)(66946007)(66556008)(8936002)(38100700002)(8676002)(31686004)(6506007)(86362001)(26005)(186003)(36756003)(6512007)(2616005)(53546011)(31696002)(41300700001)(110136005)(316002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5578 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 691a3dc1-1111-457b-5933-08da7f80fbe3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bv+lzHELRe7ZRST7G1/mkuhyhCs9hhZ9LYclu8lNCfSDWysT2zq34cPvU4SnBA2z51GIR/eMocYKg6Eehbv0OlKldps9G8/bJoLORL2RtP/AECkRUD/5a7JtQXsleElQ0QLDxSgq7LvFVLB8hdU632p1sh31wNLadzJJlJz+MvvBRiy+hUgb+RGY2g3C+64Q2tm6lVH2RbCdvwaP+5Te4/Z9gdH+EOBR8RgyPxjvuVd7j33r3kL0IHVCOck8fHuVUEmGUYGRHza01Umj/sn/PV1U7zW13s4xLdeLCeJknGJBcydNycKZpQrbDpmwcD8OiWfagIY/i9mcX4M2L034GHlzw4zBENT/gGbBQhm0TLhAIB2sX3nSekhxGnkvWSTOWqSmPXgXIbrb30vf87bQ1Q0UX00zOdIVyEKGMYm8krC1qoAla0yUyNlgppN2K5ACYBzYhGGsxN20IGYyMf7ye9Cn1LWc5xR8bx9D4MPWhzUV8hdedrhNOhbmQYirKqRlv7qGhfCy7JcUqMOSKuuWnNtZ+pigQk57lU4GVrvQIF+7HbDaTmvjgch2eRbace8IIjRYVMgFtRbL7MbfBPF+Siypewdqpm8WprCGQEL3bWEKIiC3zX1eQY7dXJAQa9E5AyS2FG0oy9Wf743gHxA1l7NdNKl1BnGG7ZqfXjVsqLAMpfsxCSQCHrr5gpR/fD3dElyE60Pb8D/lnSsQujxXAvnyLX1JMsWIH1FIrlru9CbpZRZ6aQ2eL66Ysc3ehlCSevlhJLWbczNpARuDvFDTyVm5mnoskajdwmApTVe6VH6AUY9Iq3Y+IXRneZTAToi4719jk8FdaarF46kVifFYT573KyLQk/02i5m9zWOv1No= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(346002)(396003)(136003)(376002)(46966006)(36840700001)(40470700004)(70586007)(36860700001)(336012)(47076005)(8936002)(8676002)(40460700003)(966005)(6486002)(82310400005)(70206006)(356005)(316002)(31696002)(86362001)(40480700001)(478600001)(82740400003)(81166007)(6506007)(6512007)(2616005)(2906002)(53546011)(36756003)(186003)(5660300002)(26005)(31686004)(110136005)(41300700001)(44832011)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2022 12:15:33.8640 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7e109fa4-4322-4ee9-40e6-08da7f810517 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5433 X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, KAM_DMARC_NONE, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2022 12:15:39 -0000 Hi Nick, On 8/15/22 12:38, Torbjorn SVENSSON wrote: > Hello Nick, > > On 2022-08-15 13:07, Nick Clifton wrote: >> Hi Luis, >> >>> In fact, trying to build master binutils-gdb with Ubuntu 22.04's mingw-w64 8.0 or Ubuntu 20.04's mingw-w64 7.0.0 runs >>> into the following: >>> >>> bfd/bfdio.c: In function ‘_bfd_real_fopen’: >>> bfd/bfdio.c:125:28: error: implicit declaration of function ‘___lc_codepage_func’ [-Werror=implicit-function-declaration] >>>    125 |    const unsigned int cp = ___lc_codepage_func(); >> >> So that would imply a missing #include of a system header, yes ? >> >> Do you know which header provides the required prototype ? >> >> The code is currently conditional upon __MINGW32__ being defined.  Perhaps >> that check needs to be extended/changed to reference a different preprocessor >> symbol ? > > The problem is that the function is not exposed in the MinGW headers until the 9.0 release. > I sent a patch that fixes the build error https://sourceware.org/pipermail/binutils/2022-August/122423.html earlier today (with you on CC). > >> >> Cheers >>    Nick >> >> What Torbjörn said. We need to restrict things based on the version of MinGW. His patch looks good to me. I just wasn't sure about the _CRTIMP in his patch.