From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2041.outbound.protection.outlook.com [40.107.241.41]) by sourceware.org (Postfix) with ESMTPS id 023E9387089E for ; Tue, 4 Apr 2023 07:01:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 023E9387089E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i+WNI3VBJSBF7ivtG9sb+At5zyiyXmYRTZty6h7b+FOyQBx5UuzwMAW1kSdgoTXPjE36V42/A7m56tLk6mpmP1vkXbbSEIEost66avaxroK1MbYDq0/ttQGk9KTCS0ozsO5+maGW90SkV1RkzWc2iapVMXpGeBv76U+oGpaTSIQ683abxPy9fYcdtWHqpYqaeOqRkpwQnKZOBQWY3+s+ksYA0JjXnKCxyxNB+84poOd8nd7m5rIe+nngqnjKyoeeGNTJsGw6zgso9rpx1znkYmInEwq0hfSRD5B+WkbDHK9nM95tk4pNRyUTGkCY53NJ5c2z5DRWvhqpGkNdlnGicw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xkfqYloa/PDiwlCbb1vyR9GZmXPsT1zKijns1eXwzQs=; b=Zlue9a3PI/o/wp85cV52hSEDXEuAx4+NfcORVlE/noH8w1bcqmqDiu6C59EzmjgaihLAfXaSiHRZSTSOnvTsYiT4WpfyJSDmeAIfenbhAOfdwmbmj1mSRJHb/aVJPu3bR9YuW/SGt4hYSbi6068hHd6ren/dbYaUxTTYetHUSxOuXSWv4XkmPGRGrYPTLSOKXnUlbyflQ7AMqNNuU+7TnlLk8cVCq908tCCnqChN+9//7sbjuCSVCi9PAUEuieYiY1Y7WROz4YN1jp6kJh1+ctx9onhehfQ5fq9m/M1TVxDNly82dBNvuSr84EQo2r6OXlxm4WWXIOc7gOSmOMv8Uw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xkfqYloa/PDiwlCbb1vyR9GZmXPsT1zKijns1eXwzQs=; b=1C3NnPlPmVQIeq+W7y4D5eOD0oGZVC6YG+406y3P2OS3hVVF0DJnLbF1OLABZueDkf60KRyzxuWAQBZTJSrksQLcYXx/7lfaRZztIlhKQaSMnnGq/lHrG6dkD2neqNl9yScy7gUmaZBDz3biL7fvTXyRh96yD9SaRzfP/J0nzRxmwxHPnAwIBROGmFvGKnkzR7/xXyX3Sio+i2/bNV9tPVBURiDjsyENAI4TsK5r4Wt84PCYmkAj9wwUO8FwT9RQrRrRuFFtE5u7X1+W61MHPflSeCZcUoP7lHBvAp1aOyuWj6XlEwRA1ue1L/PhCgcYxUURE+CJ/B5qs4p1T4Cknw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8609.eurprd04.prod.outlook.com (2603:10a6:20b:424::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 07:01:33 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 07:01:33 +0000 Message-ID: <4eed4c72-002f-268e-b5cd-0929bc57d6d2@suse.com> Date: Tue, 4 Apr 2023 09:01:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: [PATCH 8/8] x86: drop (explicit) BFD64 dependency from disassembler Content-Language: en-US To: Binutils Cc: "H.J. Lu" , Alan Modra References: <5dac45a8-cd5f-ee4d-52fc-7d283fc29ec4@suse.com> From: Jan Beulich In-Reply-To: <5dac45a8-cd5f-ee4d-52fc-7d283fc29ec4@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0040.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8609:EE_ X-MS-Office365-Filtering-Correlation-Id: 88bc02e5-45d0-43bc-f7c6-08db34da6c62 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LXhv1G5cbivlM9B+UjogR6rCii/idR0ARCX5fxQ46r+4QJHpt7PFLyO8V9rzNJ5c1FppQEjCEkl5H/ZYDLnpyc5CPksZoLtAdmu9IBzRBnNEJVn9nDT3mwHuYdLmBI1rvmbAitFrMdSREdBDipw5abqEDXjs2SE+JeaIZxB8bWG1+EzPcWhrw65mgOEu+N1ZiREgzAkjTAQTaxS4wVe7crQYe3H4ifiJRzR7yqVhIPsj9hRL11gZdpUYKhAHijoarwC/jcZt4SusGC5GN2zitdlqYAigVZnC0L2XKzDEgi5CuzA//lS/znbC2W9nPqzc5Ngl81tC/aaNix3Xc6fVhCXlGN9NPS4TEX6y2tIDBwkFvJzo32YW87CET6ol4o7k1NjVtfZCXecWlU4Rtqu/6GEPo7/RahPrk3KHI/FaTUIUWmmJsHp5tFtuC/lEM31fa1Pu7hBT9nHHOST00DIgkjKtf9aQGSjhvDmb1vycJXsGoJwaHgdaAIJBPQKTo+qejM2dk3bGD4SvXY10oU8gEue+jpHtmcoqk7EmbKPbOQIqTWpiL3CmTmxChWKfhwVA00umRjIxuV3tFEz+C8eOr9haxtvSGakX8hoU9rLiJJvDjdTu1hEaJ5G1C+LNzpzvAwqjXM+Vzfvd890b0GU0Kw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(136003)(376002)(366004)(346002)(396003)(451199021)(31686004)(6486002)(54906003)(66476007)(66556008)(66946007)(8676002)(41300700001)(6916009)(4326008)(31696002)(36756003)(478600001)(316002)(86362001)(38100700002)(6506007)(6512007)(186003)(2616005)(8936002)(2906002)(5660300002)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L1UrNmFMSnI1OS93WEdBSExoUjlBZUF4NFBqWE9zbkN6aVBDcFBSQWM5R0xp?= =?utf-8?B?bEdKSFR1V0wvbHlCOGt2L09JdSszdklVQldpT1VHVG9tMzJoVndRZ0hzRkZm?= =?utf-8?B?WDJWMXYyZllGSzViYjdyUjZydE1ZV21iQnFsTjJ4M3hzWTkxb2c3UDNwMWNj?= =?utf-8?B?TU9YL05rVjV0TnZzNmpqSTJlUlpGZzJlTUNhVEovcHFQOXJjOENnQ2NGWEdO?= =?utf-8?B?YnR2TkdCUkE5Um1PSUQwWFIxaWd3RHhKeUxyK3J2S0JkMC9nMkRDWVRtNkM2?= =?utf-8?B?dFM0ZisrUDlhZVBNSmhZRFpKZ1RBakVmdmJJZlljbUNEYUkxZXhrQWJ0WDkw?= =?utf-8?B?bzdOUThLV3BvSHB5akdlcThMYUw2MmQ0OGJ5Q2I0QjZpb2pidjJVWm9YMnIy?= =?utf-8?B?K2l1cEM5UDZYL3Z5TTZxaFNUOU9VYXI1M2dLZldBZzI4TlVYNjhzcFFaVHlO?= =?utf-8?B?NVJRbGVxRUwvWUhRcXludkxncFo2LzdBeWtiZzg0V3ArT3g3WDAyODVpbGJl?= =?utf-8?B?WVRpaDk1QlgxMEFKblFKdTVpV2FPc29TcVJ3c1hsbE5zL25TUDVydUlDeS9y?= =?utf-8?B?SkIwOWM1ckRwdnA1QkFTRlhkbFpiY29sdSttK2FqSHFmZ3RWaHZXUGNHL3lY?= =?utf-8?B?KzJLb292NExpNjMrNkFwTUpWYUVld3c5YUd0VThkYUozcUlUWnp2c1ZhSE85?= =?utf-8?B?SURUOUxZc3dGbkxEUnpzcGUyWFhhOG9tU2wxUXRmNkwxVENOZUxYTXJBYkJv?= =?utf-8?B?YjdMam9hMHpPODM4Z3QwQm9JU2VzN2E2amM0YWhyeTJ3MHZZM29jUytCVlc0?= =?utf-8?B?ZTV1Sm1QYVhHSUVKbE4vbWRhS1lqVEJjbVJ6N3BWbC9KTjl6MkRUa1J3MnhS?= =?utf-8?B?M1FZOG15NlI1a3lvaFVscmU4R1FYWHViQkl0bzMwMmZ5dlg3WnRkZFpXcUJm?= =?utf-8?B?N0dWV3BVNHFRMUU5NWNRTkZlcFVoSGJwT3JUK2doMld5L0J3SnpxOVVudEM5?= =?utf-8?B?NndxaUV3d3g0emtQeE43VDZicW1QMFdRTGRGS0Q1SWVyNE5TY2Q3VnRsdFRh?= =?utf-8?B?VXZDeW5jU2xidll3TVZuQ1VaeTJKQXh2ZythWjBQVk02Z0lzOW84K2FZcCs2?= =?utf-8?B?VlNZa1h2WUZHamVzZGZUNWp4MFlKSFhwL0NuZ2ZLZUIxT3h0WkRnYzYrU0ND?= =?utf-8?B?Q2pIUTlNbjR5K2hHK29VR2NRemI2elFoWlIxaTlKdnpyaWtMR1YwazRqY1Z1?= =?utf-8?B?ekZnSTZ1UGxGZmF0Q0RGUS9tdnN5MWwxZzVyQ2xVZmsyT2tEamc3emgwZXp2?= =?utf-8?B?U29ZNUJPdHlSRzlnR3hQb2lMQ0tBc1dTRVZLMlBEMjhxRTVwNWhNK1dqUXhk?= =?utf-8?B?Y2w4aHV6MlA5bWFweXk4OVFwWGdpWFhEUkxJOURvTzVaZ1RnUmhkVW9teVo5?= =?utf-8?B?S3Z2VFVKMUFkb2V6ZXJueXB2cjNFelphQ2lXc2VzbkdFZ2VTa1pVLzh6NGgx?= =?utf-8?B?TjJDV0NYRVNmRUVLUlBhei82SENCVFZKNWlhdkh0UU5WNWtpTXFHR09oSnlV?= =?utf-8?B?Wlc4ek93M2RPLzFlM1dhMWZ0L0gyeW1sS3Q4anZwcG9rUTcxelN2TGZkOVJu?= =?utf-8?B?U1kxaGhWbjV2NnBZTWh0Y3FIV2JzMUlOQUw4dldpQ2xHVmFtVzFNV25rNTE2?= =?utf-8?B?eHJzdng3blVXdVBtSzJWbERic1k1c0ZSWmdBUG5hamxMUisrOHFYaEpwalUx?= =?utf-8?B?S0pIeWZwMEhFdDhiU0VuOU9lQUJOUUtwRjZwcVVRcGE3bkJ1dnd1a3kzdHF6?= =?utf-8?B?UE1aSXZBbWVHQTN3bzBDdnJHRzloSzZaeXN5QlZaalp1SHBOWG1IVjdlOXkr?= =?utf-8?B?QURRU1Jid05aWFRKZ0twUGhjbnFVZWFhTzQvOGZzUytsTjZiYVNBUWdKTEtM?= =?utf-8?B?Z004QnFRZG1EM0xDN3YyQVg0Y3VKdWsybFFjTStzT2FrcFJqZVhUUEVpOExZ?= =?utf-8?B?YWdHdzNHV0RsOHArWUhPT0JWcDIybFdhaFEraVlZTEtCcVZkNXl3L3pSb2lp?= =?utf-8?B?LzJUYjAwb3NvWE9DeStzb3ZSQ2JpRjFwTkVFZHpnSGFITVBBY1ptbGMwRER3?= =?utf-8?Q?+GjwW5J3w2fQ1Pfl8SGKrWQGH?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88bc02e5-45d0-43bc-f7c6-08db34da6c62 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 07:01:33.1319 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: P0eOX82Mb+lFtZ+2dw2huVRciBLCwIVyizFO+3r5TsNkKkt2RG/qe0V5DgjtmNHrkiE+nMoMcjudqP6S8L3Yfw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8609 X-Spam-Status: No, score=-3027.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: x86: drop (explicit) BFD64 dependency from disassembler get64() is unreachable when !BFD64 (due to a check relatively early in print_insn()). Let's avoid the associated #ifdef-ary (or else we should extend it to remove more dead code). --- a/opcodes/i386-dis.c +++ b/opcodes/i386-dis.c @@ -12329,9 +12329,8 @@ OP_G (instr_info *ins, int bytemode, int return true; } -#ifdef BFD64 static bool -get64 (instr_info *ins, bfd_vma *res) +get64 (instr_info *ins, uint64_t *res) { unsigned int a; unsigned int b; @@ -12346,17 +12345,9 @@ get64 (instr_info *ins, bfd_vma *res) b |= (*ins->codep++ & 0xff) << 8; b |= (*ins->codep++ & 0xff) << 16; b |= (*ins->codep++ & 0xffu) << 24; - *res = a + ((bfd_vma) b << 32); + *res = a + ((uint64_t) b << 32); return true; } -#else -static bool -get64 (instr_info *ins ATTRIBUTE_UNUSED, bfd_vma *res ATTRIBUTE_UNUSED) -{ - abort (); - return false; -} -#endif static bool get32 (instr_info *ins, bfd_signed_vma *res) @@ -12571,7 +12562,7 @@ OP_I (instr_info *ins, int bytemode, int static bool OP_I64 (instr_info *ins, int bytemode, int sizeflag) { - bfd_vma op; + uint64_t op; if (bytemode != v_mode || ins->address_mode != mode_64bit || !(ins->rex & REX_W)) @@ -12785,7 +12776,7 @@ OP_OFF (instr_info *ins, int bytemode, i static bool OP_OFF64 (instr_info *ins, int bytemode, int sizeflag) { - bfd_vma off; + uint64_t off; if (ins->address_mode != mode_64bit || (ins->prefixes & PREFIX_ADDR))