From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-109014-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 89086 invoked by alias); 17 Feb 2020 15:27:27 -0000
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <binutils.sourceware.org>
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
Received: (qmail 89076 invoked by uid 89); 17 Feb 2020 15:27:27 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,SPF_PASS autolearn=no version=3.3.1 spammy=HX-Languages-Length:1268
X-HELO: mx2.suse.de
Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Feb 2020 15:27:26 +0000
Received: from relay2.suse.de (unknown [195.135.220.254])	by mx2.suse.de (Postfix) with ESMTP id C6960B40B;	Mon, 17 Feb 2020 15:27:23 +0000 (UTC)
Subject: Re: [committed, PATCH] x86: Don't disable SSE4a when disabling SSE4
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>
References: <3bc597bb-10f9-80f9-8e00-f28aeb2eea77@suse.com> <CAMe9rOprBKRvUA5=KANDewxtdc+-N=1R7DnziB8x=LiW9TECsA@mail.gmail.com> <CAMe9rOrfhifWFpVKh8i37x6LY8ggkALK8ck4BcLxnT5P616rpA@mail.gmail.com>
From: Jan Beulich <jbeulich@suse.com>
Message-ID: <4f3e5233-fb2f-a957-2788-8ffde3939ce2@suse.com>
Date: Mon, 17 Feb 2020 15:27:00 -0000
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2
MIME-Version: 1.0
In-Reply-To: <CAMe9rOrfhifWFpVKh8i37x6LY8ggkALK8ck4BcLxnT5P616rpA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2020-02/txt/msg00393.txt.bz2

On 16.02.2020 17:47, H.J. Lu wrote:
> On Wed, Feb 12, 2020 at 9:18 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>>
>> On Wed, Feb 12, 2020 at 9:08 AM Jan Beulich <jbeulich@suse.com> wrote:
>>>
>>> Since ".arch sse4a" enables SSE3 and earlier, disabling SSE3 should also
>>> disable SSE4a. And as per its name, ".arch .nosse4" should also do so.
>>>
>>> gas/
>>> 2020-02-XX  Jan Beulich  <jbeulich@suse.com>
>>>
>>>         * config/tc-i386.c (cpu_noarch): Use CPU_ANY_SSE4_FLAGS in
>>>         "nosse4" entry.
>>>
>>> opcodes/
>>> 2020-02-XX  Jan Beulich  <jbeulich@suse.com>
>>>
>>>         * i386-gen.c (cpu_flag_init): Move CpuSSE4a from
>>>         CPU_ANY_SSE_FLAGS entry to CPU_ANY_SSE3_FLAGS one. Add
>>>         CPU_ANY_SSE4_FLAGS entry.
>>>         * i386-init.h: Re-generate.
>>>
>>
>> OK.
>>
>> Thanks.
> 
> commit 7deea9aad8 changed nosse4 to include CpuSSE4a.  But AMD SSE4a is
> a superset of SSE3 and Intel SSE4 is a superset of SSSE3.  Disable Intel
> SSE4 shouldn't disable AMD SSE4a.  This patch restores nosse4.  It also
> adds .sse4a and nosse4a.

And where is it said that "nosse4" means only the Intel flavors? As
said in the commit message of said change, to me the clear implication
is that anything called SSE4* will get disabled.

Jan