From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2076.outbound.protection.outlook.com [40.107.21.76]) by sourceware.org (Postfix) with ESMTPS id EA0FF3858CDA for ; Wed, 11 Jan 2023 08:10:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EA0FF3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O6DpxNGY9pl5A3vn2dcZa8+hKaH/7ke02b0DcfyziLLg5Z2QG2WfPzf+a5nxFFzOO2lp74SV5mycYEuQqyrOWXQ0DKt8ATY+AUBAGLWOPtF2cOvk47/J3mjHnF28SOITBT7fOK9sl/uCS2X/JOr3WRB90jdxhUKtLBwky7eHw/rWSKECijhDs7/XFbFx0M0Eb9wm5d35gZv//7xZZPQh0aF0/jR3Jpnt01qlcCupo2fn+uWTcATJNmyFGIOOsyczN2T2zsjUjKtwnaQ3j6ajTAoSFOYFE32NKdklH4nSYfwBEfXqzya7GDva1wUNF6cmlxpOoZrKWdEKohZNsvAonA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UyXcLxswfzwUk3+PQAy7XV5Q8PNEj+PRD3EsRYvi8B8=; b=iUXmCTJRIdX+Qfw06ImL+nTkueZ4IlAVaxJpXwOvWkvf5S1xKyV1D7HoAVEDPBv82i0DwHPoUr6trrhJfcjbk0+GB52Av5Wjo6qAkHU4rZ7AaO+rcUmusIdH31bh0avRmngqocT9f1GiZI0cXd/mZ+fNNYNStPEZJ/UaCB8LizM9abOx0FDS45bpjMNPlcNIBuGR1fXo89w8vZLBaerbD6Ih1RpQirIdGVJqP9HER+hm8EjMNK6uI7b4KRuaGoK8gI2Q/4V6KK3DdspjWZdKZjfqJrPQ5T+nXOFcwCI1ROYzY5mxf6yTU8ni9NEQGMEsXI3cdxwP2RdzLh1zeJEMAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UyXcLxswfzwUk3+PQAy7XV5Q8PNEj+PRD3EsRYvi8B8=; b=Hsz6Yqccazto3it/KjO2SHDz0KpAKNqn8A6B3jlUQKZJxVCVxsxaz77swJzHpRTYznjI1aGdeyYvz2nVcB1DgPpNr2lpwFTBaj2Pv4HAj5EbQGIJ8vqL5MW0DVhZ/jjFnFpI89ge0Vpssuno1HtnPaUGUGP5RSbmd8eSNj9p5K4XFB8sjmRWXgUCc3FQ/fqyp6Qp6k4yf+ROWipoEAT9S45DnmTSEhK+HH95RYt+S03SX3Xho8SBTmi/L+EFbsgvKdqqPbHOplRkjio/st3Asejt7g9Tw3Js16RIA1ZzmJqnd86xBIBq05+eieycp2KpiP42r1DXi9DWdh1l99e01Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7564.eurprd04.prod.outlook.com (2603:10a6:10:1f7::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 08:10:24 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Wed, 11 Jan 2023 08:10:24 +0000 Message-ID: <4f6774bc-0df8-2341-1602-f4afb036b861@suse.com> Date: Wed, 11 Jan 2023 09:10:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] ld: Allow R_X86_64_GOTPCREL for call *__tls_get_addr@GOTPCREL(%rip) Content-Language: en-US To: "H.J. Lu" Cc: binutils@sourceware.org, Fangrui Song References: <20230105210542.3573076-1-maskray@google.com> <0c9cd182-ce08-6720-1e51-d7171f075641@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0147.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7564:EE_ X-MS-Office365-Filtering-Correlation-Id: 79269f80-4b16-42a7-ac64-08daf3ab4a69 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jjvtdpCe7rEq2k8R6XjFTrugRFpbh8jW3ReMMNvgr9qovct/KtrJDoShO1txgpss9R+WZY+iO1pjhLZoEORyCUwidmZbu75wDZBoV6dJN5yU2XsJi+KbQK9A+UJGIOCIkyGFg9eHcctLk0gVC5F566laSZtgwMCh5BGr6D0G93gePoCvT6IZPNS5tKWT6znbTQ9YluUtHgwwz9fllV97/ttF+byOO1En6Z9ZIoj9dJvKEtQd6ykZ9ANiu84z82m71/ILCapLq2qVJfV6v27lONWi6u+qnhhFj3/pitSU1rORpb+wudSAJ2pRAfnfhWhQZu8oCRwO/M4kqxbYGhcFrwxVba09SUuRRieoduf/iDlRwT+nh4H3HIFPpcM10wFhTHNSW+v5owdlSphWUK/pvU7ymZEoEwuHQc/KXKAHjvdRrqWSucyGctc9bdXr81FpOXA2uriTqNA6wy0BHwhOZOPTp01fZYHzeUcsQTsKwbHCvRhWGOZ3LcMu6cdp3xwdCL7urHITw1oUvuaA+iw8ZOZFq7icUmMqNhB3XOLwYc8YWOPcAeDXYFodF71mEjBy7Mtm5KKZ4GN/ztyY1/sStFr5AxYnqC74kfug1s2zSmA42CZTnj1huzd/5QzhJwMwuLDBUihttYmcLwlKsknV58QfpNQOqb1/cAjrgBKS+5XESfV5zDe+ZN5AxY4n3gIEj+G7Sx3KoHDUzQ3OVTitzuNko33Nry4stZcR5W8YDY2jSjDJwyeJXJOy+1f4mPCzEdbqYEx6Y1F/Qy1OCx8q6KvOGGY9jHOrxq+kayNTPyg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(346002)(136003)(39860400002)(366004)(376002)(451199015)(36756003)(186003)(53546011)(8936002)(26005)(6486002)(6512007)(31686004)(6506007)(2616005)(66946007)(5660300002)(66476007)(66556008)(6916009)(316002)(4326008)(86362001)(31696002)(38100700002)(478600001)(8676002)(41300700001)(83380400001)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ck1mM3JGNHFGS1BCcTVHRDJFMTlIdUhiMGFOdWdwVGI4VXNmbFJuNWh1Ynpq?= =?utf-8?B?WElrZEFhVjl5TERSTjM1YjhMRTBDWVVDM2MwRm9YZ1pZdmRoM3pFMW90aHAx?= =?utf-8?B?WnZBVjJ2RGtnTWRjWVI3UDJpbTRXQzRkKzlaMlYwZmp4TmYyZ3Z4b1lhdW0r?= =?utf-8?B?OU0xNkxucWJ6alRWZzAvZzAyODNqZll6NUlTbytjclB2SnpIRFpnTStjajdJ?= =?utf-8?B?MkFyOFp5TFhNU2V0UkcyZDhHa0xEMXZFZlZ6b21WN2xZQ3piMkRoT1drMlZJ?= =?utf-8?B?YUkyem5aT0RSeTNSK2V4cldwMUQ0QXRJZmZpNjNSb0xTWVlLSkxBY29zdjRW?= =?utf-8?B?MzVqWHhqZGlZUVROcmxCSWF1VUFIanprV1RhdllOMGRteGNtdzVpZHdlR1Fp?= =?utf-8?B?a0c3VGFMbldEWVVBcVRmZXdkK3JMYUhKUlgwSzBGZ1JaWW11cWZtbHNqMHRR?= =?utf-8?B?dU1FU1djbHZteG5RTVk2eWl4aCtDbHZyeG9TUHZOSU45VHh4L01zclVXNjlX?= =?utf-8?B?UTdXZUtEWVNWSTdRcytKTVFkZkN5ellibkNsNmpIcmpDWURpRUV6MXk0WHh5?= =?utf-8?B?QklYSkZVUDJqcGg0a3JGdXQveXVrdjFjLzFLNjNPdkN2c09vTGxMZVRjbzlq?= =?utf-8?B?dnhPVytBK1BkMFlNWWR6SW93SHZ2LzdVRy9rN1VaQ3NkVm5vTG1JbzVacDh5?= =?utf-8?B?aXA2STRFcnh1TUxyUnNGVm9heFhkR1NoZDNRckVIUjBvTEttTWFUUWhxT0Zk?= =?utf-8?B?OFVnektpRmp1MXBhV055QWJCUGpaajVSZTFqVG1ZK1cwZlloaDZ1c3ZZdU40?= =?utf-8?B?Vk5KWGlXaWtYWjVzSSsyWEFrZkJhbmROb3U5ZGJ2VXY2THZrQzRScEFrNVh5?= =?utf-8?B?bGM3ejd4bWU5dlBOdkoyd0NPeFZDRml6cytxMmRvQ2h5Q1pGck9hNXA4eTYy?= =?utf-8?B?TkJqZ2FrOU9HUVBiVnl0M2dNUlF3cHpMMUdOZUE2YnpvM3FCb3VOem10UkU2?= =?utf-8?B?bjZxbHRVeG9VbDhjc1Vkbjh3N0ZacmZTS090djhicVRaQS9nYUhOZlI4a01W?= =?utf-8?B?bnpRL0tJbUw3RitaNDJvZnlWVDNsOXZmbkJNQU8xNHdaWmdsU01wR3RDeFg1?= =?utf-8?B?YWI0L0doQlZCcytTczYzaUxWMy91TFR1bGhxZWpKc3ExSDhRTVFlTzUxYXBI?= =?utf-8?B?dFNoaTF1U01hdTY1cXdTbmlhMFY2QkNpUXVHYS9QNWpBcXRqMWU2R0pLQmR3?= =?utf-8?B?TXlXODRJMzlrZWN3MkJLbG1RYjJLV0EzU3dtbjc5eWh6SWlUWnhLVVBSOWRp?= =?utf-8?B?Q2N0blo3S2lMOTFubGRLOG9vQmVCcFhlbk1yZTU1OU5TUmNPWjRtSWl4K3ZL?= =?utf-8?B?NnpxR0t6dWZubEFiRDVPTmZiM25RU01HcFlnT3BEa0IwNnVyanZGV2Z5WG9p?= =?utf-8?B?aTdTeFR3SXlqV1FBSS90c1VvcUIwU2FDRnV5Um5pT0pGWjhNdU5KeGVPSXRB?= =?utf-8?B?N3dncXhaNHJtSlZUUWVseVE2TmNxUGZndFF4MVNXYzY4OXlDang5QjBuWDBL?= =?utf-8?B?aVhYcGtVek5QdVJCc3o3SzQzS05QQktJbW5oOTl2WWhZR3BNcTVyYlNtcEFC?= =?utf-8?B?SzVOV2F1VEFMZjczbk1SMFplbUZrU1RBZHF5ZDFEUm94bzNxa1ZtS1BBYUlB?= =?utf-8?B?UmprT3BaMFNNeDdGWWJoL2ZoRkgwamliUmtLVTI3anNNT01FMEVjOHJPZFBJ?= =?utf-8?B?Y0VZZzNub1llNE42SGlzbzlPRThPazN0bUpRNmkyeGMwOXpwd0NTbVl0QmZS?= =?utf-8?B?WlQxdXo0QU9rSW9wRVZoZjh2NC9xdi9zdERCZlVlek52QWFnbEVsODIrNUdr?= =?utf-8?B?cHZ1RG5LMnFCbFU0RzlCOTFZa1RtdzNLdklpZjNsZVNxZnAzb1dvdzNOV2hC?= =?utf-8?B?dUw3VGxPekkyUzRHWUV6d2ZWMnYxSk9qZ04xaTZrUVhXdUJJbGJoM3U1NWRD?= =?utf-8?B?cnhCR2pzYWF1VWNYTDZJMEhuU0kzZFRSM0c0TGhSaHcxeUsvc2ZIK3JLM3F4?= =?utf-8?B?cU5YRkl6dEhGdTVGQjlSTmtvb2NKb2FnOE9JU3BqeHE1YVZyWnFncDBBWlMr?= =?utf-8?Q?J+/03QiJSjziJ6pwnGMXGimKC?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 79269f80-4b16-42a7-ac64-08daf3ab4a69 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 08:10:24.2086 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XoPCQRjJItX8gavZ7jYrLdCWE6Lok7yNz+ajzXcu68nklwmdCwFLq2OhhILAyG5aOodfg7PyB6/rjz8ZUZCWzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7564 X-Spam-Status: No, score=-3034.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10.01.2023 21:39, H.J. Lu wrote: > On Tue, Jan 10, 2023 at 1:16 AM Jan Beulich wrote: >> >> On 09.01.2023 22:14, H.J. Lu wrote: >>> On Mon, Jan 9, 2023 at 12:15 AM Jan Beulich wrote: >>>> >>>> On 06.01.2023 18:03, H.J. Lu via Binutils wrote: >>>>> On Thu, Jan 5, 2023 at 1:06 PM Fangrui Song via Binutils >>>>> wrote: >>>>>> >>>>>> _Thread_local int a; >>>>>> int main() { return a; } >>>>>> >>>>>> % gcc -fno-plt -fpic a.c -fuse-ld=bfd -Wa,-mrelax-relocations=no >>>>>> /usr/bin/ld.bfd: /tmp/ccSSBgrg.o: TLS transition from R_X86_64_TLSGD to R_X86_64_GOTTPOFF against `a' at 0xd in section `.text' failed >>>>>> /usr/bin/ld.bfd: failed to set dynamic section sizes: bad value >>>>>> collect2: error: ld returned 1 exit status >>>>>> >>>>>> This commit fixes the issue. >>>>>> >>>>>> PR ld/24784 >>>>>> * bfd/elf64-x86-64.c (elf_x86_64_check_tls_transition): Allow >>>>>> R_X86_64_GOTPCREL. >>>>>> --- >>>>>> bfd/elf64-x86-64.c | 2 +- >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/bfd/elf64-x86-64.c b/bfd/elf64-x86-64.c >>>>>> index 914f82d0151..095fe2e0fe6 100644 >>>>>> --- a/bfd/elf64-x86-64.c >>>>>> +++ b/bfd/elf64-x86-64.c >>>>>> @@ -1241,7 +1241,7 @@ elf_x86_64_check_tls_transition (bfd *abfd, >>>>>> if (largepic) >>>>>> return r_type == R_X86_64_PLTOFF64; >>>>>> else if (indirect_call) >>>>>> - return r_type == R_X86_64_GOTPCRELX; >>>>>> + return (r_type == R_X86_64_GOTPCRELX || r_type == R_X86_64_GOTPCREL); >>>>>> else >>>>>> return (r_type == R_X86_64_PC32 || r_type == R_X86_64_PLT32); >>>>>> } >>>>>> -- >>>>>> 2.39.0.314.g84b9a713c41-goog >>>>>> >>>>> >>>>> Since the new TLS sequence was added after R_X86_64_GOTPCRELX was >>>>> required for call, R_X86_64_GOTPCREL should be invalid in this TLS sequence. >>>> >>>> While this may well be, would you mind pointing out (more to Fangrui than to >>>> me) what bad his proposed change would do? >>> >>> The problem is caused by the combination of -fno-plt and >>> -Wa,-mrelax-relocations=no. >>> -Wa,-mrelax-relocations=no was added to generate object files to be >>> consumed by the >>> older linkers. On the other hand, -fno-plt requires newer linkers. >>> As the result, >>> -fno-plt -Wa,-mrelax-relocations=no generates object files which >>> aren't compatible >>> with neither older linkers nor newer linkers. >>> -Wa,-mrelax-relocations shouldn't be used >>> together with -fno-plt. >> >> Imo use of such option combinations should either be disallowed (warned >> about at the very least) or produce sensible output. I guess only the >> latter would help Fangrui ... >> > > This isn't a supported combination. I believe -Wa,-mrelax-relocations=no > should be removed. But the reason it was introduced (commit 0cb4071ef9e1) hasn't disappeared. Jan