From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2051.outbound.protection.outlook.com [40.107.14.51]) by sourceware.org (Postfix) with ESMTPS id 23CFE3858D1E for ; Mon, 30 Jan 2023 07:51:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 23CFE3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZEc85xYICA7F2UX9With/pjOagRERu6SpJQ/Lk3Wqw23VbQODtTBBup0RU5t7cTKdb5z4+tL9Gfevepz63prueMQfdhtU5AgNNxaYoiE+Vnt1lQryEctVb1XVkKhNl/wdk84YBDLV6yPfxSk5rOV+ITOjK/P5dkqfFOi5AbitKeWaWWNZjZE9ifwINvTiYfsCanj+mwZigBeaAe7NfF1bqr7qjrB2Wvo8QTFNsU2qResSsUJyY6RJm6uOwujpuOXCK+hC5/wLD3otmU7Twv7/6DL9hFtCW7FRw97fr3ZtVkN8899TmpVIk+TLWRA9HVBxWyFpBAzWNXusXjzyPNPkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b63kWQPi5n9xlWgX9y8Fi0k5Hbwgp63ahfEjii5vqFI=; b=g3RMPXOHyG5juzuqxpiDeaebCqHxSHUXI2+q78vZerC101ffZZJ8EXrJ6MyCGpLGy38SHZzde5POsPwt04XKOhTNDAnii6pnycfmoq2W/MP/hmbM19pjO22ctzXJIR89x6sofHxXJSThmQLcGUqYHBZI7/S0dFLbH8DccN8CVYiOX7LrCWE+YVx2TxZgxBYWjFvmSk7vmEhhnVgbIK02QzAKI5/qdiZenSBjH0yQtzt8W6eEQ2BidxxW0JAlQzpdTrkKtch+kvwU/Q5x6vq874sr5YeDwlqzsBoBI/P+RAdgQzmbJqrqZK5Xo1wWt6Q6IdXl93fExJSgNDrD2gVJlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b63kWQPi5n9xlWgX9y8Fi0k5Hbwgp63ahfEjii5vqFI=; b=NCx9w/Ym6abe3KPMHPElo/crIj71ofbVB/FfJEcolRw1wJSv+hf1qwIXiLOriWpcWVqcUdGdlisWV45j9mg5TRd1c7kOCT0p+YguzPhtjIXLdkvNRC3Bjx7osn/4QI8Vn0SF0lMaT2+G5rhELi72LQbmus3bODdBiEfqjFEn8gAvfdaxp2oWMkaL6uPBwNe5tzmewT7tDiflrPm69S0ywas8YaGYDtOfK5R3OLcFJvX4UOqcudI4XFohiAtl5vyLf17809ND6LDjMy6g8+lAh5Yl/V8L9uwFMQGGb9IjrX+Kyj43jkkM9shZQpiqLvEgYgnZmZHA3dWQxSEDTw0lxw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8333.eurprd04.prod.outlook.com (2603:10a6:102:1c0::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36; Mon, 30 Jan 2023 07:51:07 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6043.036; Mon, 30 Jan 2023 07:51:07 +0000 Message-ID: <4fd5ad07-919e-1502-8688-9ade69af2a64@suse.com> Date: Mon, 30 Jan 2023 08:51:08 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] RISC-V: don't disassemble unrecognized insns as .byte Content-Language: en-US To: Nelson Chu Cc: Binutils , Palmer Dabbelt , Andrew Waterman , Jim Wilson , Kito Cheng References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0122.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8333:EE_ X-MS-Office365-Filtering-Correlation-Id: b25f5a58-3900-4684-aafb-08db0296bebc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vt7IiXKqLSqpnkumWdGhREiT5YLnWAdKAFuZ72ShjOr2zIYJ4nQLpZ01OmBBmkAarWmR0YllqqvjlKurPjFt6bphShmwvpUz4iqoWGu/OPTDvkx9EvG5vHW3aRtlU/X+GJ+mSbNkl2eA5hx56/0mMRNZZDBUdyG+rHk9y/fKX2+TQCFPDfMrI0ZzG3M88rHX5KnYkGbtXUjeVLSTiw3HDteynCXqF+o4EKY/F5BUlUzKK5MXgxLq5Sg2G+sNxw683a7Htb6n2Ng3MQhv+JSrF+ldmlRr9T8eOSjUFcSEZPq1I77tcWh2r1iIVqfA/sVJFwuxKa4GgpqGQ+6CUXx3qCaseLa+alBfiu1odK47Ch+YEgDS2uG3wW9DxDo2zMQN/GWzfDf75IHxqJWYt0BETxCO/bYwRWE2w+8CkMrNLlT6KLi9yKnulKBnyRejudH3mLcrLwgm1PtkXLPi8hoILJyf+GTkvIk1/LRjhCvsclwUEb6aI5AaJUticN91QHmb8zEk++xtvL7qL97383lWn7t1nths8/8xOXo2mTlV6nIyai3pZmt84VyTgkkcP/YA0njmooGbZ09tq++mvT7VVHl4v+VoqySHPd5l091kevzo/w5BSgnLb5adVADUpL6W3DefQEJ1idXLsKHKRMP0o80U4LgEt5zN4bBd2TX9FfwMMUMsvb7tJ5PChrvx/gWj9M490v3sB+tx2wKcbZYpbOTo3KbK1TNk2ZU8J8lboaurNq6TNdUBqo8ldNKI4aSH X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(396003)(136003)(366004)(39860400002)(376002)(451199018)(4326008)(31686004)(41300700001)(8676002)(66556008)(66476007)(6916009)(66946007)(8936002)(316002)(6486002)(54906003)(5660300002)(83380400001)(36756003)(2906002)(6512007)(26005)(186003)(478600001)(53546011)(6506007)(86362001)(31696002)(2616005)(38100700002)(142923001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eTVJU1E0dUNnZkZTSDF3SnlTQTIxZExRMXBSbGFyZFhFRzZubVVPVENCR3dr?= =?utf-8?B?N0R1K2hIQU5zRVpmemtuQ25mZE5hVWVPZDRaalE4aURlbkxpQkdhNXpZckZQ?= =?utf-8?B?eXZUb3N5MG5PZ2krMThmYVdEZlJlcUd5akwyM2FWZmRNVnJqdk9RV0U1aENJ?= =?utf-8?B?aDVZd1pES3lkOGVNVCtpZGVyTHZlWmcxd0c1NGdCZXJBa1JvRUNVdExMRDFy?= =?utf-8?B?N3JPMjZyaGxUODVPSFo4TW5ndjBpZk80MldjejY2dWRFcnI4aEdmY1o4WXV5?= =?utf-8?B?L0Vsb3lvejR2K1FNRXgrcFgyaTFycVBaOC9UZWJWaE5LMWlVRjRKWTBuTTBw?= =?utf-8?B?WjF5amZ3NWt4MEo2dnc2cVptQUNGSk1ick5WeUFZanVtVnBzVm5sZWwzMEZ6?= =?utf-8?B?WlBjcHpRUzVtVUFKMkZ3akZCczdycHVBR3Rnc1dSbVZ3RnJGM21YMHZoS096?= =?utf-8?B?NG52N0M3Y2JsUkMxYUVEcFFMRVpEdWZwZlJnU0dEaDNlUVRMZlplQ0h3cy91?= =?utf-8?B?MUErWkJGZzNhenhsbUhUOFFJb0UyMGV5Zk8za0V2TlU1LzlzQmN3YXp5UE1r?= =?utf-8?B?dVIrU1d2MXRLdnZCc1NzczJQWFVhR25EUmpzdE1kUldTWWx0R1NIVHNQcWlQ?= =?utf-8?B?c2sySnViMmFmbW80RHhSQ3Jqb2NzOFBBcG51V2ZWNmFLZ0pCMTFsTGpWODRl?= =?utf-8?B?RHA2N0JZc3B0aUNoVmJwWEdtSmZhekVENG1IQ2c5d1pIakZXdGJrTHA0aUIr?= =?utf-8?B?RW8wQ1ZoZ3dlN1JhTlJaZnhzb1dnSDEvZGNNRStzNFFNU1hnOEdwaFRCdkxY?= =?utf-8?B?N1pHejhRa0lhQTVBRlpRSnExMXhwYyttYWZrM0RGYXJjcmkrQVpnbG13SWVE?= =?utf-8?B?NElVcTlvcWVsM0UwU0xaR0xnVjVuU2V5cWU2RVZlM3liTzJyeUt1UmUvMEh4?= =?utf-8?B?bWRLVHBNRzlWejBKQlVnQU9DQnN3YTRPdE5PK09McThoVDArQk9WeUtHRmpJ?= =?utf-8?B?Y1NZR1JGTGdXcTVNNUpoeSs2eStDd3JRbVJoSFBYdStDWm51TGZJbUxFOVZK?= =?utf-8?B?RzJtRksrd1FCK0dYSFVwdXJKQ0Q3QlVMRDFnV3F4MnZiSHRPWUtxeWdCWUVn?= =?utf-8?B?TDZzODdFUjhLN0ZhUDZIVDJwY1MvL1NCNTlLdWFHT1dZNnYxYVlXT2ZlWjBZ?= =?utf-8?B?Q1ZPcStlR3hDQXhuU2hoY2YzMXdYQ3pBWmFOYVpQZDR6NnJyT0o4dFVEa2Zp?= =?utf-8?B?djRGZHBKN0JRV2x1MlZadmRCcmFmRytRSWNxUHE0TjdNY2JldlQydThuejJl?= =?utf-8?B?ZjFUTURnRExVSG42eEtCazFsTzg0YXRPbFBDQjFOSjNFOVR2N3AvNVRVMEZY?= =?utf-8?B?aGNDOUFaUHAySCt5bytuR01UT05Ma2RGdVRKeWN4ZDBpaFdFbitBOXo4bU1q?= =?utf-8?B?em4yMlJ2a2pURE1Sak81RWhIYUtneEx0Vkw5V2cwRGMxeHpPZzBGWlVZbHBN?= =?utf-8?B?Wi93UzFHR1pTcVdFSHhSVXFhN2tVaDNoZmcvbjdiaitIeEd3SEFEOWFUbmdU?= =?utf-8?B?a2lKb1FlT3FhRTNvTWhmSmJNcitNV2tHeXdyVVF4d3hFL0lJbGE2eitrSGdv?= =?utf-8?B?d3NaMFpna2crc3lLT2JyT1gyaVU5Nmo3c3NSai9YV21wV1NqaWdBS0FFLzF6?= =?utf-8?B?eWlLdkYxRkUxRWF6RXVGeVFmWm9qcUNXU3FaUE02VVNEd1ZmS1kxOWZLaytp?= =?utf-8?B?NmZlb3pHSUNkaERxWW9lamVTT1J1M1N0a1BPUFkvUUJXZUI1Z2ExOFU3L2VU?= =?utf-8?B?dTRWMmcza2N0dDcrZ1p5OGV6NmxOTVlZQnhqVHB6ZFJzOUszMTFTZXZraTNt?= =?utf-8?B?OXBCVHpiVldmdSt4V1JPbWw3N0tqMXNHcDI3VEhRNW1WQWZHTGI4dEY4dERG?= =?utf-8?B?V3lTaEtEbDhPWkdkejljK0F2VWQ0cktCRFNFazVLUTcyRDdqVlpNVkovTms1?= =?utf-8?B?a3RKZlBUR0dXZnlUM00vY01NMStVRW1DaTR3VnV3ZjYra3FIUWg2aTZhSjlF?= =?utf-8?B?cUNnbzhYeUpMMUtUZVozb1drU1JEY2JWdmNOR0tsZVZkVFAxSXJEQW5zcUZG?= =?utf-8?Q?R2wddh5OFuQOD4J3ASHBj3aM2?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b25f5a58-3900-4684-aafb-08db0296bebc X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2023 07:51:07.3005 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: auCG4U9fuTzlhYBxq6GWF2Q4m/QW0t70v9h3l+ssj9FWFr6kqmR/ZoMqJWdla6ZToRtdmSMRYT8QLQHtpnIpAg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8333 X-Spam-Status: No, score=-3028.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 30.01.2023 02:40, Nelson Chu wrote: > On Fri, Jan 27, 2023 at 9:14 PM Jan Beulich wrote: >> >> Insn width granularity being 16 bits, produce 16 bits of data per output >> element for the non-special-cased insn widths. Besides being slightly >> more natural (in particular having the first element carry everything >> that's needed for determining insn length), this is also slightly more >> compact. > > Sounds reasonable and good, so please commit, thanks. Given ... >> --- >> I think output would be even more neat if .byte were suppressed when >> generic code already prints the raw insn (or maybe something like >> was printed instead). >> >> As to the special case code for 2-, 4-, and 8-byte insns: Any thoughts >> towards zero-padding the numbers there as well? That would make yet more >> noticable what the insn width is; in particular - see e.g. ".8byte 0x3f" >> in full disassembly of the testcases modified here - it would avoid the >> value looking like it was for a more narrow one. >> >> Taking it yet one step further - how about printing unknown insns as >> ".insn ...", matching what gas would consume? > > I don't remember how long ago, Kito did discuss this idea with me, but > since we haven't supported mapping symbols at that time, it's been > forgotten until this patch. Anyway, I vote to dump the unrecognized > instructions into .insn directives, so if there is no objection, > please go ahead. > > Also cc Kito, he should have almost forgotten about this :-) both of you think this is a good direction to follow, I won't even bother committing the patch here, but make one to switch to emitting .insn right away. With some luck later this week ... Jan