From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10716 invoked by alias); 24 Jul 2012 15:30:45 -0000 Received: (qmail 10706 invoked by uid 22791); 24 Jul 2012 15:30:44 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from nat28.tlf.novell.com (HELO nat28.tlf.novell.com) (130.57.49.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Jul 2012 15:30:31 +0000 Received: from EMEA1-MTA by nat28.tlf.novell.com with Novell_GroupWise; Tue, 24 Jul 2012 16:30:30 +0100 Message-Id: <500EDBB502000078000903BB@nat28.tlf.novell.com> Date: Tue, 24 Jul 2012 15:30:00 -0000 From: "Jan Beulich" To: Subject: [PATCH] x86: adjust diagnostic for bad 4-bit immediates Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=__Part0C3D5F85.0__=" Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00178.txt.bz2 This is a MIME message. If you are reading this text, you may want to consider changing to a mail reader or gateway that understands how to properly handle MIME multipart messages. --=__Part0C3D5F85.0__= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Content-length: 747 The current error message for bad imm4 operands wasn't really helpful, and was pointing at the wrong operand in Intel mode. Since non-constant operands are being taken care of by other means anyway, adjust it to simply state that the constant doesn't fit. 2012-07-24 Jan Beulich * config/tc-i386-intel.c (match_template): Adjust error message for 'bad_imm4' case. --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -4347,7 +4347,7 @@ check_reverse: err_msg =3D _("invalid instruction suffix"); break; case bad_imm4: - err_msg =3D _("Imm4 isn't the first operand"); + err_msg =3D _("Constant doesn't fit in 4 bits"); break; case old_gcc_only: err_msg =3D _("only supported with old gcc"); --=__Part0C3D5F85.0__= Content-Type: text/plain; name="binutils-mainline-x86-bad-imm4.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="binutils-mainline-x86-bad-imm4.patch" Content-length: 744 The current error message for bad imm4 operands wasn't really helpful, and was pointing at the wrong operand in Intel mode. Since non-constant operands are being taken care of by other means anyway, adjust it to simply state that the constant doesn't fit. 2012-07-24 Jan Beulich * config/tc-i386-intel.c (match_template): Adjust error message for 'bad_imm4' case. --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -4347,7 +4347,7 @@ check_reverse: err_msg =3D _("invalid instruction suffix"); break; case bad_imm4: - err_msg =3D _("Imm4 isn't the first operand"); + err_msg =3D _("Constant doesn't fit in 4 bits"); break; case old_gcc_only: err_msg =3D _("only supported with old gcc"); --=__Part0C3D5F85.0__=--