* [PATCH] m68hc11: Fix cygwin build fail.
@ 2012-07-27 12:59 James Murray
2012-07-27 14:17 ` Sean Keys
0 siblings, 1 reply; 6+ messages in thread
From: James Murray @ 2012-07-27 12:59 UTC (permalink / raw)
To: binutils
Building for target m68hc11 fails on cygwin (1.7.16-1) due to a binary
number. Changing it to hex allows build and testsuite passes.
Please could someone review and apply.
gas/ChangeLog:
2012-07-27 James Murray <jsm@jsm-net.demon.co.uk>
* config/tc-m68hc11.c: Replace binary with hex for cygwin.
--- src-old/gas/config/tc-m68hc11.c 2012-07-27 13:32:48.000000000 +0100
+++ src/gas/config/tc-m68hc11.c 2012-07-27 13:33:41.000000000 +0100
@@ -2221,7 +2221,7 @@
/* Must treat as a 16bit relocate as size of final result is
unknown. */
byte <<= 3;
- byte |= 0b11100010;
+ byte |= 0xe2;
number_to_chars_bigendian (f, byte, 1);
fix_new (frag_now, f - frag_now->fr_literal, 2,
sym, off, 0, BFD_RELOC_M68HC12_16B);
regards
James Murray
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] m68hc11: Fix cygwin build fail.
2012-07-27 12:59 [PATCH] m68hc11: Fix cygwin build fail James Murray
@ 2012-07-27 14:17 ` Sean Keys
2012-07-30 12:25 ` James Murray
0 siblings, 1 reply; 6+ messages in thread
From: Sean Keys @ 2012-07-27 14:17 UTC (permalink / raw)
To: James Murray; +Cc: binutils
Hi James,
Thanks for the patch. I checked it and applied it.
Thanks,
Sean
On 07/27/2012 05:58 AM, James Murray wrote:
> Building for target m68hc11 fails on cygwin (1.7.16-1) due to a binary
> number. Changing it to hex allows build and testsuite passes.
>
> Please could someone review and apply.
>
> gas/ChangeLog:
> 2012-07-27 James Murray <jsm@jsm-net.demon.co.uk>
>
> * config/tc-m68hc11.c: Replace binary with hex for cygwin.
>
>
> --- src-old/gas/config/tc-m68hc11.c 2012-07-27 13:32:48.000000000 +0100
> +++ src/gas/config/tc-m68hc11.c 2012-07-27 13:33:41.000000000 +0100
> @@ -2221,7 +2221,7 @@
> /* Must treat as a 16bit relocate as size of final result is
> unknown. */
>
> byte <<= 3;
> - byte |= 0b11100010;
> + byte |= 0xe2;
> number_to_chars_bigendian (f, byte, 1);
> fix_new (frag_now, f - frag_now->fr_literal, 2,
> sym, off, 0, BFD_RELOC_M68HC12_16B);
>
> regards
>
> James Murray
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] m68hc11: Fix cygwin build fail.
2012-07-27 14:17 ` Sean Keys
@ 2012-07-30 12:25 ` James Murray
2012-07-30 16:11 ` nick clifton
2012-07-30 16:13 ` nick clifton
0 siblings, 2 replies; 6+ messages in thread
From: James Murray @ 2012-07-30 12:25 UTC (permalink / raw)
To: binutils; +Cc: Sean Keys
On Fri, 2012-07-27 at 07:17 -0700, Sean Keys wrote:
> Hi James,
>
> Thanks for the patch. I checked it and applied it.
>
Please could this be applied to the 2.23 branch also.
regards
James
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] m68hc11: Fix cygwin build fail.
2012-07-30 12:25 ` James Murray
@ 2012-07-30 16:11 ` nick clifton
2012-07-30 16:13 ` nick clifton
1 sibling, 0 replies; 6+ messages in thread
From: nick clifton @ 2012-07-30 16:11 UTC (permalink / raw)
To: James Murray; +Cc: binutils, Sean Keys
Hi James,
> Please could this be applied to the 2.23 branch also.
Done.
Cheers
Nick
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] m68hc11: Fix cygwin build fail.
2012-07-30 12:25 ` James Murray
2012-07-30 16:11 ` nick clifton
@ 2012-07-30 16:13 ` nick clifton
2012-07-30 17:38 ` Sean Keys
1 sibling, 1 reply; 6+ messages in thread
From: nick clifton @ 2012-07-30 16:13 UTC (permalink / raw)
To: Sean Keys; +Cc: James Murray, binutils
Hi Sean,
>> Thanks for the patch. I checked it and applied it.
Just a quick note - when you checked the patch in to the mainline
sources, it appears that you did not update the ChangeLog in the gas
directory... Please could you fix this.
Cheers
Nick
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] m68hc11: Fix cygwin build fail.
2012-07-30 16:13 ` nick clifton
@ 2012-07-30 17:38 ` Sean Keys
0 siblings, 0 replies; 6+ messages in thread
From: Sean Keys @ 2012-07-30 17:38 UTC (permalink / raw)
To: nick clifton; +Cc: binutils
Hi Nick,
Understood, and fixed!
Thanks,
Sean
On 07/30/2012 08:07 AM, nick clifton wrote:
> Hi Sean,
>
>>> Thanks for the patch. I checked it and applied it.
>
> Just a quick note - when you checked the patch in to the mainline
> sources, it appears that you did not update the ChangeLog in the gas
> directory... Please could you fix this.
>
> Cheers
> Nick
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-07-30 17:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-27 12:59 [PATCH] m68hc11: Fix cygwin build fail James Murray
2012-07-27 14:17 ` Sean Keys
2012-07-30 12:25 ` James Murray
2012-07-30 16:11 ` nick clifton
2012-07-30 16:13 ` nick clifton
2012-07-30 17:38 ` Sean Keys
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).