From: "Jan Beulich" <JBeulich@suse.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: <binutils@sourceware.org>
Subject: Re: [PATCH] gas/x86-64: properly distinguish low and high register ranges
Date: Tue, 31 Jul 2012 06:24:00 -0000 [thread overview]
Message-ID: <5017965C020000780009170B@nat28.tlf.novell.com> (raw)
In-Reply-To: <CAMe9rOpkWhd8idXjWVQSYTQu6xQyZHfG7SkN54m28xasgp8YeA@mail.gmail.com>
>>> On 30.07.12 at 18:04, "H.J. Lu" <hjl.tools@gmail.com> wrote:
> On Tue, Jul 24, 2012 at 11:56 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>> On 24.07.12 at 16:16, "H.J. Lu" <hjl.tools@gmail.com> wrote:
>>> Can you add some testcases?
>>
>> I knew you would ask this, but sorry, this makes no sense - if test
>> cases would are desirable here, they shouldn't be testing just the
>> things that this patch fixes, but also any other invalid operand
>> combinations. As an example - why would testing that "xlat [r11]"
>> isn't accepted be needed, but not e.g. "xlat [ecx]"?
>>
>> Furthermore, this fixes actually broken behavior, so accepting
>> the change shouldn't be dependent upon test case availability.
>
> What broken behavior does this change fix?
I gave an example above - xlat [r11]. Other similar examples
involve other string instructions requiring fixed registers as
well as the one or two instructions requiring xmm0/ymm0 as
their first/last operand.
> Why hasn't it been tested in the testsuite?
Don't know.
Jan
next prev parent reply other threads:[~2012-07-31 6:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 14:14 Jan Beulich
[not found] ` <CAMe9rOrY+ECKpfYM23heJB4Ma1BT9aFd2+-z1oVdhq3EiXwdRQ@mail.gmail.com>
2012-07-25 6:56 ` Jan Beulich
2012-07-30 16:05 ` H.J. Lu
2012-07-31 6:24 ` Jan Beulich [this message]
2012-07-31 15:49 ` H.J. Lu
2012-07-31 16:28 ` Jan Beulich
2012-07-31 18:45 ` H.J. Lu
2012-08-07 10:29 ` [PATCH, v2] " Jan Beulich
2012-08-07 14:02 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5017965C020000780009170B@nat28.tlf.novell.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).