From: "WANG.Jiong" <wong.kwongyuan@gmail.com>
To: davem@davemloft.net, iant@google.com
Cc: binutils@sourceware.org
Subject: [GOLD] question about gold handling SPARC style .rela.plt, .rela.plt overlapping
Date: Tue, 07 Aug 2012 10:25:00 -0000 [thread overview]
Message-ID: <5020D0CA.9010306@gmail.com> (raw)
Hi David & Ian,
currently, I am porting gold linker for a private target which allow
PLTREL overlapping
so, I met exactly the same problem as you have discussed two years ago
http://sourceware.org/ml/binutils/2010-02/msg00140.html
I see you have done a fix with the following logic:
1. .rela.dyn, .rela.plt are seperate
2. generate DT_RELA only when there is .rela.dyn, and DT_RELASZ be
the total size of both .rela.dyn and .rela.plt
But, If there is no .rela.dyn, without DT_RELA, it seems dynamic
linker behave incorrectly when ELF_MACHINE_PLTREL_OVERLAP defined
I checked the implementation of _ELF_DYNAMIC_DO_RELOC in glib
elf/dynamic-link.h:260
# define _ELF_DYNAMIC_DO_RELOC(RELOC, reloc, map, do_lazy,
skip_ifunc, test_rel)
without DT_REL or DT_RELA, ranges[0] are not initialized properly.
So, should we always generate DT_RELA, DT_RELASZ, DT_RELAENT, and
make DT_RELA, DT_RELASZ exactly the same value as DT_JMPREL, DT_PLTRELSZ ?
that is, for the following condition check in
Layout::add_target_dynamic_tags
4344 if (dyn_rel != NULL && dyn_rel->output_section() != NULL)
4345 {
4346 odyn->add_section_address(use_rel ? elfcpp::DT_REL :
elfcpp::DT_RELA,
4347 dyn_rel->output_section());
4348 if (plt_rel != NULL
4349 && plt_rel->output_section() != NULL
4350 && dynrel_includes_plt)
should we check dynrel_includes_plt even when dyn_rel == NULL ?
or I have misunderstood something ?
thanks very much
---
Regards,
WANG.Jiong
next reply other threads:[~2012-08-07 8:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 10:25 WANG.Jiong [this message]
2012-08-07 13:34 ` Ian Lance Taylor
2012-08-07 14:19 ` Jiong WANG
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5020D0CA.9010306@gmail.com \
--to=wong.kwongyuan@gmail.com \
--cc=binutils@sourceware.org \
--cc=davem@davemloft.net \
--cc=iant@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).