From: nick clifton <nickc@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Binutils Development <binutils@sourceware.org>
Subject: Re: [PATCH 1/5] fix the archive hash table memory leak
Date: Tue, 07 Aug 2012 13:46:00 -0000 [thread overview]
Message-ID: <50211AC9.1000509@redhat.com> (raw)
In-Reply-To: <873944own2.fsf@fleche.redhat.com>
Hi Tom,
> * archive.c (_bfd_delete_archive_data): New function.
> * libbfd-in.h (_bfd_delete_archive_data): Declare.
> * libbfd.h: Rebuild.
> * opncls.c (_bfd_delete_bfd): Call _bfd_delete_archive_data
Approved and applied.
Note - there was a small problem with the patch:
_bfd_delete_archive_data was being called on bfds which were not
archives (and hence bfd_ardata() returned a pointer to a structure that
was not a struct artdata). I fixed this by adding a test of the format
in _bfd_delete_bfd before calling _bfd_delete_archive_data.
Cheers
Nick
prev parent reply other threads:[~2012-08-07 13:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 14:54 Tom Tromey
2012-08-07 13:46 ` nick clifton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50211AC9.1000509@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).