From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 0EB313858C78 for ; Tue, 12 Dec 2023 08:28:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0EB313858C78 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0EB313858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::431 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702369726; cv=none; b=u7PU3GMJ3Z3c1BxikYiLYBLuKBPiUxHWp7PO+Iy2ASvwab6Htt4TIiJz2y3sWrXi2yJLyG1KQvNh3ZhgzeQoy5QAkT5gy7WmniBZqNfsyu1Hw7TTXJ//L0CMuyCcFscKcn0PkJvzAyJDV2I76O8Ney3cqJF2yuvuOD90tNbPOZQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702369726; c=relaxed/simple; bh=IOTIWmdR/VYNZ6jsDYstEQGjnTgHW9DZKVVebWUISXo=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=NqTQ10HWRtLparx6mskMR0S5k/untKDIVuZUmnhhOlq1k5hFwEcZf4nToh3pDTTRMmci9P7dYZzFFwODLfJUQMb7+L5DV/QDCHKLaHs4c+FfJY8eMlNn7HCeEpoxB7KmuIvecex2FcwGFH/Xi5nTESBMVq9q/gjhnSfnWjbO8XU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-3333224c7b9so4761833f8f.1 for ; Tue, 12 Dec 2023 00:28:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1702369724; x=1702974524; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jUlA244gT56rGkUKovmsj+G8fOEDykpOMiNeFIToPAs=; b=R71qNw3gs8Q2B+QNNi7PTvjttcRXBu3votWRWBh1CMiPca8+zwj6xFLTqGksz4d47T xrbRmSfE7TfXZ5vR+95lkE1rBDbi3nhukQ4/pYvJ4acTbp31WC7dfk3K1agPh7FO8fi3 M+OtVp3E9WCjqDgGYw6CqBXzPEo5vZbejEMtSqYt6fvMM8m0V6mqJD6wBLBitdX2pRpQ BHRRezVbAMM5U8CxKZ7cquzDDTlICn67uN3VuBSmw0juUhw9pZyo1bXZT9DVXs+cPgaC UUUzzHbs1CDrqWhlSLnwc0fHuexJj0PEJUuXkkl9ADfh0c0zTiMbRTMujmqQgpIdeAmB UXDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702369724; x=1702974524; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jUlA244gT56rGkUKovmsj+G8fOEDykpOMiNeFIToPAs=; b=DQoE80IhyuM754PR3HNXW8AAEj12WlTbXRV63jjUQkHDks3WYwKPwPw8r0RakXkKWP pMiAzoiUgfoueVW58vVOSq4PlvfmuBbRReMyi3NPVgVl58Y8vdCuzXeoPyPmXjCVucxf /tm+FUTXDiHSDmUHHd0jn5slVfHUeAUY5WLcfNDXOeSZ84RUxeM2l/nPLm08wCCtmbW8 6QeP6z5ahJz/OAmv1Cs8RYVClTZxWo5+lNWwofHFTtXrUsY5lAAGSOR/nVNzcx2MGrKm LL1dQjzAalfof/FOhqnsZANVvRDExJMw1YOksvxdhs99oKeURQvA6I8yNTYVUIiD0zqt RtPQ== X-Gm-Message-State: AOJu0YyszLSwQKeonO7S/oZyonZpIRqjngHFSJckKrprXLUr5+qNQVjS eOPKVGJ22I5dNO9jevep3yoK X-Google-Smtp-Source: AGHT+IHKoOY3ActzNojc/jfaqVn8rNCgTcXSZ6G4eTvzv/Ax8ghR62tHChiY3DUt6jX1T8rsQanJdQ== X-Received: by 2002:adf:f702:0:b0:332:ef1e:bb8b with SMTP id r2-20020adff702000000b00332ef1ebb8bmr2550679wrp.7.1702369724086; Tue, 12 Dec 2023 00:28:44 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id l11-20020a056000022b00b0033341165b0csm10239143wrz.36.2023.12.12.00.28.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Dec 2023 00:28:43 -0800 (PST) Message-ID: <50331da2-fd65-4085-8f08-30f0b7bc16a9@suse.com> Date: Tue, 12 Dec 2023 09:28:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 6/9] Support APX NDD Content-Language: en-US To: "Cui, Lili" Cc: "Lu, Hongjiu" , "Kong, Lingling" , "binutils@sourceware.org" References: <20231124070213.3886483-1-lili.cui@intel.com> <20231124070213.3886483-6-lili.cui@intel.com> <11ab8db7-fd9f-4d3a-b321-98c654fff9d9@suse.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3026.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12.12.2023 06:53, Cui, Lili wrote: >> On 24.11.2023 08:02, Cui, Lili wrote: >>> --- a/opcodes/i386-dis-evex-reg.h >>> +++ b/opcodes/i386-dis-evex-reg.h >>> @@ -56,3 +56,58 @@ >>> { "blsmskS", { VexGdq, Edq }, 0 }, >>> { "blsiS", { VexGdq, Edq }, 0 }, >>> }, >>> + /* REG_EVEX_MAP4_80 */ >>> + { >>> + { "addA", { VexGb, Eb, Ib }, NO_PREFIX }, >>> + { "orA", { VexGb, Eb, Ib }, NO_PREFIX }, >>> + { "adcA", { VexGb, Eb, Ib }, NO_PREFIX }, >>> + { "sbbA", { VexGb, Eb, Ib }, NO_PREFIX }, >>> + { "andA", { VexGb, Eb, Ib }, NO_PREFIX }, >>> + { "subA", { VexGb, Eb, Ib }, NO_PREFIX }, >>> + { "xorA", { VexGb, Eb, Ib }, NO_PREFIX }, >> >> Don't these need to use PREFIX_NP_OR_DATA? The doc clearly says >> ".IGNORED" there. (Applies to other byte ops as well then, of course.) >> > > I'm confused here, "IGNORED" means the W bit in the EVEX payload is ignored. Why is 0x66 allowed? Hmm, looks like I have been confused. Earlier communication had led me to the impression that pp == 0b01 would be ignored here. In fact I had my own disassembler library the other way originally, and I then changed it to this model. Looks like I need to change it back. And I'm sorry for causing confusion here. Jan