From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50054.outbound.protection.outlook.com [40.107.5.54]) by sourceware.org (Postfix) with ESMTPS id 42F973858D32 for ; Mon, 15 Aug 2022 10:01:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 42F973858D32 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=dbdwVICw47vDDR+5Aa+1ZLQ+00wO0jxcgND+nVzkqy7PLu+HyLkzrQt3GU35UMGL3WODNuyQOzQGFRuosgjJz+gcot8TNOIgwvETxdB+G6U/3m8jIrzeC4IiZCBwgbQFkTWVQeiHfu89entNdwm5vkURvjJNQLe00tIC+g02DkJBrVC0EYlKBp6TUWYc9Mb2AucRdSgju69H9mrdNBGS4pWlttELjh7s4c2mEdLrpRM/KwG3fp82lEm7ZCFWAaVGL3gWUtsA+xFltBe8qQK69pUg7tQe0lTYqEPsfdfpEc5NGHGe4e6m0uYU9OS0fqhi8zvkNYoWSqt5x+HmoRgNXQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qT9HsuXvrsZ0Hr2hl3A42f3sLE6ABQlVx1m+HL5mHas=; b=nEkiVagtsWzIpRzc8lqyUEwz+YKBDJu9Q/e4FecJafhGa/Ha+gxmrjlzM+Sq/R8T7G/DcCf2BzQNZlOtaWOJRCFtx18h4FmnzGMh81jDCqN59r/nvTaG43zRI4OzaU6s4KmV6FMsrTBVyHu/LDrQ0XBo72Hnc4i+gMA22aiP+FfIsV27Er1rekSlduMpmrE3e+lt2aeZgsw/uNArWnScLrgnVXusUcYLEXUdwOG5QRt+9+ICQAhRBxF05O70oKSWViKMRM+5kpp+dEcP4Xy21j1Gdc9MJvuWBOPXBElqQBTPk2sdLo9Lu2dqEdNND62l2WUsACMCkP/kbSWKI8GL3w== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from DB6PR0202CA0021.eurprd02.prod.outlook.com (2603:10a6:4:29::31) by AM0PR08MB3570.eurprd08.prod.outlook.com (2603:10a6:208:e0::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.17; Mon, 15 Aug 2022 10:01:26 +0000 Received: from DBAEUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:29:cafe::f4) by DB6PR0202CA0021.outlook.office365.com (2603:10a6:4:29::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.19 via Frontend Transport; Mon, 15 Aug 2022 10:01:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT044.mail.protection.outlook.com (100.127.142.189) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.11 via Frontend Transport; Mon, 15 Aug 2022 10:01:25 +0000 Received: ("Tessian outbound c883b5ba7b70:v123"); Mon, 15 Aug 2022 10:01:25 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: c12aebae2b7e5973 X-CR-MTA-TID: 64aa7808 Received: from 8d973c8fe452.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AA024A50-06AE-4590-8CFA-EE6907D9241C.1; Mon, 15 Aug 2022 10:01:19 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8d973c8fe452.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 15 Aug 2022 10:01:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e0WY1x8NfxY7eyj5iWp84QBTnWQcODYfdnTq3rl8l9aPUKxlYWPyWw5mc4n9vRN4grKgC++TiKeiPIdBA+pk/L4sFAQ+7R0rXmchQuxBB3QcR+GeFkVGjojqxWIv/mpposWpTG1B5UW9SiJeJ4OgjiFilQzP9DxDwMpxk4/Ej5wZKBB/OIj0y/w/w30df2pF2KVl7UDVdmsWah6uRQdIbTiQ+ZRHUmHRn31cmxw2fKkHf87v5mLmv3kp6BzmPs5vd99WyDX5gmoocbhTGRtyVTTAPSQDLxtMEzVCc9dE5+THBXW9D0rTytYtGicjrfem2ztvSfFDBVE3a73a9r+AjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qT9HsuXvrsZ0Hr2hl3A42f3sLE6ABQlVx1m+HL5mHas=; b=T0FYfUkRppshCKBb6ATWOTMdF1QhtX/x8lI9zlvxHGFd8fzNzchmbScyNlzUSuJ232cGWg+S5biS53ItrzhL6Dgzmk8S/ffkLL5IW7sV2HLIPyQmQeqD8aTA7clA2LmZtQahu/b5e7aD49PiN5grzRE3X4OrfxXSozirkzGTN344eUZSBYWJbO1l9/aFrrg8JIh+Z6bjcRY1WNtvRG0yFUO/W0kcqmp08tPl1MgnTArK+EF5cF9glMvEBK2odw8lgAps+IIPwyIfDt16HojO7LnQYby/ZPQJEjknp9E/N2gfkApPbqIZEEbn0xDwmddkbyfEBK98dMsYhVVtwpDtgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AM0PR08MB3777.eurprd08.prod.outlook.com (2603:10a6:208:102::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.17; Mon, 15 Aug 2022 10:01:08 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::cc64:9170:b12d:de8]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::cc64:9170:b12d:de8%4]) with mapi id 15.20.5504.028; Mon, 15 Aug 2022 10:01:08 +0000 Message-ID: <503a5a7b-4e94-105f-5242-5364b6d49701@arm.com> Date: Mon, 15 Aug 2022 11:01:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] bfd: Define func prototype for old mingw Content-Language: en-US To: =?UTF-8?Q?Torbj=c3=b6rn_SVENSSON?= , binutils@sourceware.org References: <20220815084902.3630298-1-torbjorn.svensson@foss.st.com> From: Luis Machado In-Reply-To: <20220815084902.3630298-1-torbjorn.svensson@foss.st.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0160.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::21) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 46fa15c9-9818-4b3b-67f5-08da7ea51da3 X-MS-TrafficTypeDiagnostic: AM0PR08MB3777:EE_|DBAEUR03FT044:EE_|AM0PR08MB3570:EE_ X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ccuQBJvzky+/fY7ahi4wZ23iYl4pAJjU5oeBvxTfx+hpPlt5pTPxkOVnax7yv9mbPwjMWTGbWmku7XbTW8dzXX2eSrU1khAnOBuX7P6ivPfGAQxrAs3mczloYN5N7YhGCCZKNqUC8Qy0/NBs0bWyPBwzTH/EdoUzOOo4Byhu0w+h3hti2RNeqCNCDo7eM3mpzI7E6uJgIv1ZeyHCzMF+TW4BiNV7a8cWdX3E9cJWs5ElRLKby/yi/DR5lujGEFi5lCLhrcE425hS5/1mFGUTLYFVzAITj65yCCQrYhWb5anSLjaqHHl70NFfEEZiInAsGvccoDTXU7oYuIBg++DYrHKOsKSvav3bmnV7fIswgpUJv0GI+7qbUMhiR773B9T0kUesYT8H7wnhizBMRS/Ui8WRW+LO67ATfQp54MJUW73MsIf1/L6tanTgFeESn7bmAoNZ5nM5prfrgWt8VFpXm/So65j/ROMRf2b/2cjkYJr1TqENodDwtsM0dYbcFkX+d1NJQJIV/8KTywJ0tr24EsGStqRdoFXgmxDjytbNJg6WYKy11swX+jOKOIoEl9Djpj9tGHRUWg+SHMVLXr5Yw5T6tViBQEj6ZFEAw0cuTdhCbyAJOnvFSo+VTSfrNEFZs/gsVBMBODGQBFwMb5P7C2JpyTJqvJAUqzFldTJ8U81zebs/Zixe+uVgFxLvSRgQpDIIQLouPcQ/G8DL3mBKPkIvdKgigA3hYC1HhfRq5KT6c9IK0GAJuD629KPk6pDuDKvjexRNOzXbo96gMOeyrCYB7hoYXGx95udc1QQLzGA/BP8LXY8Amm9yreb/DVMaG6+6EZQXxW65Ulj+rpwxUQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(136003)(376002)(39860400002)(346002)(396003)(366004)(186003)(26005)(316002)(6506007)(66556008)(6512007)(8676002)(4326008)(66476007)(86362001)(66946007)(36756003)(478600001)(6486002)(31696002)(8936002)(5660300002)(44832011)(41300700001)(2906002)(38100700002)(53546011)(31686004)(2616005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3777 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5427d0d4-ff74-4c8b-9739-08da7ea512e5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pFof8Uwz/8UAGmpi7CfEsyWcGg02a4LBOKtCekB0ECisFOy5ggKYn6HWXA9c9sB2w7WosEY3LXPa4YMVmHyY/wl+bI6gCGn794mK+eNwrQbuq/8+nCy/TWuQNd/4vUA7Ol9IyV6U492F+P71Qcpt2LropNkEztUrlNAvi3IJlYZDpKyre6BwDupAg8OOTsjD0RslCSsVje2496mjqBHuEL68cPdNnt68Nd7S3rUrsdh2juhJQG/JiDADF8zy2gnnXN7JCvTPk5e3RHcTpLx+LuVJE93d2q18YX0NJuL1GIT3jK6bz0H3/zqDVUySzopfpokPxv7RNmIHkDncGOuy07fV3swJzMmtpoJUCrVk3+4fuj1xEDKw2s01EMkxEHo1Phnx2erAe9MVexFpnXLKmYyidFraLrTbKw26phNjCSWLhYwpy7s3zkhiw89buWKyWiiA19nra45HfSnW0/9fJ3iCdU7RlIYwswOye1wunF3l+ZhtC2ZhZWkMTKvupTYfQI5cdEi1sXrqFmuWQ8rgcOPpbm7ngCkoj1j0/8QDihrOX8EipHkrhh/HcRWn460uoZizZcklaCO/zyowOoSF7oF+s/JfhnXW4SNhsJRuU2lzM9uR9jiO7Z2uddoSqu2jwE3AGDYKlGs0m1kFbXPz1YBprTEZfSDaTrpXfXeKX0ibg1Pvwu/i259KFazRQHPilkEUA9Y7uLRotwaoDXr74k9vsXE7VhDvl8a/Hbm2NdTI7tIUTVo9ZND9XTnlzSTUKpV8Idjvgz6byq/HvPynTIdD4abPk1B85PnF/duDv/1FnhOQCLGiSbaGxbiry9Y+FFJXp4WxXspoA7Ks5LQYAw== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(396003)(39860400002)(136003)(346002)(376002)(46966006)(36840700001)(40470700004)(53546011)(6512007)(107886003)(26005)(6486002)(478600001)(41300700001)(6506007)(2616005)(186003)(44832011)(2906002)(5660300002)(8936002)(47076005)(336012)(82310400005)(40460700003)(40480700001)(8676002)(4326008)(70586007)(70206006)(31686004)(82740400003)(36756003)(81166007)(86362001)(356005)(31696002)(36860700001)(316002)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Aug 2022 10:01:25.8298 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 46fa15c9-9818-4b3b-67f5-08da7ea51da3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3570 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Aug 2022 10:01:32 -0000 Just some nits... On 8/15/22 09:49, Torbjörn SVENSSON wrote: > In commit 68e80d96a84282d547f3b3c1234c99009521630c, the usage of > ___lc_codepage_func was introduced to determine the current encoding. > Prior to version 9.0 of MinGW-w64, the function prototype for > ___lc_codepage_func was missing and caused > error: implicit declaration of function ‘___lc_codepage_func’ > when building. This changeset adds a conditonal definition of > ___lc_codepage_func to allow a sucessful build with MinGW-w64. sucessful -> successful > > Signed-off-by: Torbjörn SVENSSON > --- > bfd/bfdio.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/bfd/bfdio.c b/bfd/bfdio.c > index a7c7d5bd363..59f79203b88 100644 > --- a/bfd/bfdio.c > +++ b/bfd/bfdio.c > @@ -29,6 +29,11 @@ > #if defined (_WIN32) > #include > #include > + > +#if defined(__MINGW64_VERSION_MAJOR) && __MINGW64_VERSION_MAJOR < 9 > +/* This prototype was added to locale.h in version 9.0 of MinaGW-w64. */ MinaGW-w64 -> MinGW-w64 > +_CRTIMP unsigned int __cdecl ___lc_codepage_func(void); I don't see any occurrences of CRTIMP in binutils-gdb. Should we not use that? > +#endif > #endif > > #ifndef S_IXUSR