From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-sender-0.a4lg.com (mail-sender.a4lg.com [153.120.152.154]) by sourceware.org (Postfix) with ESMTPS id 6F69A3858404 for ; Fri, 5 Aug 2022 07:45:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6F69A3858404 Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id B9162300089; Fri, 5 Aug 2022 07:45:05 +0000 (UTC) Message-ID: <507e25a1-7457-1885-5485-518366e35f8f@irq.a4lg.com> Date: Fri, 5 Aug 2022 16:45:04 +0900 Mime-Version: 1.0 Subject: Re: [PATCH] gas: Fix a testcase broken by new ZSTD support Content-Language: en-US To: Jan Beulich Cc: binutils@sourceware.org, Cary Coutant References: <88262e9dfc11097d08b552171f1af2e8e026f554.1659683506.git.research_trasio@irq.a4lg.com> <27d2627d-363b-8b7c-cd7b-3c3ea6818714@suse.com> From: Tsukasa OI In-Reply-To: <27d2627d-363b-8b7c-cd7b-3c3ea6818714@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Aug 2022 07:45:09 -0000 On 2022/08/05 16:29, Jan Beulich wrote: > On 05.08.2022 09:12, Tsukasa OI wrote: >> The commit 1369522f36eece1b37139a81f7f2139ba3915172 ("Recognize the new ELF >> compression type for ZSTD.") added the new ELF compression type but it >> accidentally broke a GAS testcase. Since 2 is now a valid compression type >> ELFCOMPRESS_ZSTD, the ".word 2" line in section10.s which expects an >> **unknown** compression type needs to be changed to another unknown value. >> >> gas/ChangeLog: >> >> * testsuite/gas/elf/section10.s: Use unknown ELF compression type. >> --- >> gas/testsuite/gas/elf/section10.s | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gas/testsuite/gas/elf/section10.s b/gas/testsuite/gas/elf/section10.s >> index d52b3458fb1..6a252fb6334 100644 >> --- a/gas/testsuite/gas/elf/section10.s >> +++ b/gas/testsuite/gas/elf/section10.s >> @@ -4,7 +4,7 @@ >> >> # Make sure that a numeric value can be mixed with alpha values. >> .section sec2, "a2048x" >> - .word 2 >> + .word 9 > > Hmm, in N years time this will become an issue again. Since it's not > really connected to the purpose of the test, would it make sense to > instead simply drop that one line from section10.d? > > Jan > It seems making a testcase using SHF_COMPRESSED is not good in the long term (because it tries to parse Elf_Internal_Chdr). Instead, I will use SHF_STRINGS ("32") without SHF_MERGE. Tsukasa