From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16399 invoked by alias); 26 Oct 2012 14:57:31 -0000 Received: (qmail 16387 invoked by uid 22791); 26 Oct 2012 14:57:31 -0000 X-SWARE-Spam-Status: No, hits=-7.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 26 Oct 2012 14:57:26 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9QEvOhK032219 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 26 Oct 2012 10:57:25 -0400 Received: from [10.36.7.68] (vpn1-7-68.ams2.redhat.com [10.36.7.68]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q9QEvHOK029658 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 26 Oct 2012 10:57:21 -0400 Message-ID: <508AA329.9040401@redhat.com> Date: Fri, 26 Oct 2012 14:57:00 -0000 From: nick clifton User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 MIME-Version: 1.0 To: Steve McIntyre CC: "Joseph S. Myers" , binutils@sourceware.org Subject: Re: [PATCH] Add support for new ABI choice e_flags values on ARM References: <20120830124156.GC8449@linaro.org> <20120904172555.GG8449@linaro.org> In-Reply-To: <20120904172555.GG8449@linaro.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00421.txt.bz2 Hi Steve, > Updated patch attached including test cases for ld. They work for me > OK (explicitly testing both positive and negative cases for the ELF > type and the ABI version), but it's the first time I've worked on > input for dejagnu so review here would be great! My test cases work > ok, but I'm seeing a lot of other failures unrelated to my changes; I > assume that's expected. Approved - please apply. Cheers Nick