From: Richard Earnshaw <rearnsha@arm.com>
To: Yufeng Zhang <Yufeng.Zhang@arm.com>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>,
Marcus Shawcroft <Marcus.Shawcroft@arm.com>
Subject: Re: [Patch, ARM/AArch64] Add new elf note types
Date: Tue, 08 Jan 2013 16:56:00 -0000 [thread overview]
Message-ID: <50EC4FB0.5020803@arm.com> (raw)
In-Reply-To: <50EC4DCA.8030500@arm.com>
On 08/01/13 16:48, Yufeng Zhang wrote:
> Hi,
>
> Please find the updated patch and change log which have incorporated
> changes discussed offline.
>
> Is it OK to commit?
>
> Thanks,
> Yufeng
>
>
>
Ok, but,
> --- a/include/elf/common.h
> +++ b/include/elf/common.h
> @@ -552,6 +552,15 @@
> #define NT_S390_SYSTEM_CALL 0x307 /* S390 system call restart data */
> /* note name must be "LINUX". */
> #define NT_ARM_VFP 0x400 /* ARM VFP registers */
> +#define NT_ARM_TLS 0x401 /* AArch TLS registers */
> + /* note name must be "LINUX". */
> + /* This and the following two
> + definitions should really be
> + NT_AARCH_..., but defined this way
> + for compatibility with Linux. */
Please put this comment before the definition of NT_ARM_TLS, and change
it to:
/* The following definitions should really use ...
R.
> +#define NT_ARM_HW_BREAK 0x402 /* AArch hardware breakpoint registers */
> + /* note name must be "LINUX". */
> +#define NT_ARM_HW_WATCH 0x403 /* AArch hardware watchpoint registers */
> /* note name must be "LINUX". */
> #define NT_SIGINFO 0x53494749 /* Fields of siginfo_t. */
> #define NT_FILE 0x46494c45 /* Description of mapped files. */
>
prev parent reply other threads:[~2013-01-08 16:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 16:29 Yufeng Zhang
2012-11-21 17:20 ` Richard Earnshaw
2013-01-08 16:48 ` Yufeng Zhang
2013-01-08 16:56 ` Richard Earnshaw [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EC4FB0.5020803@arm.com \
--to=rearnsha@arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=Yufeng.Zhang@arm.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).