From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140088.outbound.protection.outlook.com [40.107.14.88]) by sourceware.org (Postfix) with ESMTPS id 7F53A385C32C for ; Wed, 24 Aug 2022 12:39:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7F53A385C32C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZyjtotvEO7jZHbkl2zqrZ51Yh18SzBVU6IghGE5Jqwe+/GhY4AaevV8TVlupIjuCtWIWkgQXHzd/JqbBIVGGO8zJm1vIZ+ywyCnhDTi4RHiICc9W8vb/RKgL+D1fSh4BT8/OFaerLb7AnWA0sbKFxJQv5veJQwCEdb+7DrsW6m881VrWu6EJ07WKBctt8LS3hoPN/oaa0mE6cGQlIF/y+JFx5sScCX00V/pB9441xqPfMAzZdmJX0ThaswiKsUxKQ2YcH6WziSy/LuckgW4rbJwPg3A+IAUUgNcPERrKR3ieW/TVgvj5BDcdaQFkgKjaDFAqxvwEcFlyPPPaQbVqPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d3Lr0HHNJhBDUUUP46a7ZTBM82k2kmOP4goLKJUpTIE=; b=A/w9bkWjzDN3iDe7m3uGKRzIr+S/oEjlZy9752+gGphfmmQTPhaEIITHzluQtD6ZvSR59e27V7EpWR9KPdzr3JkDvqSysCDWXm9W36UqvYuJhlw1wsVil+AoYPswa1vcS7VgM/Yk1TeZR1Aq9FoKjwuuuh8TQG8TbzOMvrjsLWgSIQkxXx/Ob1a/d0hKMI5AywkMsCJqhp2BK9rOQnDvXUBatyeVHngpjdkE6hA8QlrtIqe/9MW4b1A70JGG/447wO2SCv4/asl91k8imQONi6QLouMtreg0DL5Ousj1vN8JhWLgkAYbPr4YlS5BMr/5A7PKMwRxqgxZNfY1qIh35A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d3Lr0HHNJhBDUUUP46a7ZTBM82k2kmOP4goLKJUpTIE=; b=uxULQWfmNNmRqlynEzUzKN8uYjH7Vmp7m9UuPd5XzP/xxyNj61sxzDpsJDi2ta7sdmlShqw7WUH7i44ruZ9Q99pyHoOOryaDvRLHr1+4zSFRVH5+4iNjnG82Nj/YPXIIJPP7nG8IcEsNQK4M3xxbuVnJoEBsBvPEQ0OheYEzBEaeTXrFUaswkNfdd2TrPVfFva/kkJJ+Jrtvi/icV7yEJEiMsJ8XYUrSutIY4SSLBj540lQYDxkM0cxvetDlLw4qCQ4I1hULJo3ivDRf+DRfH8ZBZ5RU+VniitD9gewO1X4pw3KBoJxJEIKooleFkmgG0wgpi0Jz90q4P/rKGvU8yg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5505.eurprd04.prod.outlook.com (2603:10a6:208:111::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Wed, 24 Aug 2022 12:39:49 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2d5d:bae0:430f:70ad]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2d5d:bae0:430f:70ad%4]) with mapi id 15.20.5566.015; Wed, 24 Aug 2022 12:39:49 +0000 Message-ID: <50de6515-6420-b144-5194-14c05acafa4e@suse.com> Date: Wed, 24 Aug 2022 14:39:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v7] ld: Make archive member file extension comparisons case insensitive when cross compiling too Content-Language: en-US To: =?UTF-8?Q?Martin_Storsj=c3=b6?= References: <20220824122503.19441-1-martin@martin.st> Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: <20220824122503.19441-1-martin@martin.st> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0009.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9d14de04-2330-4f74-1ebd-08da85cdbbf5 X-MS-TrafficTypeDiagnostic: AM0PR04MB5505:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zw2awGgGe07S/pz8YUh5jQgxGTj4CMhCqkNGKoEnvRLr+2aXwxRjbmuwVv/HIq3rc4oAU6+/SNor0BhjXqMLNyG2sC18+JFaaeMrb3YQeywzkoku/LaF8yxyWVZOBvV8t0zH8xNX4JtSz3Ia8/E2eUeeznqc0VDqMAkVyIYCSQx92UZYSQcM++PUuUk8NZuUOgDz/QX/7QhGV0b+Y70kz03FvtM/f3/8OT+5kYo1iiQYD66xdZ/UN8BCq8pS1pFXzA+2mZ92ETqAJSkBa8DnVcoYP5Iloww3QXfW7T4VfRpqRjeuhrKSdgTWWnWd462kAXNTk8Da5roR/YdO6yS9ruCV+197dOGLDigNj6A+Qyek7goE31W+sYeZOqkoUyHL25qwt5fR8YH/+OQ54f8XV/BXdH/vvAys34z1Lng6jSpmAkbBRm8QUv3iO5heFvyIC23BP51l7k/pq7GiI7y+RVVWpUEqfScEVvBON5igDyW9UkNStoDyAQ7M9GFlz27+Q7aGF+jow7gj1+Nhsou6UNoe3pIJvs03f0nHEXmHgOJuFVvZzkI07SnoTOM0Wm1gikXFJ2mFFmfxbQpYzaPyqCq5Gvs0f7hh7nRipel7DcFM8p+O9wUxnpWNPhbkTw0uW3ylyOqxyonZl6dZL2y9VsNrLPoyApcF2jFd+yOvpb/HykRVgFZQJnYxVW48VnoLUL2vSdPfzHCUEScibbeCOWH1hevDecAvG8E5jl0lPob/LtgytkvCUEI0Gq8LK3LNFTXGtjOvaSRLiHd5VRPNPDctHYjF2P/mskcpsfuAKeg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(366004)(376002)(346002)(396003)(39860400002)(86362001)(36756003)(31686004)(31696002)(26005)(5660300002)(6512007)(41300700001)(4744005)(4326008)(8676002)(66476007)(66556008)(8936002)(186003)(2616005)(2906002)(6506007)(66946007)(53546011)(6486002)(6916009)(478600001)(316002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXgwUlc1SW1vQ2kwSUQxT1IvVXJ4OWlJUnVJcmFaY3NxMERIeWpud28xN2Mw?= =?utf-8?B?MnNVcU5aZ1laL1JqRk5PejY3WHJVMGdrV0MvTTQvZ2xCa05ZeW9pZ2xISlJs?= =?utf-8?B?Y2ZOa3ArZjQ4U2RXM1lpVng5bng0bDVMeEtNYmpOSFJyaHRNVTlmTFd6TSt5?= =?utf-8?B?QnNiMU1PSWZSbVRmVzdURnVkNXN5eXM2Mm9lNmx6ZFVHb3hDdUJoVzlEOGJo?= =?utf-8?B?SjdYRHBnbjlMdUg1TVFpRFh6Vmd2UWF1VXRsZUtnMmpmSG1NNU5xUnRVNVh1?= =?utf-8?B?SnJXMTVXQ0ZZK1cwQkFZQzdxR1pZcUdBaDhxeVdVd0l6bE0yUkRqYnFYeWQz?= =?utf-8?B?MlIyRm5OWWZlQTdZaXg1ZE1USktLREZyN1JHVWk2cUZlUURPNWhXRGVvOHN3?= =?utf-8?B?cWtvczFZS2R3ZzNTYVowVU5LWE80TlR3RVQ3YThXU2JCVEVkUDhleHFzUlhk?= =?utf-8?B?WnJXdDQyU1ovVnA4RUVMMU9HNU9TdkNZNDlYQlh3KzJHeU9MQjhmNTJVc2lF?= =?utf-8?B?Z0E1dyt3QUZ2emJnbHRTRGg2RS9RU3V3WWFTNUl0KzRYb1p4eVhOMjVybkxR?= =?utf-8?B?UllVZExYQUdQN1JtOXVjbHRhZjdYRkxid2RQYUhoVGFjRVpkZFNvVi8raDI4?= =?utf-8?B?dy9aQTY0aUpySTFzRHhmMVMza1l0N096QXd5UHVwRWJoUUw2a3RreEFvR0tD?= =?utf-8?B?NjlWNUtaN0ptMm5YMEV4NTZBTWRGTDFwTWIvaDBIMXM4amEwRUNoZmhFUkEw?= =?utf-8?B?MmFseTRzTFNuY0duYStld0xMZEFCOW1OYWtDVlZRa2VtWUFMUEIwanByaE1T?= =?utf-8?B?MFJwU2VSbWc0MFBnRmtBeGRpSm1yUEpLUlkxekJqZld4TzRrYkNlK2pDSWdn?= =?utf-8?B?QnJDcGJmM2hucDlFUEhwNVp0Y2Q5QzgyZVRVckFkdnFWd1pZdUo4RDV5STgr?= =?utf-8?B?OGljMVhZOGV4bzAyVzk2Yi8zc3NCbHMrMGIxQ0xNQzRLWHVaRUJ4TkZBQVl5?= =?utf-8?B?emM1Q1RxYmxOcEF2cTJOYVpFWHFiM1VZam1GdWdGdFhoMUM0UmtydVNQanFp?= =?utf-8?B?RlJ0UXFKOWNEajgvRzJ3NWNGYzc4cURoMEtwVlQ1emg2L2NBS0pJNVRSOFA1?= =?utf-8?B?bm43d250OSs0OG1scUpIM2RDemozVFAzZE8yNGRNRFdUY2pPMlJ1OUlsVUFI?= =?utf-8?B?bG5zSlBIa1d3VjRBbXdWUVM3anY2Mlh4Tkt1bHhNSUV2b0V2Z1BOSjE3R2Y0?= =?utf-8?B?dklwK2RFUTQ3a0tWV3M0Z3NuVE9vSWNCUVFha3VITzJ0OWZ0V0VGVWp2TFRQ?= =?utf-8?B?RFl0STZubkk4Z1F4c2NTR2F6b0l1SnRyWVVsWnBjTmhrTTVZY01RdS9GaTRW?= =?utf-8?B?TUx1VVI3N3ZuM1pOSjdCTG9pMnRUSHpvRjBpMTQvT1NSSC9jQjN5Tk5aRmZD?= =?utf-8?B?bmNIaHJKeWEzUUVmMjQ4a3QrOVY1blVEeGVEQmxkbXN1OVhXa3RlUlVVcTJS?= =?utf-8?B?bUZNOXA0TlpDYklZZllWWGRxM3FOd3NaTWY1UHBialV3RGI4eUpVNkd2Zyty?= =?utf-8?B?MkpBTGpYQjk3aHYybmxLVnByWStYVE56eUVpS0ptT1lTYkFyeXF0WFVlaTFO?= =?utf-8?B?WWZ6M2VWeCtnUC9lcWkxQ0dUZnRPblc2YzF6TWRtZmYxNEVNcEd2Q3UwUFRJ?= =?utf-8?B?M291NjBBSTduaGVJTEIrMXdmS2xRc2tVOFgrbndVY0w2MDZZMGdvbi9wTlFM?= =?utf-8?B?TDd4bFJXeEdlb2pHc2g4YnFsRmxEWitWOGx5aUxUd0c4OTFUTG5zd2dlUjVl?= =?utf-8?B?OXJab2tkM1h0K0w2MHdscWhMMGNJRkJrY3NmSnRqWlBITEMyNmd6YXFFL3hE?= =?utf-8?B?RUJnSW9qZ0NBM0xjcWhUb0w0QWFYZ1JLNllQKytVSm1iSTllNkZ0TFpMdXRB?= =?utf-8?B?SHA3T1hEdTdKT3N5TkRnQ1gwUDVaZHA3d3c1TWV5emk2cG93WlZDSExsNklZ?= =?utf-8?B?dTY5NjVJZFRGLy9teS9vL1FsSVU5WFlXT0Fzd1MvaWQ4YWZxRHJuVmkyYkF4?= =?utf-8?B?d01rSWRJS0REV3JTRnhCazlxOXdRUGRuVGR3WGR6NUZCdm9jWlkvd2kvYk9I?= =?utf-8?Q?cqeRmRv3jD2Q2q9PNJecUzjxF?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9d14de04-2330-4f74-1ebd-08da85cdbbf5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2022 12:39:49.5633 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +1fmwiZRPDGJIzzyeN/AoBxuOw8qDpzBqQ8N4jHnW4OYaEnaid7+pBzJXdeP0actZ5SIQct5Roy2o5W2Yo7opA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5505 X-Spam-Status: No, score=-3030.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 24.08.2022 14:25, Martin Storsjö wrote: > On Windows, filename_cmp is case insensitive, but when cross compiling > with libraries that may contain members with uppercase file names, we > should keep those comparisons case insensitive when running the build > tools on other OSes too. > > Also make the check for .def consistent with the other ones, fixing > out of bounds reads if file names are shorter than 4 characters. > --- > v7: Skip the '.' entirely in the first parameter to fileext_cmp too, > simplifying the function and making the two parameters more symmetrical. Thanks, lgtm now. But before committing please give Nick another chance to comment back (I guess waiting for a day or so should suffice). And thanks for going through full 7 iterations - that's certainly not a usual thing for binutils patches. Jan