From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay12.mail.gandi.net (relay12.mail.gandi.net [IPv6:2001:4b98:dc4:8::232]) by sourceware.org (Postfix) with ESMTPS id 1C23E3857C50 for ; Wed, 20 Apr 2022 09:52:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1C23E3857C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=helflym.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=helflym.eu Received: (Authenticated sender: pro@helflym.eu) by mail.gandi.net (Postfix) with ESMTPSA id 9DEDD20000C; Wed, 20 Apr 2022 09:52:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=helflym.eu; s=gm1; t=1650448348; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=WRWzJJdd7Fb2wFnJNq7AoFCgC9EAlBt6RBltPTo4qHo=; b=aF1DWTCp8M0PJOjVp5s90tKxTgtaTHKhJAZ2SNFxhb82YxjlFT03bRX8e0o5zRjXR+13Fj TwKnbeElPdkLIXulz/yFesKAwjcEp3QeaynGAbLl16KRK6ErOEBTE0l/1DZ7U8uFD9/GBE kHQCvRwmU8VeMKmDL1YKfOHaGT41lwPMxK3DenfwPH6p7GJqb/QEKaDFAYs2lubBosVvaF OslrBGrDp3ZYDdFkL310sANv6gz1hOdVv353bKTxn6vS2cE9ony5fBPfsaEY4EgeyAknkU 9qoYlJchggSP9qL9WfJOtxb2PtIStpxnDveQ0iMdH+fR52Pr3le9wj4528ZMpw== From: =?utf-8?q?pro=40helflym.eu?= In-Reply-To: <21cd3a89-945b-25b6-fc14-1b9120ab2057@redhat.com> X-Forward: 127.0.0.1 Date: Wed, 20 Apr 2022 11:52:27 +0200 Cc: =?utf-8?q?CHIGOT=2C_CLEMENT?= , =?utf-8?q?binutils=40sourceware.org?= , "Kavana N Bhat" , "Ayappan P2" To: "Nick Clifton" MIME-Version: 1.0 Message-ID: <5149-625fd800-1df-4c0aa900@128699948> Subject: =?utf-8?q?Re=3A?= [PATCH 2/2] =?utf-8?q?xcoff=3A?= implement linker relaxation User-Agent: SOGoMail 5.5.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2022 09:52:31 -0000 Hi Nick, As I said to the previous patch, I can't do it right now. Thus, if you = find a bit of time I woudl be grateful if you can make these changes yo= urself and apply the patch for me.=C2=A0 Otherwise, maybe Kavana can make the change and push the new patch.=C2=A0= Thansk and sorry for that.=C2=A0 Cl=C3=A9ment On Wednesday, April 13, 2022 18:32 CEST, Nick Clifton wrote: =C2=A0Hi Clement, This patch generates a compile time error (using gcc 11.2.1): bfd/xcofflink.c: In function 'xcoff=5Fstub=5Fget=5Fcsect=5Fin=5Frange':= bfd/xcofflink.c:4332:20: error: 'sprintf' may write a terminating nul p= ast the end of the destination [-Werror=3Dformat-overflow=3D] 4332 | sprintf (buf, "%d", n); | ^ bfd/xcofflink.c:4332:3: note: 'sprintf' output between 2 and 7 bytes in= to a destination of size 6 4332 | sprintf (buf, "%d", n); | ^~~~~~~~~~~~~~~~~~~~~~ I suggest increasing the size of "buf" to at least 8. In addition if you are feeling paranoid, you could use snprintf instead of sprintf. Other than that though the patch looks good to me, so approved, once that above problem has been fixed. Cheers Nick =C2=A0 =C2=A0