From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 853FC3858C2C for ; Tue, 18 Apr 2023 10:51:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 853FC3858C2C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681815074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+fiRpWF40MuD2AxOtglQFLDY7sJfUyNOA/ZbLQQJ2oA=; b=FDawqxQ9XYWPPZa83NZcBSUTkIcvGcH5n2F/nz9g4jE+4dugBc9nPfgwC3wq3i7Yp517nr JesRNgI5L9aKOIx+WLC8AOuOAD1mAQQfKz34TXQ3mETC7rV2dVFcxEgfMpMQVKPqUnLCXf KeO9gS4WunqUdUi7g2qZqI4BtKYQNtA= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-94-pJRagpvEPBmn1wjX9pub7A-1; Tue, 18 Apr 2023 06:51:11 -0400 X-MC-Unique: pJRagpvEPBmn1wjX9pub7A-1 Received: by mail-qt1-f199.google.com with SMTP id bp42-20020a05622a1baa00b003e6748b05edso26756484qtb.2 for ; Tue, 18 Apr 2023 03:51:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681815070; x=1684407070; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+fiRpWF40MuD2AxOtglQFLDY7sJfUyNOA/ZbLQQJ2oA=; b=E64D5aHggyUOucRA6pCvnUb3l6/bfHKUj4ZBORiUAZoixFloBG8bRzk6fRcJ86iJLE QFL7OWrcPpCI94/HIvUU3+OuxjV5FRyTCKxKOhqTzmF8qhr+jb3JrJf4LLNsM5Bo6t63 gSMpfXydxfAdGCkPXDyUgvsXeriG31h43GKn/+yNE1BjShcOWsFl92DjbY08ygJPDmtB 5nynNHG506s8tPS9ZYo+3CakjAcQcSTAj4qH+tTn/Q7ltajx21JQ9oyCW8JW40jsflyY Wx7YeRKsvfr0/fAPHMWIq08cRJYeX/vJf3FGwFb5JKPNcXMVc33bnNtC3xJvk7dzqzGv wQwQ== X-Gm-Message-State: AAQBX9fy1vLbVtQ7VlnJIF++rJRm67lhE5eufW0ftp1uILeylP/9i92/ LASLtUa7mGzPwsGvkuUZHoPTRd5drwAEz2KqqSGkTn06R6oMa05cGZdPkh927gVomhQ1RYDK0qi tO7RmtbNeTE8MBUWTaQ== X-Received: by 2002:ad4:5de3:0:b0:5df:5533:6fb3 with SMTP id jn3-20020ad45de3000000b005df55336fb3mr17964538qvb.5.1681815070713; Tue, 18 Apr 2023 03:51:10 -0700 (PDT) X-Google-Smtp-Source: AKy350bBi7oSDkM8CKsY80REYOqnC9kP416sH3ttvAHdRFyVhb9/jN4ViGAqcJbZYfD5h15WsPVsPg== X-Received: by 2002:ad4:5de3:0:b0:5df:5533:6fb3 with SMTP id jn3-20020ad45de3000000b005df55336fb3mr17964530qvb.5.1681815070516; Tue, 18 Apr 2023 03:51:10 -0700 (PDT) Received: from [192.168.1.7] ([79.123.86.193]) by smtp.gmail.com with ESMTPSA id eh18-20020a056214187200b005ef5ba49adesm2740941qvb.57.2023.04.18.03.51.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Apr 2023 03:51:10 -0700 (PDT) Message-ID: <515667f3-5309-d89e-f44b-d4b3d7d96e28@redhat.com> Date: Tue, 18 Apr 2023 11:51:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] Symbols with GOT relocatios do not fix adjustbale To: mengqinggang , binutils@sourceware.org Cc: xuchenghua@loongson.cn, chenglulu@loongson.cn, liuzhensong@loongson.cn, xry111@xry111.site, i.swmail@xen0n.name, maskray@google.com References: <20230414061935.1252692-1-mengqinggang@loongson.cn> From: Nick Clifton In-Reply-To: <20230414061935.1252692-1-mengqinggang@loongson.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi mengqinggang, > If a local symbol loaded by GOT, do not fix adjustbale to avoid GOT > relocations' addend not equal to zero. > > gas/ChangeLog: > > * config/tc-loongarch.c (loongarch_fix_adjustable): Symbols with > GOT relocatios do not fix adjustbale. > * testsuite/gas/loongarch/macro_op_large_abs.d: Regenerated. > * testsuite/gas/loongarch/macro_op_large_pc.d: Regenerated. > > ld/ChangeLog: > > * testsuite/ld-loongarch-elf/macro_op.d: Regenerated. Patch approved and applied. Thanks very much for contributing to the binutils. Cheers Nick