From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2089.outbound.protection.outlook.com [40.107.8.89]) by sourceware.org (Postfix) with ESMTPS id CB08F3858D37 for ; Tue, 24 Oct 2023 06:04:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CB08F3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CB08F3858D37 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.8.89 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698127442; cv=pass; b=QWB6S2IVGv25L9/Kb9u1cIbaFbmVRf9EjV7bcdx7IFhbE3oekZcFj/n0EdgtSuxW4Yz/PwYvwgC/bOhiwYGijTTtQrbt6nUBSEt+FZpBkXkBfHincvtogRRcdwTCWW1tIvgH0ejetwFPzMiUiEipkL/SNidFMCMdTZlKIHgWAx8= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698127442; c=relaxed/simple; bh=ZABHxpOeO1TzfLWuQHSF/yxyua8xcmqGsTqVfDCo49E=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=pgNXH/kTqqJSFGZrQlOp+48ha9Tnu9XSDWWcRMedAMT1ZvWa+yLZe3NfXVzIEBZDCcNgPbSJTfnRDghz8iA6z7IQPG2Qw9Yd9BQVt4JXtudP14BcREaovk7Og2k6/+5obzCrD/c+D+CQIa+vnEMzkI6+xHXLLT0BCZPK1PbyrEk= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C7+w6iNA2NnZW9m1Hbgi6MuaHXy0zqWrO5ptSFGQmXRqJadWrPZZTK4AZRIkxC8qfiJu1vwQviOyMUJL72DLyUL+wNKQSE1uc2EYEqi4lYhDCVWno+VDhn9CQNfQtyjIsadt11/Te31JsFhovwUobjgh3w+Xc1lkDMhkQRUlqfwbUUNrf3xUJ8+erd0PR44sFPE7hRN41azozDikKccHiQ/dUt8rRkpsaK1LwymYWksK/Nygv+RdTxSFJQpqK/3FvcFa0bONwDN+ksBszeZpc50OigeEpwGSUE7J/t1PeUKBhVU4OZryEu7vZ8XjMWQT6js+5yrSN2Y1l7pb45fjog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a5wxlAh/0ggVbpTF8HxqrFepF5Kx9aT6kNu0kHkn5us=; b=FnQSrk8bNQIVYJXzs97hyv8K4yKHDdDOZwOfA1xRPRNoqZq1m2NoI8i7ptbksgPNatc85ly9KSQ/3Lc2Q6FPcMmcOLU/yPtGnMVkYMKrjv5indpLKUaVoDg4PFuD0RxBI54PhgwugVed8YpKWHzFzW8hc+F0zGOqsuZK41wdUJY/0ooPwEDIVj44XUbp615KFRH8tM3pdGx/FfuTwDIPhhEKPIXzKOtod0Jus3wlBW4RJbFvl/jivuZKM0GJ/SsrqmCYkg/wUJshQ6h6oBivILs96JQudLtEA3kFohtcKXErdJCK4tyvcmX25OMIzdxecxm3diwJwsvvRpuVxN+uMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a5wxlAh/0ggVbpTF8HxqrFepF5Kx9aT6kNu0kHkn5us=; b=yrQmV3iOb/QaQAocEqxIDO4KezgN6gXSAlir8hLp6KMWNvYx2/FcYZ6WydY2ffnfFOYPmEtGi+mW/gnnbqjclV7K8K4V4A0QvgvXUtqgvox7BLX2KN9TqFQPXjEvXPDkgq7OVlqT0yA7+u582e18zNpckRxWgC4s3BgGfKEgEBajj7denH8wjnJKi/bJybJz07hAJ81Mju/wXeLs7IJ7S9/zOOy61WKu2C1lG5rjOLeTIRh/TliKAa18u1s2V/2Hf/Lqp1nW5dqkajlHjmnIubh+G4h91ChtL5DJkXn4NmZs6Y7es0YBHJvz4zW4uyvtoa/4ojoNcXdYJh5/Cche3A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by GV1PR04MB9215.eurprd04.prod.outlook.com (2603:10a6:150:2a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.11; Tue, 24 Oct 2023 06:03:58 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::d924:b650:a2ad:7b25]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::d924:b650:a2ad:7b25%3]) with mapi id 15.20.6933.011; Tue, 24 Oct 2023 06:03:58 +0000 Message-ID: <51c66ad7-91b1-d674-808d-3889511540ba@suse.com> Date: Tue, 24 Oct 2023 08:03:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 5/8] Support APX NDD optimized encoding. Content-Language: en-US To: "Hu, Lin1" Cc: "Lu, Hongjiu" , "binutils@sourceware.org" , "Cui, Lili" References: <20230919152527.497773-1-lili.cui@intel.com> <20230919152527.497773-6-lili.cui@intel.com> <68619a61-a0f4-a851-77c6-e324eca30cb4@suse.com> <23c46515-cd47-ce21-f0b3-1d6d42fe1328@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR4P281CA0183.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ca::6) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|GV1PR04MB9215:EE_ X-MS-Office365-Filtering-Correlation-Id: e5c5967f-d351-4a37-a4e8-08dbd45702e9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TzVxTEiJc5GtOz4sdYRKKOSNxpiKZCRmFWzwJxgGy1e++JwxH8ThDHLyWJFy3PeuxGm/Uh/V3XddoAJYm7qM/NUk+aMRaqT179sJULuprtZwuQkcEoC7tBTC5zXTIPFax4XEiMedupl7FrXF3JhTkSDhho5w/8VDmDbDEkRBhBp1IczAjKBU1pHnNZVfg3dsIyKDkI60SZsd6lJx2vg+XV5b5feXAAa5kXfztL/lz/3UIRBDDCZuUSXXl5/QFrOQDAjuA7SGrgYk+eP+r/15F5s6yWcd5Hr7foxm1D3+EPOKmqbB+OCoMdmI+zSd7ebah11ps34/6aWB/HeegypNSJwMqluvTuMnDyt6/CqTyWcvGpzwrQo3GEZubGJDXnRIQ2zQyx8z1dXS+u3CQcvbZV4us2nltT/BrDCpignAlxG1oHYId6AMTkBv7xQGQsq8Cfy7HDoM1JGEBnPHLy/5hRQKs29Go+O4f5tlEBZkAlHtCdS2Z/dkcVQiPpYcsFmjDshVHbesbIVYJsMMKsq/04J9POzQcHnPg37yjoMLarDKxbVdiVIVBTEvkidLBGFhwbozTKRI9n3vYYLerUSSgXWpQZrtg54ImPF47281675oUigwnG1mYkB+QliRIS9ycGHcpyVFSXeFNMwXwASzog== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(376002)(346002)(396003)(366004)(39860400002)(230922051799003)(64100799003)(186009)(451199024)(1800799009)(66946007)(66556008)(66476007)(6486002)(316002)(478600001)(6916009)(54906003)(38100700002)(41300700001)(31686004)(86362001)(31696002)(5660300002)(8936002)(8676002)(53546011)(4326008)(2616005)(6506007)(26005)(6512007)(36756003)(83380400001)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHB2R2d5eXpXUnA3NVluNndOaFlYQ25JTGtVZERZdE1ueUV1YWU1SmRNWlo5?= =?utf-8?B?ODJZYXJ5Qjg4cEZHMm1HeG9VQlNuc09VZTJTclN5NTRIS0pMTEtvUTNJMFNZ?= =?utf-8?B?SVRvWkhGd2FoWVFWYmIwaUR6SmFVaCtQRWkxNzhjVzI3ZW9DSkdIUzNLQ1RE?= =?utf-8?B?NHlEQVhjRUFEekQ5MFlRVHRBeW0yem5Qa2hPam01NGRlK0Q4QWtnNjNYL2xn?= =?utf-8?B?MmlWQW50bVYzdm5MZnZGdzYyT29uN094YkxHcGtIMm1MU3h0ZUhjeUlRcDRP?= =?utf-8?B?OWk5SnFHcGt4UTVsRHRldXFBbmZiZGgvOEtDZnJwMTBQUkRQb3l2VTJteVAx?= =?utf-8?B?UXg4Q25EZktYOGxwK25DTldXbjJFbnNSSWxHSFkzRjJPd1JZWEFhdVR5S3lV?= =?utf-8?B?TjF5amlHWmY5cUlHZnF6VVZWcENOSWxpTU5sNjg1Z2prQy9QWEFHbmRvTERz?= =?utf-8?B?TVEzeG5lUkNjRmJhREpjUWZ4SG05KzQ4VWxSaHFOanZYcDhlMUl4SVl0SmRY?= =?utf-8?B?WVV3RDVEM1VkRjdLeDB6bVh2YVdRNkgrclZiM1lDTDRoTVNBWmJNQTJYN1FM?= =?utf-8?B?Y1F6N2xxL21tRlJZU3VPUUhCL1dqY3ZTMHNUSGdDZG9ocWhKeHFWK2RIckda?= =?utf-8?B?amxscWFjNkNhMVowbnJhWDF5Y3RLektzUWVLd1hHNGkzRFFQZFhwSDNsdkg2?= =?utf-8?B?YzI2U2tBcFRJdC9RNVY1SmJFRDVVY1FpbHlsL0x6d3ZTbTJXWXhwRGIrTzlh?= =?utf-8?B?R1JUMEVLclB1dGdkbjFpSG5WdzMwSGg0bkZIWlZnRUYwOWVYNWduRGFPdjVE?= =?utf-8?B?Y3pnTkxOQVkyK0FkMXdOVUVpVGVEdFVLZ2hOVFZ0dnZOQ3VzVnV2emI5dnR0?= =?utf-8?B?ajg3Tyt1Wm11VjRvdmQ1dlZZRStHU3lUZDA3OE41bDFpVXRsUHZJQURvS1ls?= =?utf-8?B?eVBaK0RWcUFha1AyVkV4cnhkbjB1czZaVHd2eU5ncnVxN3lLUGt2L3oyVVNE?= =?utf-8?B?ckU1bzdnZmxlMjBoWWRjZG1HUjJDMW90VDM3QXZPYXQ3MlJXVGlSQlBJODdz?= =?utf-8?B?NUF0NnpoMGR5VGhhVi81OEFxRjlTNHlZQzYycUJvbmRHd3hoeGZDeWdtQmFT?= =?utf-8?B?bXhWRXJaMXJCWUJPL0t4U2RsL1ZhSjgwWU9RVzJrNjhQeDl5b3NvNzFSS2JC?= =?utf-8?B?Sk1vN3FJdGQxcmE1cGRuZkNuY1gxVHFGR0JJR2N4dnJzRnlQZmFiU1BOY24z?= =?utf-8?B?TlpKZXo5RG5iNFRuZ0JtQUo4TDBNZmJEUkNhaDBmWnN6N2kzbFh5Qi81czdl?= =?utf-8?B?b0trTGZqaTVySkpVdGxFN2h0Rm5kTWJJQmJXd3p1MW0yajlHMHhwSk1MTnli?= =?utf-8?B?ZU1JTmhIWmlmMERJenVXYUxSdGEwdG1Pb3dQbHo0anlQcmRvZlBtRVdCbHJu?= =?utf-8?B?eEIxRC94dEtuN2hMc0JNdW5jQ1JhaVBXOFgxK0UyVzc2RDlGYWdpNFI3YU1U?= =?utf-8?B?Uldia1ZQTHE0MWIxRjBHNk4yWXp0c1dBUDdlNlF3UWtOSTR6MXpocGJPVm9N?= =?utf-8?B?aHRld0xGZkhmTTVrUFFWQ1dhK2ltcE8rWllhWC9EclpMOXlpVUlaMzhnQVB6?= =?utf-8?B?Ri85akRoc01xMzFMR2ZMVDNkcTd3ZVJialNna1dYZ0VpY0hvSGlNaUgyblI3?= =?utf-8?B?b2lyL081QUlBMkh1N3ZlekhMWVVEcFVXUHFUYjg3V005ZktDb2N4bEJsUk9j?= =?utf-8?B?NGVvT0RJcTRiNVVpL01ONWxRY0h3VXpIVDlyd3hZVWVSWXd1R0RXQ0p3REhG?= =?utf-8?B?YUdRMzFBUUpiRHBJSC90VitGWWJnWXErcFFjUnBqQ3hlaFpXcy9TYjB0d2Rh?= =?utf-8?B?TkxQWTMreHFCUUhOZDBRSkxYUXp0R2VWbUZLQkUzL3dENDVtOVYzSXlETmZ0?= =?utf-8?B?bmMvemt2TDZrT1o2S1BnWUNoM1Bib3F3cVk3WFdVU3pIY1lTWGZYeFFTNnlp?= =?utf-8?B?V2t5SmR0ekJGWEVaUDBlVGRvQjFvZUhnYzJlSjJJUi80aXpaSHV5c3VWc0Zl?= =?utf-8?B?ZDlKS3dTZUxXMW1iRlNiSWJGd3F2VlNZRVZyVkRBUnMyNzRrWGIxSG9TdzNp?= =?utf-8?Q?JF8J02rdq/eaeyp5frgM8SLA+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e5c5967f-d351-4a37-a4e8-08dbd45702e9 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 06:03:58.0715 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lcYlXLktCAPrbXw8DPB2Y5vPC5lBXtoNzNJVHbFNFUitLkuJK1YK2iFx8SQQCg0oMsQybeywqNrmo+OdAnKm8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9215 X-Spam-Status: No, score=-3028.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 24.10.2023 03:40, Hu, Lin1 wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: Monday, October 23, 2023 4:15 PM >> >> On 23.10.2023 09:50, Hu, Lin1 wrote: >>>> -----Original Message----- >>>> From: Jan Beulich >>>> Sent: Monday, October 23, 2023 3:24 PM >>>> >>>> On 23.10.2023 04:57, Hu, Lin1 wrote: >>>> >>>>> -----Original Message----- >>>>> From: Jan Beulich >>>>> Sent: Thursday, September 28, 2023 5:30 PM >>>>> >>>>> On 19.09.2023 17:25, Cui, Lili wrote: >>>>>> --- a/gas/config/tc-i386.c >>>>>> +++ b/gas/config/tc-i386.c >>>>>> @@ -7091,6 +7091,46 @@ check_EgprOperands (const insn_template *t) >>>>>> return 0; >>>>>> } >>>>>> >>>>>> +/* Optimize APX NDD insns to non-NDD insns. */ >>>>>> + >>>>>> +static int >>>>> >>>>> "bool" please when the function merely returns a yes/no indicator. >>>>> >>>>> * Have modified. >>>>> >>>>>> +optimize_NDD_to_nonNDD (const insn_template *t) { >>>>>> + if (t->opcode_modifier.vexvvvv >>>>>> + && t->opcode_space == SPACE_EVEXMAP4 >>>>>> + && i.reg_operands >= 2 >>>>> >>>>> See the remark near the bottom of the changes to this file: This >>>>> condition is likely insufficient, as >>>>> - further insns allowing ND may not be treated this way (CCMPscc, >>>>> CTESTscc, and one of the CFCMOVcc forms at the very least), >>>>> - {nf} uses will want excluding, as it would be merely a waste of >>>>> time to try to re-match with fewer operands. >>>>> >>>>> * CCMPSCC and CTESTSCC’s vexvvvv will be false. I think one of the >>>> CFCMOVCC forms is same. >>>> >>>> By "is same" do you mean "fits the optimization pattern here"? >>>> >>> >>> Because I didn't find any insn that allowing ND, but its vexvvvv is true in >> CFCMOVcc's table. I'm going to assume that you found it, but I don't see it. I >> believe its vexvvvv is false, too. So I say it is same as CCMPSCC and CTESTSCC. >> >> CFCMOVcc permits ND and uses EVEX.vvvv in one of its forms. It's unclear to me >> whether it can be "optimized", though. In any event, I'd like to revisit the >> condition here once this patch comes after all functional ones, so we (I) have a >> clear picture of how all the insns are represented in the opcode table. > > Oh, you are right. It seems that CFCMOVcc doesn't support this optimization from the instruction behavior. But CFCMOVcc support doesn't in this round of work. At the moment, I thinks we can use "i.has_nf && i.tm.opcode_modifier.nf" to exclude CFCMOVcc and other NF insns. Well, as said before - imo it would be best if the optimization patch came after all functional ones. Jan