From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by sourceware.org (Postfix) with ESMTPS id 012533858D38 for ; Mon, 22 Apr 2024 08:42:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 012533858D38 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 012533858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::330 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713775367; cv=none; b=JzimCR1tSacUd/0AgK/pQ58oWNuk/YzPEyb7wpU6Zu8PN0nvzcutZuuGgpKnNvWtYB8cP703ZmD2JMUwVvD8yTCAv7HOwBDpMf0vKq2BKFaFtPiw52TbH5pPaefXImj0Rydjyi5L1t0KYGqjPt/MBBTaeE95NML6EfLkQfhQXHE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713775367; c=relaxed/simple; bh=mM0bAFcUFcH+jNYlvUJptQ8Wz6DrBZOOGsOuru/U7o0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=x14sn257SQZ2FM1D8msHv8ASJ5gdH39k9sRxINoBXicxVBrovTZtF/Rl4A8WiuVXHYcFcAf0+44aH+yOhHaPw/Nn/CYQIZO2mA35BpnkKEn9lGy00bCWmqK1NpgfMTK+zXKBTMe7bEjyhlLA5VQgGlEkMMd+Sy3vA4giOwgm+eg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-41a7ae25d53so2168325e9.1 for ; Mon, 22 Apr 2024 01:42:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1713775364; x=1714380164; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jSdHxQkwx9vkjTqy1YNKQdGvqXVE5/j0TjT+biQVV/Q=; b=ASo+EiyPyvyQDJzGpGvds6jAolvt1AaDTIXUxdXWQt9jAQGQhgcjz6KGtTOr0nCGwB igJda17s6HQDg8rfhFMl/WSEw8ddk1JRoT1w5vuM06wnyYj61oI0hyuF1SNaAoQoD/ML eMDhmipC1pNXmEx8KnMO0oyh0zyHst8vPtWNuhX1bzwAtkBRPDvAG75KjDefCNzUrqF9 v93LUvIkHcjO2t3tjEw8k+f/Y6t18NuLmzmyOuAngmHRUmTAC08ax8SocA5O6wLZYBQK JXkZleCArS6qwyqHvOlHT/Q7+hOdC7f4z5P7W9CDXKpFtKKpUKslWe22vV+puybnS6l0 gLbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713775364; x=1714380164; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jSdHxQkwx9vkjTqy1YNKQdGvqXVE5/j0TjT+biQVV/Q=; b=XX6p7PNASvkWb5gAP3VR3tD0VaaXw6on1qD/CkznFS6Q4IdNBXXo3SRMJLHoXpkcwh ED9E0+Iin1THw/+SadWmAnno1fc/DLsD7vVdoWbTzBscJKu+vYw1odSsWV3n0J9ceyzv BZCckz7UA7VK5EdpAlfZNg/4vg3lJlgi8KFjtBzTfMpzumUWuU/GXndty1fIUZgmO9nl F4SFk7hW4pdDbn5SFdQ9MOKw3SzL0SEoKyg7MaYlLR0SQ2JWcodImfmAcWDIQUPM3plL gjguhvf+0iszgI4yci22pYmX8rdzG12hl5hkqQ7E0VBlmm7R07SRiPQEzcHjGt6H1z3Z bZgw== X-Gm-Message-State: AOJu0YxmEfXmUv61oDfQt1j6kvMv5pz3ryoDnr4UYJN5wkfYqxiISWC4 02AhM+z1Fws0pmdfxP8a5d4WB1GKRWOqnNM+LIGE6DkBkcyYxHGCrB8oAEivQw== X-Google-Smtp-Source: AGHT+IGbzO42mYRdCpnmZvHeB1oygs0xVzkIZ5R2VS6ryYxr9naZbvoDY6x+89j3GXgtD7jfCm1e2w== X-Received: by 2002:a05:600c:5111:b0:418:f307:4b83 with SMTP id o17-20020a05600c511100b00418f3074b83mr6568520wms.8.1713775364658; Mon, 22 Apr 2024 01:42:44 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id g12-20020a05600c310c00b0041a46ff5e78sm3605885wmo.38.2024.04.22.01.42.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Apr 2024 01:42:44 -0700 (PDT) Message-ID: <51ed1124-ea0f-43ab-97ef-67200958e889@suse.com> Date: Mon, 22 Apr 2024 10:42:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/Intel: SHLD/SHRD have dual meaning Content-Language: en-US To: Hongtao Liu , "Cui, Lili" Cc: Binutils , "H.J. Lu" References: <117c9c1f-795e-41f9-b582-b8477b42bebd@suse.com> <563b29cc-d3b5-45b7-b354-1ca8f3a2dcf4@suse.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3025.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 22.04.2024 09:47, Hongtao Liu wrote: > On Mon, Apr 22, 2024 at 3:44 PM Cui, Lili wrote: >>> On 22.04.2024 06:09, Hongtao Liu wrote: >>>> On Fri, Apr 19, 2024 at 5:29 PM Jan Beulich wrote: >>>>> >>>>> Since we uniformly permit D suffixes in Intel mode whenever in AT&T >>>>> mode an L suffix may be used, we need to be consistent with this. >>>> I think we need to forbid the D suffix for APX NDD SHL/SHR under Intel >>>> mode to avoid ambiguity. >>> >>> Hmm. Special casing just two insns is out of question imo (in fact that's what >>> is - unintentionally - partly happening prior to the change here). >>> > I know the suffix L is needed in AT&T mode to specify the operand > size to avoid ambiguity. > But why do we need the suffix D for Intel mode? We don't need it. But that's not just here; the vast majority of insns should never have permitted suffixes in Intel syntax. Yet here we are. And the question is what to do about it. What I've been considering in the meantime is to disallow suffixes where not needed by default, but have a command line option to restore original behavior (perhaps right away with a deprecation warning), just to allow people to get their (bogus) code to build again (or, if need be, to work around issues we might introduce, i.e. mistakenly refusing use of a suffix where one might in fact be needed). Thoughts? Jan