From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 66BA13857B80 for ; Tue, 28 Nov 2023 01:25:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 66BA13857B80 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 66BA13857B80 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701134731; cv=none; b=pT9OqBpni6FdICTRDt40MhieME94p+8KbTSOkuYdkY5A6vt0LTvLuzb/CO0L+CLg4AWbzRYIvrth98WXAxQUQtiWjMOz604Cxa2yQqyO9EZuQotBZH5w2qEUuKQIObs2ciP+/zGJs13+mMj2KCZ51zUTNPRAZ2P8JB4pInTPFBw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701134731; c=relaxed/simple; bh=Y40FxLQ8TxKbdmDnkqCtPpWkpzTvV5DzP9UXFLUTxCI=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=QFKB6jUymkXNFnJ8lG3U7z1tYiwZaqw/ZKeMQpmOcYF77AlOZ42bECHZraTja/Xwx00GAY65FegO+ag0qPq8AhkINP2c4IdVsew5m1ZWpXJZbTQXdW/GF2BVkHLJM49lzmK80r3QuII9650loBKXGQm3YGGiWmQyKq25Ct2zgy0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701134729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y40FxLQ8TxKbdmDnkqCtPpWkpzTvV5DzP9UXFLUTxCI=; b=PG6Uf0PaRcP6AzGJ8AuiOE+fF/C/8/sIue1xQ7T4fb3rbOlQJet2NGC19UI7rTY+Q8YGX5 Nv4ac3GAMJ6c57RyDXfUGj6wa07BE88z7d8hQNruOmVQoHP5aHeGrK3k9dEV1nNtw0dLnO wfLfhcJ0LjrvsF9vmuTFyKdeRx+Bhxg= Received: from mail-yb1-f199.google.com (mail-yb1-f199.google.com [209.85.219.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-227-9fllBQNaN4CoKR9Y8p-Ddg-1; Mon, 27 Nov 2023 20:25:28 -0500 X-MC-Unique: 9fllBQNaN4CoKR9Y8p-Ddg-1 Received: by mail-yb1-f199.google.com with SMTP id 3f1490d57ef6-daf6c1591d5so4479457276.1 for ; Mon, 27 Nov 2023 17:25:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701134728; x=1701739528; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Y40FxLQ8TxKbdmDnkqCtPpWkpzTvV5DzP9UXFLUTxCI=; b=ssu/Y6jxj5tmkyrBkxQAXQXGDJTNK7YPsXC3CgdKmLhv2A1CqKrbMrWy/INprJS1Ey a/z236hR4xUyYdKU05pjUsTe9f03ha/D2yMTLLR/zWbUKMu66SF6as1Ppfl1/rh61dih fPIDBzwaPjG/dcZmexMCRk/cr5RCLBYGoSx5o96GW+0u/4EwcISJghUNExxQh+DEHtR8 MOuVgXU/TqFU9v5HG2iS6+BX8IBI20WjdMy4zmDPBkukPelYtnBHAdAfyXN42pwmfxst pIw4YsJbPl/UrY98y+wJFRBAvmAD6nvd/J2NdqNxSUBH7rK4f3wEu4Oif5sXl6QHboyX ZjEg== X-Gm-Message-State: AOJu0Yzzcsq5zCj5O+853mILBmnyNNkADHzmrxjnaOECInZq3icfrlvW GpAJMTbgDOFagzl63Tiubb3JUOuzUN1FrLTskbwFKSR2AE1vrAmUk5i4mkpvZP18OEsI8wGyGhD dMoYDTTEdsk8HULbb1A== X-Received: by 2002:a25:69d2:0:b0:db4:47e1:4081 with SMTP id e201-20020a2569d2000000b00db447e14081mr13006700ybc.7.1701134728005; Mon, 27 Nov 2023 17:25:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IE+Q5zkSor3Tm4vn6EDg/q0lrR1j+tAa6lAG02NDQDRpYCSDdlsiUB1w1KGw4AUQOodCVyWpw== X-Received: by 2002:a25:69d2:0:b0:db4:47e1:4081 with SMTP id e201-20020a2569d2000000b00db447e14081mr13006685ybc.7.1701134727798; Mon, 27 Nov 2023 17:25:27 -0800 (PST) Received: from t14s.localdomain (c-76-28-97-5.hsd1.ma.comcast.net. [76.28.97.5]) by smtp.gmail.com with ESMTPSA id 10-20020a05621420ca00b0067a2749baa5sm2884033qve.60.2023.11.27.17.25.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 17:25:27 -0800 (PST) Message-ID: <523538eba8b58aa0275204c0e6b8d6203845b625.camel@redhat.com> Subject: Re: [PATCH 5/5] diagnostics: don't print annotation lines when there's no column info From: David Malcolm To: gcc-patches@gcc.gnu.org, binutils@sourceware.org Cc: Nick Clifton , Simon Sobisch Date: Mon, 27 Nov 2023 20:25:26 -0500 In-Reply-To: <20231121222019.646253-6-dmalcolm@redhat.com> References: <20231106222959.2707741-1-dmalcolm@redhat.com> <20231121222019.646253-1-dmalcolm@redhat.com> <20231121222019.646253-6-dmalcolm@redhat.com> User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 2023-11-21 at 17:20 -0500, David Malcolm wrote: > gcc/ChangeLog: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0* diagnostic-show-locus.c= c > (layout::maybe_add_location_range): > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Don't print annotation li= nes for ranges when there's no > column > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0info. > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0(selftest::test_one_liner= _no_column): New. > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0(selftest::test_diagnosti= c_show_locus_one_liner): Call it. Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Not a bugfix, but low-risk and useful for libdiagnostics, so I've taken the liberty of pushing this to gcc trunk as r14-5896-g5099525bff4f7c. Dave