From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-81592-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 7236 invoked by alias); 14 Oct 2013 11:30:53 -0000
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <binutils.sourceware.org>
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
Received: (qmail 7223 invoked by uid 89); 14 Oct 2013 11:30:53 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 14 Oct 2013 11:30:52 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9EBUnxH003449	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 14 Oct 2013 07:30:49 -0400
Received: from [10.36.6.58] (vpn1-6-58.ams2.redhat.com [10.36.6.58])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9EBUjA9004151	(version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);	Mon, 14 Oct 2013 07:30:48 -0400
Message-ID: <525BD590.5060902@redhat.com>
Date: Mon, 14 Oct 2013 11:30:00 -0000
From: nick clifton <nickc@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Firefox/24.0 SeaMonkey/2.21
MIME-Version: 1.0
To: Jan-Benedict Glaw <jbglaw@lug-owl.de>
CC: Binutils <binutils@sourceware.org>
Subject: Re: [buildrobot] readelf.c (decode_arm_unwind): Initialise addr structure
References: <20131014111943.GB27569@lug-owl.de>
In-Reply-To: <20131014111943.GB27569@lug-owl.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2013-10/txt/msg00216.txt.bz2

Hi Jan-Benedict,
>   7173   struct absaddr addr = { 0 };

*sigh*

   Is it actually needed?

No - this was to silence a false positive produced by the cppcheck tool.


> 2013-10-14  Jan-Benedict Glaw  <jbglaw@lug-owl.de>
>
> binutils/
> 	* readelf.c (decode_arm_unwind): Don't initialize `addr'.

Approved - please apply.

Cheers
   Nick