* [PATCH][ARM]Add armv7ve architecture support to gas
@ 2013-11-11 18:03 Renlin Li
2013-11-18 15:53 ` nick clifton
0 siblings, 1 reply; 4+ messages in thread
From: Renlin Li @ 2013-11-11 18:03 UTC (permalink / raw)
To: binutils; +Cc: Ramana Radhakrishnan, Marcus Shawcroft
[-- Attachment #1: Type: text/plain, Size: 1313 bytes --]
Hello all,
This patch will add new arch option armv7ve to gas. armv7ve is basically
a armv7-a architecture profile with Virtualization Extensions.
"-march=armv7ve" has the same effect as
"-march=armv7-a+virt+sec+idiv+mp" in the command line.
In the assembler code, the following configurations have the same effects:
.arch armv7ve
=====or=======
.arch armv7-a
.arch_extension idiv
.arch_extension mp
.arch_extension sec
.arch_extension virt
A small test case is also added.
This has been tested for arm-none-linux-gnueabi on the model.
Okay for trunk?
Kind regards,
Renlin Li
Add support for armv7ve to gas.
gas/ChangeLog:
2013-11-11 Renlin Li <Renlin.Li@arm.com>
* config/tc-arm.c (arm_archs): New armv7ve architecture option.
(arm_cpus): Replace ARM_ARCH_V7A_IDIV_MP_SEC_VIRT with
ARM_ARCH_V7VE for cortex-a7, cortex-a12 and cortex-a15.
(cpu_arch_ver): Likewise.
* doc/c-arm.texi: Document armv7ve.
gas/testsuite/ChangeLog:
2013-11-1 Renlin Li <Renlin.Li@arm.com>
* gas/arm/attr-march-armv7ve.d: New test case for armv7ve.
include/opcode/ChangeLog:
2013-11-11 Renlin Li <Renlin.Li@arm.com>
* arm.h (ARM_AEXT_V7VE): New define.
(ARM_ARCH_V7VE): New define.
(ARM_ARCH_V7A_IDIV_MP_SEC_VIRT): Removed.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gas.diff --]
[-- Type: text/x-patch; name=gas.diff, Size: 4757 bytes --]
diff --git a/gas/config/tc-arm.c b/gas/config/tc-arm.c
index f97c307..08b5ea2 100644
--- a/gas/config/tc-arm.c
+++ b/gas/config/tc-arm.c
@@ -23997,8 +23997,7 @@ static const struct arm_cpu_option_table arm_cpus[] =
ARM_CPU_OPT ("arm1176jzf-s", ARM_ARCH_V6ZK, FPU_ARCH_VFP_V2, NULL),
ARM_CPU_OPT ("cortex-a5", ARM_ARCH_V7A_MP_SEC,
FPU_NONE, "Cortex-A5"),
- ARM_CPU_OPT ("cortex-a7", ARM_ARCH_V7A_IDIV_MP_SEC_VIRT,
- FPU_ARCH_NEON_VFP_V4,
+ ARM_CPU_OPT ("cortex-a7", ARM_ARCH_V7VE, FPU_ARCH_NEON_VFP_V4,
"Cortex-A7"),
ARM_CPU_OPT ("cortex-a8", ARM_ARCH_V7A_SEC,
ARM_FEATURE (0, FPU_VFP_V3
@@ -24008,11 +24007,9 @@ static const struct arm_cpu_option_table arm_cpus[] =
ARM_FEATURE (0, FPU_VFP_V3
| FPU_NEON_EXT_V1),
"Cortex-A9"),
- ARM_CPU_OPT ("cortex-a12", ARM_ARCH_V7A_IDIV_MP_SEC_VIRT,
- FPU_ARCH_NEON_VFP_V4,
+ ARM_CPU_OPT ("cortex-a12", ARM_ARCH_V7VE, FPU_ARCH_NEON_VFP_V4,
"Cortex-A12"),
- ARM_CPU_OPT ("cortex-a15", ARM_ARCH_V7A_IDIV_MP_SEC_VIRT,
- FPU_ARCH_NEON_VFP_V4,
+ ARM_CPU_OPT ("cortex-a15", ARM_ARCH_V7VE, FPU_ARCH_NEON_VFP_V4,
"Cortex-A15"),
ARM_CPU_OPT ("cortex-a53", ARM_ARCH_V8A, FPU_ARCH_CRYPTO_NEON_VFP_ARMV8,
"Cortex-A53"),
@@ -24093,6 +24090,7 @@ static const struct arm_arch_option_table arm_archs[] =
/* The official spelling of the ARMv7 profile variants is the dashed form.
Accept the non-dashed form for compatibility with old toolchains. */
ARM_ARCH_OPT ("armv7a", ARM_ARCH_V7A, FPU_ARCH_VFP),
+ ARM_ARCH_OPT ("armv7ve", ARM_ARCH_V7VE, FPU_ARCH_VFP),
ARM_ARCH_OPT ("armv7r", ARM_ARCH_V7R, FPU_ARCH_VFP),
ARM_ARCH_OPT ("armv7m", ARM_ARCH_V7M, FPU_ARCH_VFP),
ARM_ARCH_OPT ("armv7-a", ARM_ARCH_V7A, FPU_ARCH_VFP),
@@ -24672,7 +24670,7 @@ static const cpu_arch_ver_table cpu_arch_ver[] =
{11, ARM_ARCH_V6M},
{12, ARM_ARCH_V6SM},
{8, ARM_ARCH_V6T2},
- {10, ARM_ARCH_V7A_IDIV_MP_SEC_VIRT},
+ {10, ARM_ARCH_V7VE},
{10, ARM_ARCH_V7R},
{10, ARM_ARCH_V7M},
{14, ARM_ARCH_V8A},
diff --git a/gas/doc/c-arm.texi b/gas/doc/c-arm.texi
index 37756a0..b4b2d95 100644
--- a/gas/doc/c-arm.texi
+++ b/gas/doc/c-arm.texi
@@ -200,6 +200,7 @@ names are recognized:
@code{armv6s-m},
@code{armv7},
@code{armv7-a},
+@code{armv7ve},
@code{armv7-r},
@code{armv7-m},
@code{armv7e-m},
diff --git a/gas/testsuite/gas/arm/attr-march-armv7ve.d b/gas/testsuite/gas/arm/attr-march-armv7ve.d
new file mode 100644
index 0000000..604183f
--- /dev/null
+++ b/gas/testsuite/gas/arm/attr-march-armv7ve.d
@@ -0,0 +1,17 @@
+# name: attributes for -march=armv7ve
+# source: blank.s
+# as: -march=armv7ve
+# readelf: -A
+# This test is only valid on EABI based ports.
+# target: *-*-*eabi* *-*-nacl*
+
+Attribute Section: aeabi
+File Attributes
+ Tag_CPU_name: "7VE"
+ Tag_CPU_arch: v7
+ Tag_CPU_arch_profile: Application
+ Tag_ARM_ISA_use: Yes
+ Tag_THUMB_ISA_use: Thumb-2
+ Tag_MPextension_use: Allowed
+ Tag_DIV_use: Allowed in v7-A with integer division extension
+ Tag_Virtualization_use: TrustZone and Virtualization Extensions
diff --git a/include/opcode/arm.h b/include/opcode/arm.h
index 851fd3c..b7e4cca 100644
--- a/include/opcode/arm.h
+++ b/include/opcode/arm.h
@@ -116,6 +116,8 @@
#define ARM_AEXT_V6ZKT2 (ARM_AEXT_V6T2 | ARM_EXT_V6K | ARM_EXT_SEC)
#define ARM_AEXT_V7_ARM (ARM_AEXT_V6KT2 | ARM_EXT_V7 | ARM_EXT_BARRIER)
#define ARM_AEXT_V7A (ARM_AEXT_V7_ARM | ARM_EXT_V7A)
+#define ARM_AEXT_V7VE (ARM_AEXT_V7A | ARM_EXT_DIV | ARM_EXT_ADIV \
+ | ARM_EXT_VIRT | ARM_EXT_SEC | ARM_EXT_MP)
#define ARM_AEXT_V7R (ARM_AEXT_V7_ARM | ARM_EXT_V7R | ARM_EXT_DIV)
#define ARM_AEXT_NOTM \
(ARM_AEXT_V4 | ARM_EXT_V5ExP | ARM_EXT_V5J | ARM_EXT_V6_NOTM \
@@ -224,6 +226,7 @@
#define ARM_ARCH_V6SM ARM_FEATURE (ARM_AEXT_V6SM, 0)
#define ARM_ARCH_V7 ARM_FEATURE (ARM_AEXT_V7, 0)
#define ARM_ARCH_V7A ARM_FEATURE (ARM_AEXT_V7A, 0)
+#define ARM_ARCH_V7VE ARM_FEATURE (ARM_AEXT_V7VE, 0)
#define ARM_ARCH_V7R ARM_FEATURE (ARM_AEXT_V7R, 0)
#define ARM_ARCH_V7M ARM_FEATURE (ARM_AEXT_V7M, 0)
#define ARM_ARCH_V7EM ARM_FEATURE (ARM_AEXT_V7EM, 0)
@@ -241,11 +244,6 @@
#define ARM_ARCH_V7A_MP_SEC \
ARM_FEATURE (ARM_AEXT_V7A | ARM_EXT_MP | ARM_EXT_SEC, \
0)
-/* v7-a+idiv+mp+sec+virt. */
-#define ARM_ARCH_V7A_IDIV_MP_SEC_VIRT \
- ARM_FEATURE (ARM_AEXT_V7A | ARM_EXT_MP | ARM_EXT_SEC \
- | ARM_EXT_DIV | ARM_EXT_ADIV \
- | ARM_EXT_VIRT, 0)
/* v7-r+idiv. */
#define ARM_ARCH_V7R_IDIV ARM_FEATURE (ARM_AEXT_V7R | ARM_EXT_ADIV, 0)
/* Features that are present in v6M and v6S-M but not other v6 cores. */
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][ARM]Add armv7ve architecture support to gas
2013-11-11 18:03 [PATCH][ARM]Add armv7ve architecture support to gas Renlin Li
@ 2013-11-18 15:53 ` nick clifton
2013-11-18 16:39 ` Ramana Radhakrishnan
0 siblings, 1 reply; 4+ messages in thread
From: nick clifton @ 2013-11-18 15:53 UTC (permalink / raw)
To: Renlin Li, binutils; +Cc: Ramana Radhakrishnan, Marcus Shawcroft
Hi Renlin,
> gas/ChangeLog:
>
> 2013-11-11 Renlin Li <Renlin.Li@arm.com>
>
> * config/tc-arm.c (arm_archs): New armv7ve architecture option.
> (arm_cpus): Replace ARM_ARCH_V7A_IDIV_MP_SEC_VIRT with
> ARM_ARCH_V7VE for cortex-a7, cortex-a12 and cortex-a15.
> (cpu_arch_ver): Likewise.
> * doc/c-arm.texi: Document armv7ve.
>
> gas/testsuite/ChangeLog:
>
> 2013-11-1 Renlin Li <Renlin.Li@arm.com>
> * gas/arm/attr-march-armv7ve.d: New test case for armv7ve.
>
> include/opcode/ChangeLog:
>
> 2013-11-11 Renlin Li <Renlin.Li@arm.com>
> * arm.h (ARM_AEXT_V7VE): New define.
> (ARM_ARCH_V7VE): New define.
> (ARM_ARCH_V7A_IDIV_MP_SEC_VIRT): Removed.
Approved - please apply.
Cheers
Nick
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][ARM]Add armv7ve architecture support to gas
2013-11-18 15:53 ` nick clifton
@ 2013-11-18 16:39 ` Ramana Radhakrishnan
2013-11-18 16:42 ` Tristan Gingold
0 siblings, 1 reply; 4+ messages in thread
From: Ramana Radhakrishnan @ 2013-11-18 16:39 UTC (permalink / raw)
To: nick clifton; +Cc: Renlin Li, binutils, Marcus Shawcroft, gingold
On 11/18/13 15:50, nick clifton wrote:
> Hi Renlin,
>> gas/ChangeLog:
>>
>> 2013-11-11 Renlin Li <Renlin.Li@arm.com>
>>
>> * config/tc-arm.c (arm_archs): New armv7ve architecture option.
>> (arm_cpus): Replace ARM_ARCH_V7A_IDIV_MP_SEC_VIRT with
>> ARM_ARCH_V7VE for cortex-a7, cortex-a12 and cortex-a15.
>> (cpu_arch_ver): Likewise.
>> * doc/c-arm.texi: Document armv7ve.
>>
>> gas/testsuite/ChangeLog:
>>
>> 2013-11-1 Renlin Li <Renlin.Li@arm.com>
>> * gas/arm/attr-march-armv7ve.d: New test case for armv7ve.
>>
>> include/opcode/ChangeLog:
>>
>> 2013-11-11 Renlin Li <Renlin.Li@arm.com>
>> * arm.h (ARM_AEXT_V7VE): New define.
>> (ARM_ARCH_V7VE): New define.
>> (ARM_ARCH_V7A_IDIV_MP_SEC_VIRT): Removed.
>
> Approved - please apply.
>
Can we also get this into 2.24 for ARM / AArch32 ? I know we are a bit
late but I'd like this to go into 2.24 if possible please.
Ramana
> Cheers
> Nick
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][ARM]Add armv7ve architecture support to gas
2013-11-18 16:39 ` Ramana Radhakrishnan
@ 2013-11-18 16:42 ` Tristan Gingold
0 siblings, 0 replies; 4+ messages in thread
From: Tristan Gingold @ 2013-11-18 16:42 UTC (permalink / raw)
To: Ramana Radhakrishnan; +Cc: nick clifton, Renlin Li, binutils, Marcus Shawcroft
On Nov 18, 2013, at 5:39 PM, Ramana Radhakrishnan <ramrad01@arm.com> wrote:
> On 11/18/13 15:50, nick clifton wrote:
>> Hi Renlin,
>>> gas/ChangeLog:
>>>
>>> 2013-11-11 Renlin Li <Renlin.Li@arm.com>
>>>
>>> * config/tc-arm.c (arm_archs): New armv7ve architecture option.
>>> (arm_cpus): Replace ARM_ARCH_V7A_IDIV_MP_SEC_VIRT with
>>> ARM_ARCH_V7VE for cortex-a7, cortex-a12 and cortex-a15.
>>> (cpu_arch_ver): Likewise.
>>> * doc/c-arm.texi: Document armv7ve.
>>>
>>> gas/testsuite/ChangeLog:
>>>
>>> 2013-11-1 Renlin Li <Renlin.Li@arm.com>
>>> * gas/arm/attr-march-armv7ve.d: New test case for armv7ve.
>>>
>>> include/opcode/ChangeLog:
>>>
>>> 2013-11-11 Renlin Li <Renlin.Li@arm.com>
>>> * arm.h (ARM_AEXT_V7VE): New define.
>>> (ARM_ARCH_V7VE): New define.
>>> (ARM_ARCH_V7A_IDIV_MP_SEC_VIRT): Removed.
>>
>> Approved - please apply.
>>
>
> Can we also get this into 2.24 for ARM / AArch32 ? I know we are a bit late but I'd like this to go into 2.24 if possible
> please.
Ok for 2.24
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-11-18 16:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-11 18:03 [PATCH][ARM]Add armv7ve architecture support to gas Renlin Li
2013-11-18 15:53 ` nick clifton
2013-11-18 16:39 ` Ramana Radhakrishnan
2013-11-18 16:42 ` Tristan Gingold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).