public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH, LD, AArch64] Move ELF options behind -z
@ 2019-04-16 12:40 Sudakshina Das
  2019-06-05 10:11 ` Sudakshina Das
  0 siblings, 1 reply; 3+ messages in thread
From: Sudakshina Das @ 2019-04-16 12:40 UTC (permalink / raw)
  To: binutils; +Cc: nd, nickc, Richard Earnshaw, Ramana Radhakrishnan, H.J. Lu

[-- Attachment #1: Type: text/plain, Size: 1530 bytes --]

Hi

This patch moves the current AArch64 ld options of --force-bti and 
--pac-plt to -z force-bti and -z pac-plt since these are ELF specific 
options.

Build and regression tested on aarch64-none-linux-gnu.
Is this ok for trunk?

Sudi

*** bfd/ChangeLog ***

2019-xx-xx  Sudakshina Das  <sudi.das@arm.com>

	* bfd-in.h: Change comment.
	* bfd-in2.h: Regenerate.
	* elfnn-aarch64.c (elfNN_aarch64_merge_gnu_properties): Update warning.
	* elfxx-aarch64.c (_bfd_aarch64_elf_link_setup_gnu_properties):
	Likwise.

*** ld/ChangeLog ***

2019-xx-xx  Sudakshina Das  <sudi.das@arm.com>

	* NEWS: Update options names.
	* emultempl/aarch64elf.em (OPTION_FORCE_BTI, OPTION_PAC_PLT): Remove.
	(PARSE_AND_LIST_LONGOPTS): Remove force-bti and pac-plt.
	(PARSE_AND_LIST_OPTIONS): Update to -z.
	(PARSE_AND_LIST_ARGS_CASE_Z_AARCH64): New.
	(PARSE_AND_LIST_ARGS_CASE_Z): Add PARSE_AND_LIST_ARGS_CASE_Z_AARCH64.
	(PARSE_AND_LIST_ARGS_CASES): Move cases for these options.
	* testsuite/ld-aarch64/bti-pac-plt-1.d: Update option.
	* testsuite/ld-aarch64/bti-pac-plt-2.d: Likewise.
	* testsuite/ld-aarch64/bti-plt-1.d: Likewise.
	* testsuite/ld-aarch64/bti-plt-2.d: Likewise.
	* testsuite/ld-aarch64/bti-plt-3.d: Likewise.
	* testsuite/ld-aarch64/bti-plt-4.d: Likewise.
	* testsuite/ld-aarch64/bti-plt-6.d: Likewise.
	* testsuite/ld-aarch64/bti-plt-7.d: Likewise.
	* testsuite/ld-aarch64/bti-warn.d: Likewise.
	* testsuite/ld-aarch64/pac-plt-1.d: Likewise.
	* testsuite/ld-aarch64/pac-plt-2.d: Likewise.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: rb11090.patch --]
[-- Type: text/x-patch; name="rb11090.patch", Size: 12825 bytes --]

diff --git a/bfd/bfd-in.h b/bfd/bfd-in.h
index b753a9e57c11049a519cbb2b4ab9ef16473db52c..c9ce798afbbc22f2670bd0450c9636b1606fb636 100644
--- a/bfd/bfd-in.h
+++ b/bfd/bfd-in.h
@@ -1014,7 +1014,7 @@ typedef enum
 typedef enum
 {
   BTI_NONE	= 0,  /* BTI is not enabled.  */
-  BTI_WARN	= 1,  /* BTI is enabled with --force-bti.  */
+  BTI_WARN	= 1,  /* BTI is enabled with -z force-bti.  */
 } aarch64_enable_bti_type;
 
 /* A structure to encompass all information coming from BTI or PAC
diff --git a/bfd/bfd-in2.h b/bfd/bfd-in2.h
index 33a29406ae3f4786e1ccb727e29736c2179f122c..e2584f2df55ef8b7e09a0abbd85683ae7ab53e19 100644
--- a/bfd/bfd-in2.h
+++ b/bfd/bfd-in2.h
@@ -1021,7 +1021,7 @@ typedef enum
 typedef enum
 {
   BTI_NONE	= 0,  /* BTI is not enabled.  */
-  BTI_WARN	= 1,  /* BTI is enabled with --force-bti.  */
+  BTI_WARN	= 1,  /* BTI is enabled with -z force-bti.  */
 } aarch64_enable_bti_type;
 
 /* A structure to encompass all information coming from BTI or PAC
diff --git a/bfd/elfnn-aarch64.c b/bfd/elfnn-aarch64.c
index e82822ba6feffce649b6256667762ca7ed2ef44e..dacf48511ccb5c4694a9cce1a7c2260b28d26bca 100644
--- a/bfd/elfnn-aarch64.c
+++ b/bfd/elfnn-aarch64.c
@@ -9934,14 +9934,14 @@ elfNN_aarch64_merge_gnu_properties (struct bfd_link_info *info,
       if ((aprop && !(aprop->u.number & GNU_PROPERTY_AARCH64_FEATURE_1_BTI))
 	   || !aprop)
 	{
-	  _bfd_error_handler (_("%pB: warning: BTI turned on by --force-bti when "
+	  _bfd_error_handler (_("%pB: warning: BTI turned on by -z force-bti when "
 				"all inputs do not have BTI in NOTE section."),
 			      abfd);
 	}
       if ((bprop && !(bprop->u.number & GNU_PROPERTY_AARCH64_FEATURE_1_BTI))
 	   || !bprop)
 	{
-	  _bfd_error_handler (_("%pB: warning: BTI turned on by --force-bti when "
+	  _bfd_error_handler (_("%pB: warning: BTI turned on by -z force-bti when "
 				"all inputs do not have BTI in NOTE section."),
 			      bbfd);
 	}
diff --git a/bfd/elfxx-aarch64.c b/bfd/elfxx-aarch64.c
index d16f2ecc1ff53f6667993162bcd2d69889ec2585..12490080351966a4c0cbb5ea98a98ca6c6e0bf25 100644
--- a/bfd/elfxx-aarch64.c
+++ b/bfd/elfxx-aarch64.c
@@ -721,7 +721,7 @@ _bfd_aarch64_elf_link_setup_gnu_properties (struct bfd_link_info *info,
 				    4);
       if (gnu_prop & GNU_PROPERTY_AARCH64_FEATURE_1_BTI
 	  && !(prop->u.number & GNU_PROPERTY_AARCH64_FEATURE_1_BTI))
-	    _bfd_error_handler (_("%pB: warning: BTI turned on by --force-bti "
+	    _bfd_error_handler (_("%pB: warning: BTI turned on by -z force-bti "
 				  "when all inputs do not have BTI in NOTE "
 				  "section."), ebfd);
       prop->u.number |= gnu_prop;
diff --git a/ld/NEWS b/ld/NEWS
index 597845a351f3dac787579cf43b4d9056ea373bb3..7c7118e5dfa869ff75fc46f691691d257fe787b9 100644
--- a/ld/NEWS
+++ b/ld/NEWS
@@ -10,11 +10,11 @@ Changes in 2.33:
 * Add support for GNU_PROPERTY_AARCH64_FEATURE_1_PAC in ELF GNU program
   properties in the AArch64 ELF linker.
 
-* Add --force-bti for AArch64 to enable GNU_PROPERTY_AARCH64_FEATURE_1_BTI
+* Add -z force-bti for AArch64 to enable GNU_PROPERTY_AARCH64_FEATURE_1_BTI
   on output while warning about missing GNU_PROPERTY_AARCH64_FEATURE_1_BTI
   on inputs and use PLTs protected with BTI.
 
-* Add --pac-plt for AArch64 to pick PAC enabled PLTs.
+* Add -z pac-plt for AArch64 to pick PAC enabled PLTs.
 
 Changes in 2.32:
 
diff --git a/ld/emultempl/aarch64elf.em b/ld/emultempl/aarch64elf.em
index bfe8d1b179230a6ba32be42b2105180f4cd72446..e4ef1a87a75ab90ca6269815932b77e3229f2d7f 100644
--- a/ld/emultempl/aarch64elf.em
+++ b/ld/emultempl/aarch64elf.em
@@ -372,8 +372,6 @@ PARSE_AND_LIST_PROLOGUE='
 #define OPTION_FIX_ERRATUM_835769	313
 #define OPTION_FIX_ERRATUM_843419	314
 #define OPTION_NO_APPLY_DYNAMIC_RELOCS	315
-#define OPTION_FORCE_BTI		316
-#define OPTION_PAC_PLT			317
 '
 
 PARSE_AND_LIST_SHORTOPTS=p
@@ -387,8 +385,6 @@ PARSE_AND_LIST_LONGOPTS='
   { "fix-cortex-a53-835769", no_argument, NULL, OPTION_FIX_ERRATUM_835769},
   { "fix-cortex-a53-843419", no_argument, NULL, OPTION_FIX_ERRATUM_843419},
   { "no-apply-dynamic-relocs", no_argument, NULL, OPTION_NO_APPLY_DYNAMIC_RELOCS},
-  { "force-bti", no_argument, NULL, OPTION_FORCE_BTI},
-  { "pac-plt", no_argument, NULL, OPTION_PAC_PLT},
 '
 
 PARSE_AND_LIST_OPTIONS='
@@ -409,10 +405,21 @@ PARSE_AND_LIST_OPTIONS='
   fprintf (file, _("  --fix-cortex-a53-835769      Fix erratum 835769\n"));
   fprintf (file, _("  --fix-cortex-a53-843419      Fix erratum 843419\n"));
   fprintf (file, _("  --no-apply-dynamic-relocs    Do not apply link-time values for dynamic relocations\n"));
-  fprintf (file, _("  --force-bti                  Turn on Branch Target Identification mechanism and generate PLTs with BTI. Generate warnings for missing BTI on inputs\n"));
-  fprintf (file, _("  --pac-plt                    Protect PLTs with Pointer Authentication.\n"));
+  fprintf (file, _("  -z force-bti                  Turn on Branch Target Identification mechanism and generate PLTs with BTI. Generate warnings for missing BTI on inputs\n"));
+  fprintf (file, _("  -z pac-plt                    Protect PLTs with Pointer Authentication.\n"));
 '
 
+PARSE_AND_LIST_ARGS_CASE_Z_AARCH64='
+      else if (strcmp (optarg, "force-bti") == 0)
+	{
+	  plt_type |= PLT_BTI;
+	  bti_type = BTI_WARN;
+	}
+      else if (strcmp (optarg, "pac-plt") == 0)
+	plt_type |= PLT_PAC;
+'
+PARSE_AND_LIST_ARGS_CASE_Z="$PARSE_AND_LIST_ARGS_CASE_Z $PARSE_AND_LIST_ARGS_CASE_Z_AARCH64"
+
 PARSE_AND_LIST_ARGS_CASES='
     case '\'p\'':
       /* Only here for backwards compatibility.  */
@@ -442,15 +449,6 @@ PARSE_AND_LIST_ARGS_CASES='
       no_apply_dynamic_relocs = 1;
       break;
 
-    case OPTION_FORCE_BTI:
-      plt_type |= PLT_BTI;
-      bti_type = BTI_WARN;
-      break;
-
-    case OPTION_PAC_PLT:
-      plt_type |= PLT_PAC;
-      break;
-
     case OPTION_STUBGROUP_SIZE:
       {
 	const char *end;
diff --git a/ld/testsuite/ld-aarch64/bti-pac-plt-1.d b/ld/testsuite/ld-aarch64/bti-pac-plt-1.d
index 1ac280665e7c918bcf22853a21bd0a2ecae25d02..e1c6eb7f25d6b9e536f511cd5635d41b3247e48e 100644
--- a/ld/testsuite/ld-aarch64/bti-pac-plt-1.d
+++ b/ld/testsuite/ld-aarch64/bti-pac-plt-1.d
@@ -1,6 +1,6 @@
 #source: bti-plt-1.s
 #as: -mabi=lp64
-#ld: -shared --force-bti --pac-plt -T bti-plt.ld
+#ld: -shared -z force-bti -z pac-plt -T bti-plt.ld
 #objdump: -dr -j .plt
 
 [^:]*: *file format elf64-.*aarch64
diff --git a/ld/testsuite/ld-aarch64/bti-pac-plt-2.d b/ld/testsuite/ld-aarch64/bti-pac-plt-2.d
index e0ac1df1a57e4389866655c25532d97583bbf28d..0c67615ac41c8370acc331957a422eedda35157e 100644
--- a/ld/testsuite/ld-aarch64/bti-pac-plt-2.d
+++ b/ld/testsuite/ld-aarch64/bti-pac-plt-2.d
@@ -1,6 +1,6 @@
 #source: bti-plt-1.s
 #as: -mabi=lp64
-#ld: --force-bti --pac-plt -e _start -T bti-plt.ld -L./tmpdir -lbti-plt-so
+#ld: -z force-bti -z pac-plt -e _start -T bti-plt.ld -L./tmpdir -lbti-plt-so
 #objdump: -dr -j .plt
 
 [^:]*: *file format elf64-.*aarch64
diff --git a/ld/testsuite/ld-aarch64/bti-plt-1.d b/ld/testsuite/ld-aarch64/bti-plt-1.d
index 618a6a9c15395bf786fd8c60f4569f97d78fcc13..f8414a0164546528bcc5f1adb748e963858f10af 100644
--- a/ld/testsuite/ld-aarch64/bti-plt-1.d
+++ b/ld/testsuite/ld-aarch64/bti-plt-1.d
@@ -1,7 +1,7 @@
-#name: Check --force-bti emits BTI PLT (shared)
+#name: Check -z force-bti emits BTI PLT (shared)
 #source: bti-plt-1.s
 #as: -mabi=lp64
-#ld: -shared --force-bti -T bti-plt.ld
+#ld: -shared -z force-bti -T bti-plt.ld
 #objdump: -dr -j .plt
 
 [^:]*: *file format elf64-.*aarch64
diff --git a/ld/testsuite/ld-aarch64/bti-plt-2.d b/ld/testsuite/ld-aarch64/bti-plt-2.d
index c26e47a34f1109e061da1e0c760830db6dd5028a..bddefe9fc929a1fe0b51cf4a394a95551b9e67bc 100644
--- a/ld/testsuite/ld-aarch64/bti-plt-2.d
+++ b/ld/testsuite/ld-aarch64/bti-plt-2.d
@@ -1,8 +1,8 @@
-#name: Check --force-bti emits BTI feature (shared)
+#name: Check -z force-bti emits BTI feature (shared)
 #source: bti-plt-1.s
 #source: bti-plt-2.s
 #as: -mabi=lp64
-#ld: -shared --force-bti -T bti-plt.ld
+#ld: -shared -z force-bti -T bti-plt.ld
 #readelf: -n
 
 Displaying notes found in: .note.gnu.property
diff --git a/ld/testsuite/ld-aarch64/bti-plt-3.d b/ld/testsuite/ld-aarch64/bti-plt-3.d
index 08914deb87526dd4e1699fb062a4486638d4c058..82f08a9869edb2dcd946f30da64aec9ccaed482d 100644
--- a/ld/testsuite/ld-aarch64/bti-plt-3.d
+++ b/ld/testsuite/ld-aarch64/bti-plt-3.d
@@ -1,7 +1,7 @@
-#name: Check --force-bti emits BTI PLT (exec)
+#name: Check -z force-bti emits BTI PLT (exec)
 #source: bti-plt-1.s
 #as: -mabi=lp64
-#ld: --force-bti -e _start -T bti-plt.ld -L./tmpdir -lbti-plt-so
+#ld: -z force-bti -e _start -T bti-plt.ld -L./tmpdir -lbti-plt-so
 #objdump: -dr -j .plt
 
 [^:]*: *file format elf64-.*aarch64
diff --git a/ld/testsuite/ld-aarch64/bti-plt-4.d b/ld/testsuite/ld-aarch64/bti-plt-4.d
index 90aeed2d7bb9629216dad794fd08910b2f5ba7e7..936c24dbf72ac022c0368a474d82e44c6e484786 100644
--- a/ld/testsuite/ld-aarch64/bti-plt-4.d
+++ b/ld/testsuite/ld-aarch64/bti-plt-4.d
@@ -1,7 +1,7 @@
-#name: Check --force-bti emits BTI feature (exec)
+#name: Check -z force-bti emits BTI feature (exec)
 #source: bti-plt-1.s
 #as: -mabi=lp64
-#ld: --force-bti -e _start -T bti-plt.ld -L./tmpdir -lbti-plt-so
+#ld: -z force-bti -e _start -T bti-plt.ld -L./tmpdir -lbti-plt-so
 #readelf: -n
 
 Displaying notes found in: .note.gnu.property
diff --git a/ld/testsuite/ld-aarch64/bti-plt-6.d b/ld/testsuite/ld-aarch64/bti-plt-6.d
index 30d225d4dec80ab454da15787023a1096c73606b..27958c5d9525d4f3c12abbc1399c89a3045186b7 100644
--- a/ld/testsuite/ld-aarch64/bti-plt-6.d
+++ b/ld/testsuite/ld-aarch64/bti-plt-6.d
@@ -2,8 +2,8 @@
 #source: property-bti-pac2.s
 #source: property-bti-pac1.s
 #as: -mabi=lp64 -defsym __property_pac__=1
-#ld: -shared --force-bti
-#warning: .*property-bti-pac2.*: warning: BTI turned on by --force-bti.*$
+#ld: -shared -z force-bti
+#warning: .*property-bti-pac2.*: warning: BTI turned on by -z force-bti.*$
 #readelf: -n
 
 # Should warn about the missing input BTI NOTE but should
diff --git a/ld/testsuite/ld-aarch64/bti-plt-7.d b/ld/testsuite/ld-aarch64/bti-plt-7.d
index e8fa0d3a09163bae08d87620c718b5c765462b32..644290adacb22780844ee3794d97897508bf493c 100644
--- a/ld/testsuite/ld-aarch64/bti-plt-7.d
+++ b/ld/testsuite/ld-aarch64/bti-plt-7.d
@@ -2,9 +2,9 @@
 #source: property-bti-pac2.s
 #source: plt_mapping_symbol.s
 #as: -mabi=lp64
-#ld: -shared --force-bti
-#warning: .*plt_mapping_symbol.*: warning: BTI turned on by --force-bti.*
-#warning: .*property-bti-pac2.*: warning: BTI turned on by --force-bti.*
+#ld: -shared -z force-bti
+#warning: .*plt_mapping_symbol.*: warning: BTI turned on by -z force-bti.*
+#warning: .*property-bti-pac2.*: warning: BTI turned on by -z force-bti.*
 #readelf: -n
 
 # Should warn about the missing input BTI NOTE but should
diff --git a/ld/testsuite/ld-aarch64/bti-warn.d b/ld/testsuite/ld-aarch64/bti-warn.d
index c2edccf15f11ee06c09143b763837dbb950ba946..f22fd60cbd571042332cab6f3574965e8ef60249 100644
--- a/ld/testsuite/ld-aarch64/bti-warn.d
+++ b/ld/testsuite/ld-aarch64/bti-warn.d
@@ -2,9 +2,9 @@
 #source: property-bti-pac2.s
 #source: bti-plt-1.s
 #as: -mabi=lp64 --defsym __guard_property_bti__=1 --defsym __property_pac__=1
-#ld: -shared --force-bti
-#warning: .*property-bti-pac2.*: warning: BTI turned on by --force-bti.*
-#warning: .*bti-plt-1.*: warning: BTI turned on by --force-bti.*
+#ld: -shared -z force-bti
+#warning: .*property-bti-pac2.*: warning: BTI turned on by -z force-bti.*
+#warning: .*bti-plt-1.*: warning: BTI turned on by -z force-bti.*
 #readelf: -n
 
 # Should warn about the missing input BTI NOTE but should
diff --git a/ld/testsuite/ld-aarch64/pac-plt-1.d b/ld/testsuite/ld-aarch64/pac-plt-1.d
index 9c4a676cf8f68bec3815909b25e188e7194c82ed..06278ef15f706cbee55f1258c8ee732370506faa 100644
--- a/ld/testsuite/ld-aarch64/pac-plt-1.d
+++ b/ld/testsuite/ld-aarch64/pac-plt-1.d
@@ -1,6 +1,6 @@
 #source: bti-plt-1.s
 #as: -mabi=lp64 --defsym __guard_property_bti__=1
-#ld: -shared --pac-plt -T bti-plt.ld
+#ld: -shared -z pac-plt -T bti-plt.ld
 #objdump: -dr -j .plt
 
 [^:]*: *file format elf64-.*aarch64
diff --git a/ld/testsuite/ld-aarch64/pac-plt-2.d b/ld/testsuite/ld-aarch64/pac-plt-2.d
index 7ebc81d7f7ddb3c18b3cc4cc330c3e62c60a5e3f..b5cf43d3d4694564b5f653cb234b40294c968b0b 100644
--- a/ld/testsuite/ld-aarch64/pac-plt-2.d
+++ b/ld/testsuite/ld-aarch64/pac-plt-2.d
@@ -1,5 +1,5 @@
 #source: tls-desc-ie.s
-#ld: -shared --pac-plt -T bti-plt.ld
+#ld: -shared -z pac-plt -T bti-plt.ld
 #objdump: -dr -j .plt
 #...
 Disassembly of section .plt:

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH, LD, AArch64] Move ELF options behind -z
  2019-04-16 12:40 [PATCH, LD, AArch64] Move ELF options behind -z Sudakshina Das
@ 2019-06-05 10:11 ` Sudakshina Das
  2019-06-06 11:11   ` Nick Clifton
  0 siblings, 1 reply; 3+ messages in thread
From: Sudakshina Das @ 2019-06-05 10:11 UTC (permalink / raw)
  To: binutils; +Cc: nd, nickc, Richard Earnshaw, Ramana Radhakrishnan, H.J. Lu

Hi

On 16/04/2019 13:39, Sudakshina Das wrote:
> Hi
> 
> This patch moves the current AArch64 ld options of --force-bti and 
> --pac-plt to -z force-bti and -z pac-plt since these are ELF specific 
> options.
> 
> Build and regression tested on aarch64-none-linux-gnu.
> Is this ok for trunk?
> 
> Sudi

Sorry this fell off my radar.
Ping.
Depending on whether this patch or 
https://www.sourceware.org/ml/binutils/2019-06/msg00047.html gets 
approval before, I will rebase one of them. I hope that rebase does not 
need another approval.

Thanks
Sudi

> 
> *** bfd/ChangeLog ***
> 
> 2019-xx-xx  Sudakshina Das  <sudi.das@arm.com>
> 
>      * bfd-in.h: Change comment.
>      * bfd-in2.h: Regenerate.
>      * elfnn-aarch64.c (elfNN_aarch64_merge_gnu_properties): Update 
> warning.
>      * elfxx-aarch64.c (_bfd_aarch64_elf_link_setup_gnu_properties):
>      Likwise.
> 
> *** ld/ChangeLog ***
> 
> 2019-xx-xx  Sudakshina Das  <sudi.das@arm.com>
> 
>      * NEWS: Update options names.
>      * emultempl/aarch64elf.em (OPTION_FORCE_BTI, OPTION_PAC_PLT): Remove.
>      (PARSE_AND_LIST_LONGOPTS): Remove force-bti and pac-plt.
>      (PARSE_AND_LIST_OPTIONS): Update to -z.
>      (PARSE_AND_LIST_ARGS_CASE_Z_AARCH64): New.
>      (PARSE_AND_LIST_ARGS_CASE_Z): Add PARSE_AND_LIST_ARGS_CASE_Z_AARCH64.
>      (PARSE_AND_LIST_ARGS_CASES): Move cases for these options.
>      * testsuite/ld-aarch64/bti-pac-plt-1.d: Update option.
>      * testsuite/ld-aarch64/bti-pac-plt-2.d: Likewise.
>      * testsuite/ld-aarch64/bti-plt-1.d: Likewise.
>      * testsuite/ld-aarch64/bti-plt-2.d: Likewise.
>      * testsuite/ld-aarch64/bti-plt-3.d: Likewise.
>      * testsuite/ld-aarch64/bti-plt-4.d: Likewise.
>      * testsuite/ld-aarch64/bti-plt-6.d: Likewise.
>      * testsuite/ld-aarch64/bti-plt-7.d: Likewise.
>      * testsuite/ld-aarch64/bti-warn.d: Likewise.
>      * testsuite/ld-aarch64/pac-plt-1.d: Likewise.
>      * testsuite/ld-aarch64/pac-plt-2.d: Likewise.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH, LD, AArch64] Move ELF options behind -z
  2019-06-05 10:11 ` Sudakshina Das
@ 2019-06-06 11:11   ` Nick Clifton
  0 siblings, 0 replies; 3+ messages in thread
From: Nick Clifton @ 2019-06-06 11:11 UTC (permalink / raw)
  To: Sudakshina Das, binutils
  Cc: nd, Richard Earnshaw, Ramana Radhakrishnan, H.J. Lu

Hi Sudi,

>> This patch moves the current AArch64 ld options of --force-bti and 
>> --pac-plt to -z force-bti and -z pac-plt since these are ELF specific 
>> options.

> Ping.
Doh - sorry for missing this one.


>> *** bfd/ChangeLog ***
>> 2019-xx-xx  Sudakshina Das  <sudi.das@arm.com>
>>
>>      * bfd-in.h: Change comment.
>>      * bfd-in2.h: Regenerate.
>>      * elfnn-aarch64.c (elfNN_aarch64_merge_gnu_properties): Update 
>> warning.
>>      * elfxx-aarch64.c (_bfd_aarch64_elf_link_setup_gnu_properties):
>>      Likwise.
>>
>> *** ld/ChangeLog ***
> 2019-xx-xx  Sudakshina Das  <sudi.das@arm.com>
>>
>>      * NEWS: Update options names.
>>      * emultempl/aarch64elf.em (OPTION_FORCE_BTI, OPTION_PAC_PLT): Remove.
>>      (PARSE_AND_LIST_LONGOPTS): Remove force-bti and pac-plt.
>>      (PARSE_AND_LIST_OPTIONS): Update to -z.
>>      (PARSE_AND_LIST_ARGS_CASE_Z_AARCH64): New.
>>      (PARSE_AND_LIST_ARGS_CASE_Z): Add PARSE_AND_LIST_ARGS_CASE_Z_AARCH64.
>>      (PARSE_AND_LIST_ARGS_CASES): Move cases for these options.
>>      * testsuite/ld-aarch64/bti-pac-plt-1.d: Update option.
>>      * testsuite/ld-aarch64/bti-pac-plt-2.d: Likewise.
>>      * testsuite/ld-aarch64/bti-plt-1.d: Likewise.
>>      * testsuite/ld-aarch64/bti-plt-2.d: Likewise.
>>      * testsuite/ld-aarch64/bti-plt-3.d: Likewise.
>>      * testsuite/ld-aarch64/bti-plt-4.d: Likewise.
>>      * testsuite/ld-aarch64/bti-plt-6.d: Likewise.
>>      * testsuite/ld-aarch64/bti-plt-7.d: Likewise.
>>      * testsuite/ld-aarch64/bti-warn.d: Likewise.
>>      * testsuite/ld-aarch64/pac-plt-1.d: Likewise.
>>      * testsuite/ld-aarch64/pac-plt-2.d: Likewise.


Approved - please apply.

Cheers
  Nick

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-06-06 11:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-16 12:40 [PATCH, LD, AArch64] Move ELF options behind -z Sudakshina Das
2019-06-05 10:11 ` Sudakshina Das
2019-06-06 11:11   ` Nick Clifton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).