From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2055.outbound.protection.outlook.com [40.107.21.55]) by sourceware.org (Postfix) with ESMTPS id D25BB3856DFC for ; Fri, 5 May 2023 11:12:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D25BB3856DFC Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oggBHaKJfg76Kidj05qO6JBKgySdmSc3zCK8TAOeAzz1OrFfjDhMftIY4V8FokGY5v7QKZXlEShfKupTLsyRK9ZI3wVGDOTA25Janqqw8q8hxHE/WYdlx3tAH28ZASfhdMhAaG/pojqcz1u0KQA4WqcNYE685q2FzcQHrd9W2+laTWZqOTvxaXAk0ss4W4pO7NYbaV7JAclnsQonx6ZUGPfmaswZL74jmkyuEsbQn8qXCLtVi/7z0iCmbCf8ts2POf6OVnYjS3RFBYgeQeRMoo6kBHn/teLQ26mNi+iEZGwY9tjKjXgUUMDhURu9Z3UwkWJyNuaf6yUJ8ds27/uosA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O6dQ+SBl1wEt5AmmPur8aHh/x4lnqc+ZbHWbhS2SvHs=; b=NOudVJH+G+IH4s1CRFIhOUsXDtW2id2IeAGESCkImKtlAhcmsj7tpgGnE13FDfz5Sauv2iH6FBfti2/ZD6I5LIBFlcL/wcFCDbdR/zZLJqoI04pmT1mX47iAflC1sEYcHMNo7XaIVF3anKhC+61b0cgO2PMgtvk41ESi6BYE4cVJlnbnrqfvqvX1MIn9ru7eQqv+6l+gaQwF24eCcwPv4r28J6qGhHnp3L2Zi5NwQokYeVMC2tXV5mJ3bzuqQQfFXYVql55sgILVfX4ATvbfCLGolZhxSVWutBD04PwxiCPaRPAVCQBQadfBHuJ6JWSzYKYGcdz5d7QTMDcesd/IFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O6dQ+SBl1wEt5AmmPur8aHh/x4lnqc+ZbHWbhS2SvHs=; b=URdmf3Vi8ldsxkgdbNpkB2sFLpCmtJrZWTNstvgeM2F96QgNsjWDcc0WM8pY1VHttUL9i7eMJG4wuEKNH54Wk2SilD4BEkk+3vGmsajFyZqbaTBSLljxERvC8y863dcJLUL/1Vkb+wnJuGeV4yBbIDd/FoD0G064M2rY5g0QiqXgGdf15+lJKeLmgdRIg1TdCBIhjM5XwU71YQ9nihgmyHqNdiwzT9jYqwSTEj2t5pXBfbAMH/0mP5RhLQDleV/L1GCyek2+eT1ynaivpDCsg4WWBLU67fDY2VcWcVHKaOOJl7inSloc3Zxmhh6dkNFROqiFqND+721MxZ8fd7EyXw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DB9PR04MB9867.eurprd04.prod.outlook.com (2603:10a6:10:4c0::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.25; Fri, 5 May 2023 11:12:45 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::768c:6df7:9afb:acd7%7]) with mapi id 15.20.6363.027; Fri, 5 May 2023 11:12:45 +0000 Message-ID: <52d14c6e-e232-efe3-d486-06cda1c19fdf@suse.com> Date: Fri, 5 May 2023 13:12:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: [PATCH 1/2] x86: move get() disassembler helper functions Content-Language: en-US To: Binutils Cc: "H.J. Lu" References: <9369c14f-ce90-61ac-c2fd-8588c82b35a5@suse.com> From: Jan Beulich In-Reply-To: <9369c14f-ce90-61ac-c2fd-8588c82b35a5@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0187.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::15) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|DB9PR04MB9867:EE_ X-MS-Office365-Filtering-Correlation-Id: 4ad61897-47fc-466c-cf0d-08db4d59a72e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Kij2h8nxVC7VVHzdjTMoit55n7OYFrAxt/xZEuvvDwvGMpdg9WWwZ0jeIgRUFXgpFsvX1ebb0E9PcFIL+f3afgaYqeu2J4JFeEOGzD++wZkvckt3ZHsnKAlCqEHc3GNaNTQb7Duj5TGwr8ZNCafApCawKqFSjw5Y5+pQ3x3SR02dqD1CNFbj1Om1nUGQZWMG8FVLlvknf6B2Yod1Km16JNdTF5t3kAnfCPExUnq8/LRLeAaWqWlQSF003ndfoLCC0OSDIBO7pcehC3I0CgyenfCFjix3O6JymAINqpTKH0zP8527D2XogaHHWm6fH9B4wW8rLLtx5YRkipJqpT9MBmT6kBHZYWnTgongF0KNYsKysjmB2oU0vO9p9VrfRvju2+lAlxlT50T1zIFChPL5rI1rFjdDbY+UlX2CVxAD3mMpkEN/Ma4u5H+YQkSujd/jpGa2eNs35gghU83K4N6MPt+DRKxj+94jXoL8zXlrvFQU0FnHvOMzznToORmVW/myVN0SMb5T5z5/5DcGEBPzbeQOlBRM1OnswAtbUOpuxFk8KUCFFGwqAvWbeNQvINEcxj6WinIuMj5oPCNUuZHBkp54xHAwPsCddJSO2t0vARgfcMi3B8WzlJm+8yZ9Qy4aOLwaHcSsQzIku4FRvYNj5Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(39860400002)(346002)(396003)(376002)(366004)(451199021)(316002)(31686004)(6512007)(186003)(41300700001)(6486002)(31696002)(6506007)(2616005)(6916009)(66476007)(2906002)(4326008)(26005)(66946007)(66556008)(86362001)(36756003)(38100700002)(478600001)(8676002)(5660300002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y3V6cTNXdlpaR1BUd2w0MGFhQmt6Ry9DaXFVMFVsV0lTYmJzVy9IRVFoM001?= =?utf-8?B?WWJjdjM0djVjbkMyUm9WY3V6VlhzaUxXZlVLRkVlQUJlRUx4ZnpFUlVjQ1dj?= =?utf-8?B?OEtqdGh0enZ4ZVArV2lQdzRqNFVRT3c2Qm0xUExBcjZpQU9kWVQ1ZTl4Z045?= =?utf-8?B?bm1OekxDMXBmelY5NE1KQXhOTDRBV3R6dm0xcEdsV25ESDFiNER5dEdKMWdM?= =?utf-8?B?MU1wWUFLQUE3S09zWlBINzBCVXdMbjBpVkdSME9MVVpDZDBESVRuSzEyamdM?= =?utf-8?B?bFMzU2R1QXV2MGhYWC9ObmFxZk90UllMRUNRZUF3Zk9TNjFMTWtoRmJGYXlv?= =?utf-8?B?QjIxaStqNVhYVXNTOXRVdWNpWm9RS1FhTm9qUHZEcUxvZkpFZitQSWpmQlBF?= =?utf-8?B?bU1rMTlhcnlidGdQRWVkUTg2azdaQUM1RHRLSFIvd29relpZMHc5TXFmc0p1?= =?utf-8?B?VW1FVTUveEYxSnRXN0p3anF2T2JybGNNeDlobzJ1Q3Yrcm10clJtZ3psQjV2?= =?utf-8?B?RDNXZk5WbGRNMGtFRm9Mbml1dStkU09kOTQzRmROa0J2dStaRDR4UnFsMVBX?= =?utf-8?B?T0tERnlLNjByRUQrTEplRTNFME91Z0lrYUFYdFNzTTdYWWlrQ1ZRTnRXZm14?= =?utf-8?B?UVM5SXRKUDZ5U2lrU01aT2lYWWhrU0lhTTNJYjEyNXVOR2FSbTJpbnBsQ2w1?= =?utf-8?B?dHlNNHRDbVErSEp5RW53bnlvcjcreXBnWXVka2pxQ1RKZTBYZGVPZjEraUVO?= =?utf-8?B?R3d6WlVCbUJqQ3pjcThmTzBMVDMxdkN5WDh3L05mRnIyS0Q1ZUwrSzRsTjh6?= =?utf-8?B?d0gxcFN2SUJ4cUJrRG1VVThzdTlhOG51TTRFa1NRaExPUDVWZDhWWUFydTR5?= =?utf-8?B?bHlxZDNhOVRWTktvQndxQmgvVUFVT3hzakdUVEVuUmg1WHpYUFJZNnRiM1BR?= =?utf-8?B?ckEwSE0wUXZWTUMyakpyZVZ4RUlPcVpDWWlxUGtsK2I0OFZjaDlvN3hiTGRZ?= =?utf-8?B?QzVqK051U0JUa2xzeXJJZTJCTkNEVjh3OW5UM3MvMmJvUkJ3ZzRuSjFVTDBI?= =?utf-8?B?TUtMTUtsYURHUllkd1hnTCs1ZVI3byt6WWkzL21XcEJlaTZRd0RkNzNyVEtT?= =?utf-8?B?ZFpUcGh1RzdlRTdkZVZjVXZWWExpRnRQVmJ2emZvaEFCa1JwaTAyK2pUZDRW?= =?utf-8?B?dE83QWxYQ1ZFZ1Jic253am41VlZ5NC9mTWp0MlR5N1lkRVhydlRLelc1M3lC?= =?utf-8?B?VS9yV2h5dy9JZS9peE1HZmFCYXV1YkxWZG44ZnRkd2xNUTBJaVdGaXZxRHM5?= =?utf-8?B?UllyeGpkQmZDR1RVQzMxMVRGVkE5dldiYkMxQjY2ZlFqaGxxeVI5cnRnZ0Q5?= =?utf-8?B?UEN5Q0VzWnk4MmllTDlJZkhjbndPMkV0SWVDc08zMHVwblVLYVRoWGNzdWRp?= =?utf-8?B?RGR0Y0xDaGlINFc2N3M0eW1YTUU2Zko3TkNDaEUvRm9zNHRjMk1BQkRVN21z?= =?utf-8?B?Z0pHaTQ2SXIycGlSMG5relFYSlV4WnZzYktLUDEyaHorQjRseWptVTdPY0NF?= =?utf-8?B?dFEyc3pBTHVSaVhTT3M5UjNvcEJXZERIRmtzTTlhVXduRjFyWWdOeVNUeTBq?= =?utf-8?B?aXRaZm96cDlhUlRvMUQyY092OUJMcHYvUm1zL2xldHRHNmt4ZVIzSnBQZ1Qv?= =?utf-8?B?WUtlcWdsMUZWY3hqcUNOdStNd2x1cmlHTTZ3bVh2RmRnSi96cEYwTDhjZ2Js?= =?utf-8?B?U051a24zZTEvY216MUgzREp1clYxQkU4aXA5Wm53RWNrK0lOTjQ3UVlyRmlZ?= =?utf-8?B?QTRSdXZNL3lnek5QRWJCaENML0dubWd3NWh2RkZDcGd3d1NtSFpGSCtCdjFD?= =?utf-8?B?Uk0xMUNhZE9scGlMd2wyNUJ2M0ZRQlpXWGZkOHRKcTVmcGM2TndGQi94WjE3?= =?utf-8?B?N0ZJT20rRklnZWRaemVpNmovcHFkQTB6ay81VnQ5WEprV01WMmJmMVJqbEtj?= =?utf-8?B?TVFxYVZlMGorYmw2cnI1c0FndW8xN2xlaFhWNG00MWhsK3Z5cGVGQ1FBMU1s?= =?utf-8?B?bHY5dFlONFlUbHdObEVuSjV4MkNyYXNFcEZGUm5WZTc2OG03RkdoS2hHQ2kv?= =?utf-8?Q?4tsmMprTiS+BiawUkjMuyEvq+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ad61897-47fc-466c-cf0d-08db4d59a72e X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 11:12:45.6638 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MHGCHsbbvs1eLrrq0cbSfnTXVNr5wxYjo1buv6yTqp5FizIhS4ol9xo6ebfRd87AQpu4Ga9In8Ks01xCn3szDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9867 X-Spam-Status: No, score=-3028.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: ... such that none of them would need forward declarations anymore. --- a/opcodes/i386-dis.c +++ b/opcodes/i386-dis.c @@ -47,10 +47,6 @@ static void oappend_with_style (instr_in enum disassembler_style); static void oappend (instr_info *, const char *); static void append_seg (instr_info *); -static bool get32s (instr_info *, bfd_vma *); -static bool get16 (instr_info *, bfd_vma *); -static bool get16s (instr_info *, bfd_vma *); -static bool get8s (instr_info *, bfd_vma *); static void set_op (instr_info *, bfd_vma, bool); static bool OP_E (instr_info *, int, int); @@ -11715,6 +11711,77 @@ print_register (instr_info *ins, unsigne } static bool +get8s (instr_info *ins, bfd_vma *res) +{ + if (!fetch_code (ins->info, ins->codep + 1)) + return false; + *res = (((bfd_vma) *ins->codep++ & 0xff) ^ 0x80) - 0x80; + return true; +} + +static bool +get16 (instr_info *ins, bfd_vma *res) +{ + if (!fetch_code (ins->info, ins->codep + 2)) + return false; + *res = (bfd_vma) *ins->codep++ & 0xff; + *res |= ((bfd_vma) *ins->codep++ & 0xff) << 8; + return true; +} + +static bool +get16s (instr_info *ins, bfd_vma *res) +{ + if (!get16 (ins, res)) + return false; + *res = (*res ^ 0x8000) - 0x8000; + return true; +} + +static bool +get32 (instr_info *ins, bfd_vma *res) +{ + if (!fetch_code (ins->info, ins->codep + 4)) + return false; + *res = *ins->codep++ & (bfd_vma) 0xff; + *res |= (*ins->codep++ & (bfd_vma) 0xff) << 8; + *res |= (*ins->codep++ & (bfd_vma) 0xff) << 16; + *res |= (*ins->codep++ & (bfd_vma) 0xff) << 24; + return true; +} + +static bool +get32s (instr_info *ins, bfd_vma *res) +{ + if (!get32 (ins, res)) + return false; + + *res = (*res ^ ((bfd_vma) 1 << 31)) - ((bfd_vma) 1 << 31); + + return true; +} + +static bool +get64 (instr_info *ins, uint64_t *res) +{ + unsigned int a; + unsigned int b; + + if (!fetch_code (ins->info, ins->codep + 8)) + return false; + a = *ins->codep++ & 0xff; + a |= (*ins->codep++ & 0xff) << 8; + a |= (*ins->codep++ & 0xff) << 16; + a |= (*ins->codep++ & 0xffu) << 24; + b = *ins->codep++ & 0xff; + b |= (*ins->codep++ & 0xff) << 8; + b |= (*ins->codep++ & 0xff) << 16; + b |= (*ins->codep++ & 0xffu) << 24; + *res = a + ((uint64_t) b << 32); + return true; +} + +static bool OP_E_memory (instr_info *ins, int bytemode, int sizeflag) { int add = (ins->rex & REX_B) ? 8 : 0; @@ -12249,77 +12316,6 @@ OP_G (instr_info *ins, int bytemode, int return true; } -static bool -get64 (instr_info *ins, uint64_t *res) -{ - unsigned int a; - unsigned int b; - - if (!fetch_code (ins->info, ins->codep + 8)) - return false; - a = *ins->codep++ & 0xff; - a |= (*ins->codep++ & 0xff) << 8; - a |= (*ins->codep++ & 0xff) << 16; - a |= (*ins->codep++ & 0xffu) << 24; - b = *ins->codep++ & 0xff; - b |= (*ins->codep++ & 0xff) << 8; - b |= (*ins->codep++ & 0xff) << 16; - b |= (*ins->codep++ & 0xffu) << 24; - *res = a + ((uint64_t) b << 32); - return true; -} - -static bool -get32 (instr_info *ins, bfd_vma *res) -{ - if (!fetch_code (ins->info, ins->codep + 4)) - return false; - *res = *ins->codep++ & (bfd_vma) 0xff; - *res |= (*ins->codep++ & (bfd_vma) 0xff) << 8; - *res |= (*ins->codep++ & (bfd_vma) 0xff) << 16; - *res |= (*ins->codep++ & (bfd_vma) 0xff) << 24; - return true; -} - -static bool -get32s (instr_info *ins, bfd_vma *res) -{ - if (!get32 (ins, res)) - return false; - - *res = (*res ^ ((bfd_vma) 1 << 31)) - ((bfd_vma) 1 << 31); - - return true; -} - -static bool -get16 (instr_info *ins, bfd_vma *res) -{ - if (!fetch_code (ins->info, ins->codep + 2)) - return false; - *res = (bfd_vma) *ins->codep++ & 0xff; - *res |= ((bfd_vma) *ins->codep++ & 0xff) << 8; - return true; -} - -static bool -get16s (instr_info *ins, bfd_vma *res) -{ - if (!get16 (ins, res)) - return false; - *res = (*res ^ 0x8000) - 0x8000; - return true; -} - -static bool -get8s (instr_info *ins, bfd_vma *res) -{ - if (!fetch_code (ins->info, ins->codep + 1)) - return false; - *res = (((bfd_vma) *ins->codep++ & 0xff) ^ 0x80) - 0x80; - return true; -} - static void set_op (instr_info *ins, bfd_vma op, bool riprel) {