From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by sourceware.org (Postfix) with ESMTPS id 99C503854167 for ; Thu, 25 Aug 2022 06:53:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 99C503854167 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=martin.st Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=martin.st Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 27P6rRIq025585-27P6rRIr025585; Thu, 25 Aug 2022 09:53:27 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 24C0EA144B; Thu, 25 Aug 2022 09:53:26 +0300 (EEST) Date: Thu, 25 Aug 2022 09:53:25 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: Nick Clifton cc: binutils@sourceware.org Subject: Re: [PATCH v4] ld: Make archive member file extension comparisons case insensitive when cross compiling too In-Reply-To: <8451b476-1777-2fb5-74bb-042ee17aefee@redhat.com> Message-ID: <52e495-3ab8-d4cf-c9a5-bcaeac932b28@martin.st> References: <20220824082316.3213884-1-martin@martin.st> <8451b476-1777-2fb5-74bb-042ee17aefee@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-FE-Policy-ID: 3:14:2:SYSTEM X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 24 Aug 2022, Nick Clifton wrote: >> +/* A case insensitive comparison, regardless of the host platform, used >> for >> + comparing file extensions. Parameter s1 points at the extension in a >> file >> + name (pointing at the starting '.'). Parameter s2 is a lower case >> string >> + without the leading '.'. */ > > Comment formatting: two spaces before the closing */ > >> +static int fileext_cmp (const char *s1, const char *s2) > > Function name formatting - name on a separate line from the return type. > > And yes, I know that the same problem exists for the is_underscoring() > function directly before this one. A patch to fix that formatting is > pre-approved. :-) I pushed a patch that fixes this aspect now as well, for consistency. // Martin