From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58061 invoked by alias); 5 May 2017 13:21:13 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 57471 invoked by uid 89); 5 May 2017 13:21:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=Hx-languages-length:1552, secure X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 05 May 2017 13:21:11 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E0D6A2B; Fri, 5 May 2017 06:21:12 -0700 (PDT) Received: from [10.2.206.52] (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 206463F4FF; Fri, 5 May 2017 06:21:11 -0700 (PDT) Subject: Re: [PATCH, LD, ping] Make import libraries relocatable objects To: Nick Clifton , Richard Earnshaw , Alan Modra , binutils@sourceware.org References: <3f56df33-a8ee-778d-a1b8-7a91c68cc359@foss.arm.com> <8d909776-eebd-4301-8089-44eb6e43b52d@redhat.com> From: Thomas Preudhomme Message-ID: <52e50c88-4e33-fe0f-84b6-ff237848b599@foss.arm.com> Date: Fri, 05 May 2017 13:21:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <8d909776-eebd-4301-8089-44eb6e43b52d@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00072.txt.bz2 On 05/05/17 10:14, Nick Clifton wrote: > Hi Thomas, > >> Ping? > > Oops - sorry - I was assuming that one of the ARM maintainers would look at this. Actually this specific patch also needs a global reviewer because it changes the behavior of the target-independent --out-implib feature as well which is why I didn't add the ARM tag in the subject. > >>> *** bfd/ChangeLog *** >>> >>> 2017-04-25 Thomas Preud'homme >>> >>> * elflink.c (elf_output_implib): Remove executable flag from import >>> library bfd. >>> * elf32-arm.c (elf32_arm_filter_implib_symbols): Assert that the import >>> library is a relocatable object file. >>> >>> *** ld/ChangeLog *** >>> >>> 2017-04-25 Thomas Preud'homme >>> >>> * testsuite/ld-arm/arm-elf.exp >>> (Secure gateway import library generation): Check e_type field >>> of import library and executable produced. >>> * testsuite/ld-arm/cmse-implib.type: Expectations for e_type field. >>> >>> Testing: testsuite shows no regression when run for arm-none-eabi and >>> armeb-none-eabi. >>> >>> Is this ok for master? > > Approved - please apply, but, please could you make one small change: > > + BFD_ASSERT (!(bfd_get_file_flags (info->out_implib_bfd) & EXEC_P)); > > Please could you add a comment above this assert referencing the ARM ECM > document and explaining why the check is here ? Will do. Can you confirm you are happy with the target-independent change as well? Best regards, Thomas