From: Yury Gribov <y.gribov@samsung.com>
To: Hans-Peter Nilsson <hp@bitrange.com>, nick clifton <nickc@redhat.com>
Cc: Will Newton <will.newton@linaro.org>,
"binutils@sourceware.org" <binutils@sourceware.org>,
Viacheslav Garbuzov <v.garbuzov@samsung.com>,
Yuri Gribov <tetra2005@gmail.com>
Subject: Re: [RFC][PATCH] Handle arbitrary .plt/.got displacements in ld on ARM
Date: Fri, 28 Feb 2014 06:15:00 -0000 [thread overview]
Message-ID: <53102987.3000108@samsung.com> (raw)
In-Reply-To: <alpine.BSF.2.02.1402280049470.22875@arjuna.pair.com>
[-- Attachment #1: Type: text/plain, Size: 173 bytes --]
> The new test fails for arm-eabi:
Right, I only tested linux-gnueabi. Could you check whether attached
patch works for you? Gnueabi and eabi tests passed fine here.
-Y
[-- Attachment #2: long_plt_eabi_fix_1.diff --]
[-- Type: text/x-diff, Size: 1365 bytes --]
diff --git a/ld/testsuite/ld-arm/arm-elf.exp b/ld/testsuite/ld-arm/arm-elf.exp
index ec569ca..b6bde2b 100644
--- a/ld/testsuite/ld-arm/arm-elf.exp
+++ b/ld/testsuite/ld-arm/arm-elf.exp
@@ -188,7 +188,7 @@ set armelftests_common {
"" {exec-got-1b.s}
{{readelf --relocs exec-got-1.d}}
"exec-got-1"}
- {"Long PLT entries in executables" "--long-plt -shared --section-start=.plt=0x200 --section-start=.got=0xf0000300" ""
+ {"Long PLT entries in executables" "--long-plt -shared --section-start=.plt=0x1000 --section-start=.got=0xf0001100" ""
"" {long-plt-format.s}
{{objdump "-d -j .plt" long-plt-format.d}}
"long-plt-format"}
diff --git a/ld/testsuite/ld-arm/long-plt-format.d b/ld/testsuite/ld-arm/long-plt-format.d
index c08cb71..c64b42f 100644
--- a/ld/testsuite/ld-arm/long-plt-format.d
+++ b/ld/testsuite/ld-arm/long-plt-format.d
@@ -3,13 +3,13 @@
Disassembly of section .plt:
-00000200 <.plt>:
- 200: .*
- 204: .*
- 208: .*
- 20c: .*
- 210: .* .word .*
- 214: .* add ip, pc, #-268435456 ; 0xf0000000
- 218: .* add ip, ip, #0, 12
- 21c: .* add ip, ip, #0, 20
- 220: .* ldr pc, [ip, #[0-9]*]! ; 0x.*
+.* <.plt>:
+ .*: .*
+ .*: .*
+ .*: .*
+ .*: .*
+ .*: .* .word .*
+ .*: .* add ip, pc, #-268435456 ; 0xf0000000
+ .*: .* add ip, ip, #0, 12
+ .*: .* add ip, ip, #0, 20
+ .*: .* ldr pc, [ip, #[0-9]*]! ; 0x.*
next prev parent reply other threads:[~2014-02-28 6:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 10:16 Yury Gribov
2014-02-10 8:32 ` Will Newton
2014-02-10 11:52 ` Yury Gribov
2014-02-17 6:39 ` [PATCH/ARM][PING] " Yury Gribov
2014-02-24 15:09 ` [PATCH/ARM][PING^2] " Yury Gribov
2014-02-21 14:24 ` [RFC][PATCH] " nick clifton
2014-02-24 15:07 ` Yury Gribov
2014-02-25 9:02 ` nick clifton
2014-02-27 12:53 ` Yury Gribov
2014-02-27 14:42 ` nick clifton
2014-02-28 5:53 ` Hans-Peter Nilsson
2014-02-28 6:15 ` Yury Gribov [this message]
2014-02-28 19:40 ` Hans-Peter Nilsson
2014-02-28 19:57 ` Yuri Gribov
2014-03-01 11:27 ` Hans-Peter Nilsson
2014-03-02 16:10 ` Nicholas Clifton
2014-02-25 16:46 ` Richard Earnshaw
2014-02-25 18:01 ` Yuri Gribov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53102987.3000108@samsung.com \
--to=y.gribov@samsung.com \
--cc=binutils@sourceware.org \
--cc=hp@bitrange.com \
--cc=nickc@redhat.com \
--cc=tetra2005@gmail.com \
--cc=v.garbuzov@samsung.com \
--cc=will.newton@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).