From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26605 invoked by alias); 28 Feb 2014 06:15:40 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 26583 invoked by uid 89); 28 Feb 2014 06:15:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mailout1.w1.samsung.com Received: from mailout1.w1.samsung.com (HELO mailout1.w1.samsung.com) (210.118.77.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (DES-CBC3-SHA encrypted) ESMTPS; Fri, 28 Feb 2014 06:15:37 +0000 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N1P0057201XZU90@mailout1.w1.samsung.com> for binutils@sourceware.org; Fri, 28 Feb 2014 06:15:33 +0000 (GMT) Received: from eusync2.samsung.com ( [203.254.199.212]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id AC.82.18565.48920135; Fri, 28 Feb 2014 06:15:32 +0000 (GMT) Received: from [106.109.8.100] by eusync2.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0N1P00GNT01WY420@eusync2.samsung.com>; Fri, 28 Feb 2014 06:15:32 +0000 (GMT) Message-id: <53102987.3000108@samsung.com> Date: Fri, 28 Feb 2014 06:15:00 -0000 From: Yury Gribov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-version: 1.0 To: Hans-Peter Nilsson , nick clifton Cc: Will Newton , "binutils@sourceware.org" , Viacheslav Garbuzov , Yuri Gribov Subject: Re: [RFC][PATCH] Handle arbitrary .plt/.got displacements in ld on ARM References: <52F4B2B3.8060804@samsung.com> <52F8BD92.5080609@samsung.com> <5307609F.8070001@redhat.com> <530B6043.4070605@samsung.com> <530C5B23.2070306@redhat.com> <530F355F.3010405@samsung.com> <530F4DD6.8070708@redhat.com> In-reply-to: Content-type: multipart/mixed; boundary=------------050207040605070405090301 X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00176.txt.bz2 This is a multi-part message in MIME format. --------------050207040605070405090301 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 173 > The new test fails for arm-eabi: Right, I only tested linux-gnueabi. Could you check whether attached patch works for you? Gnueabi and eabi tests passed fine here. -Y --------------050207040605070405090301 Content-Type: text/x-diff; name="long_plt_eabi_fix_1.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="long_plt_eabi_fix_1.diff" Content-length: 1365 diff --git a/ld/testsuite/ld-arm/arm-elf.exp b/ld/testsuite/ld-arm/arm-elf.exp index ec569ca..b6bde2b 100644 --- a/ld/testsuite/ld-arm/arm-elf.exp +++ b/ld/testsuite/ld-arm/arm-elf.exp @@ -188,7 +188,7 @@ set armelftests_common { "" {exec-got-1b.s} {{readelf --relocs exec-got-1.d}} "exec-got-1"} - {"Long PLT entries in executables" "--long-plt -shared --section-start=.plt=0x200 --section-start=.got=0xf0000300" "" + {"Long PLT entries in executables" "--long-plt -shared --section-start=.plt=0x1000 --section-start=.got=0xf0001100" "" "" {long-plt-format.s} {{objdump "-d -j .plt" long-plt-format.d}} "long-plt-format"} diff --git a/ld/testsuite/ld-arm/long-plt-format.d b/ld/testsuite/ld-arm/long-plt-format.d index c08cb71..c64b42f 100644 --- a/ld/testsuite/ld-arm/long-plt-format.d +++ b/ld/testsuite/ld-arm/long-plt-format.d @@ -3,13 +3,13 @@ Disassembly of section .plt: -00000200 <.plt>: - 200: .* - 204: .* - 208: .* - 20c: .* - 210: .* .word .* - 214: .* add ip, pc, #-268435456 ; 0xf0000000 - 218: .* add ip, ip, #0, 12 - 21c: .* add ip, ip, #0, 20 - 220: .* ldr pc, [ip, #[0-9]*]! ; 0x.* +.* <.plt>: + .*: .* + .*: .* + .*: .* + .*: .* + .*: .* .word .* + .*: .* add ip, pc, #-268435456 ; 0xf0000000 + .*: .* add ip, ip, #0, 12 + .*: .* add ip, ip, #0, 20 + .*: .* ldr pc, [ip, #[0-9]*]! ; 0x.* --------------050207040605070405090301--