From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 6F0943858D33 for ; Tue, 6 Feb 2024 14:43:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6F0943858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6F0943858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707230632; cv=none; b=rvE8lQ+cfqu0CutWAZHDkW2XKM4T5Di5NvmjWYZkYte8V0L7bPPjmk46ZbHLhCD0VVgDavWcsHHVWk7AUPkvQoqytinVQsEY8zXrbeyeHeg4dcDbI1Zp+k38IfNHpLFhH5gZ1AqVnLNfyzCGk26Ar2hqqEFlNXOOryS5dwh296I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707230632; c=relaxed/simple; bh=m3e0ETWd1Rsv0vZoy2VGcXUOea2NGQTTRhjRlrL9UI0=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:Message-ID:MIME-Version; b=PIOgK/210MfIOgC0jb4c3zlk5rsnNO2T7ZO57XLbXWCMxdO+wz3T6RLcZ7Z+zGXmRiwQ9oAzwGaTe8/dhwcmIEesUKdJYdgA9+0DsyVzU9A8FC9vd1jRBwz1SfYcvQvR5Zwf7TfHTXPS7A2zwc1hKpCANaDVN7YClzzmeFiE3kY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from knuth.suse.de (unknown [10.168.5.16]) by smtp-out2.suse.de (Postfix) with ESMTP id 834DC1F8B2; Tue, 6 Feb 2024 14:43:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707230629; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2gwauxn22gn9l+bYinETuNMDPD0Tb/8phcv1X9xModY=; b=RA7qjHDzu03vbzua2ew7LDMetsRKLpSEolKriisYgNiEfTgoBlqqNRw4G0abYK7KHPXTWb dEt2IWU0RZ27lcz09TpuRVul5pRj5cH7aF8iRyKll2ljwnQ1HHfSNivMiSPPhH6GEoJAbc fvqssEzeUE3oVG1go/jrG+LtMeELYH0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707230629; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2gwauxn22gn9l+bYinETuNMDPD0Tb/8phcv1X9xModY=; b=6arLc+1DCqg4Qdi7APxIi6koKF1J65und9PwfuEUVftkAT9YOOkrGB+WUogPUAP/nwU/4/ LszRoWDk0Dk7qTCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707230629; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2gwauxn22gn9l+bYinETuNMDPD0Tb/8phcv1X9xModY=; b=RA7qjHDzu03vbzua2ew7LDMetsRKLpSEolKriisYgNiEfTgoBlqqNRw4G0abYK7KHPXTWb dEt2IWU0RZ27lcz09TpuRVul5pRj5cH7aF8iRyKll2ljwnQ1HHfSNivMiSPPhH6GEoJAbc fvqssEzeUE3oVG1go/jrG+LtMeELYH0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707230629; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2gwauxn22gn9l+bYinETuNMDPD0Tb/8phcv1X9xModY=; b=6arLc+1DCqg4Qdi7APxIi6koKF1J65und9PwfuEUVftkAT9YOOkrGB+WUogPUAP/nwU/4/ LszRoWDk0Dk7qTCQ== Received: by knuth.suse.de (Postfix, from userid 10510) id 7482A32A40E; Tue, 6 Feb 2024 15:43:49 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by knuth.suse.de (Postfix) with ESMTP id 72C2A32A40D; Tue, 6 Feb 2024 15:43:49 +0100 (CET) Date: Tue, 6 Feb 2024 15:43:49 +0100 (CET) From: Michael Matz To: "H.J. Lu" cc: Jan Beulich , binutils@sourceware.org Subject: Re: [PATCH] x86: Warn .insn instruction with length > 15 bytes In-Reply-To: Message-ID: <533a896f-8eec-b73b-cb18-26240ad822fc@suse.de> References: <20240205200028.219844-1-hjl.tools@gmail.com> <4b1c3da8-d218-460b-89e6-6844096ed393@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out2.suse.de; none X-Spam-Level: X-Spam-Score: -1.22 X-Spamd-Result: default: False [-1.22 / 50.00]; ARC_NA(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; TO_DN_SOME(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; FREEMAIL_TO(0.00)[gmail.com]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[]; BAYES_HAM(-0.02)[52.75%] X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, On Tue, 6 Feb 2024, H.J. Lu wrote: > > > We issue a warning when something is wrong in input, but still manage > > > to generate an instruction. This is an error case. > > > > I disagree. It was a warning until you changed it (without me really > > agreeing), and some hypothetical vendor could come and lift the limit, > > on precisely the basis that there are legal encodings exceeding it. I'm > > okay if this can be forced to be an error, but I continue to think that > > it ought to be a warning only by default. > > > > It is an error on both Intel and AMD processors. There is no > valid reason not to be an error at the moment. Jan gave you one. I would prefer for the assembler to not be anally retentive. An error that can be disabled is completely enough for this. (I would wish for a general demote-all-errors-to-warnings option, like we already have a promote-all-warnings-to-errors; but lacking this an option to merely disable "errors" for avoiding specific random hardware behaviour would be fine as well) Ciao, Michael.