From: Jon TURNEY <jon.turney@dronecode.org.uk>
To: Nicholas Clifton <nickc@redhat.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH 1/2] pe/coff: Avoid a crash using objdump -p on the output of objcopy --only-keep-debug
Date: Tue, 08 Apr 2014 18:40:00 -0000 [thread overview]
Message-ID: <5344428D.1010000@dronecode.org.uk> (raw)
In-Reply-To: <5343C9B0.1090204@redhat.com>
On 08/04/2014 11:04, Nicholas Clifton wrote:
>> I also posted a set of patches back in January [1]. I'd be grateful for any
>> comments on those.
>>
>> [1] https://sourceware.org/ml/binutils/2014-01/msg00296.html
>
>
> Oops - sorry - that one slipped through the net.
>
> I reviewed and applied the patches. They were OK although there were a few
> minor problems:
>
> * You did not update ld.textinfo's description of the --build-id linker
> command line option to mention the support for COFF format files.
>
> * There were quite a few places where the GNU Coding Standard was not being
> followed. Especially the space between a function name and its opening
> parenthesis. Ie "foo (bar)" not "foo(bar)".
>
> * Since this is a new feature it should also be mentioned in ld/NEWS.
>
> I took care of all of these issues.
Thanks very much for doing that. I shall try to bear those points in mind in
the future.
When rebasing, I notice that some other changes seem to have been mixed into
this commit:
- some changes related to long section name handling in pe(|p).em
- some changes in ldmain.c to handling -v as the only command line option
- some whitespace changes
I wonder if that was deliberate?
next prev parent reply other threads:[~2014-04-08 18:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 14:39 [PATCH 0/2] pe/coff: Improve 'objdump -p' handling of the output of 'objcopy --only-keep-debug' Jon TURNEY
2014-03-18 14:39 ` [PATCH 2/2] pe/coff: Don't try to interpret the contents of sections with no contents for 'objdump -p' Jon TURNEY
2014-03-18 14:39 ` [PATCH 1/2] pe/coff: Avoid a crash using objdump -p on the output of objcopy --only-keep-debug Jon TURNEY
2014-04-03 4:02 ` Christopher Faylor
2014-04-03 11:28 ` Nicholas Clifton
2014-04-04 14:47 ` Jon TURNEY
2014-04-08 10:04 ` Nicholas Clifton
2014-04-08 18:40 ` Jon TURNEY [this message]
2014-04-09 4:37 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5344428D.1010000@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).