From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50388 invoked by alias); 3 May 2019 12:33:16 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 50380 invoked by uid 89); 3 May 2019 12:33:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=actively, HX-Languages-Length:1287, company, HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 May 2019 12:33:15 +0000 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6096781E0F; Fri, 3 May 2019 12:33:14 +0000 (UTC) Received: from [10.36.116.241] (ovpn-116-241.ams2.redhat.com [10.36.116.241]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6A89519C4F; Fri, 3 May 2019 12:33:13 +0000 (UTC) To: Nick Alcock Cc: Joseph Myers , binutils@sourceware.org References: <20190430225706.159422-1-nick.alcock@oracle.com> From: Nick Clifton Openpgp: preference=signencrypt Subject: Re: [PATCH 00/19] libctf, and CTF support for objdump and readelf Message-ID: <534c2613-da1e-7b53-338c-2988b44b1b6b@redhat.com> Date: Fri, 03 May 2019 12:33:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00113.txt.bz2 Hi Nick, OK, so I am going to stop my review of this patch series until we have some answers to a few high level questions/requirements. Specifically: * Hosting Is the binutils project the right place for this code ? As Joseph has already mentioned libctf appears to use code from the elfutils project, so maybe that would be a better home for libctf ? * Testing I did not see a testsuite for the library, nor any additions to the binutils testsuite for the extensions to objdump and readelf. I would not be comfortable adding such a large body of code to the project without some * Documentation It would be really good to have the CTF format documented somewhere (semi) permanent and publicly accessible. It would also be good if there was a libctf.texi document describing how consumers are expected to use the library, and, ideally, providing code examples. * Usefulness This may be a bit contentious - but is the CTF format actually being used anywhere, or likely to be used in the near future ? If this is a project that is just going to be used by a small group, or even just a single company, then I am worried that the code will just bit rot away and not be actively maintained. Cheers Nick