public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH, nios2] Fix linker provided _gp symbol
@ 2014-05-09 12:57 Chung-Lin Tang
  2014-05-09 15:33 ` Sandra Loosemore
  0 siblings, 1 reply; 2+ messages in thread
From: Chung-Lin Tang @ 2014-05-09 12:57 UTC (permalink / raw)
  To: Binutils; +Cc: Sandra Loosemore

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

Hi Sandra,
As I mentioned earlier, here's a fix for the nios2-linux emulation to
make _gp/gp hidden, analogous to the same issue Maciej fixed earlier for
MIPS:
http://sourceware.org/ml/binutils/2012-08/msg00064.html

Okay for trunk and 2.24 branch?

Thanks,
Chung-Lin

2014-05-09  Chung-Lin Tang  <cltang@codesourcery.com>

	ld/
	* emulparams/nios2linux.sh (OTHER_GOT_SYMBOLS):
	Wrap _gp in HIDDEN(), and gp in PROVIDE_HIDDEN.


[-- Attachment #2: x.diff --]
[-- Type: text/plain, Size: 451 bytes --]

diff --git a/ld/emulparams/nios2linux.sh b/ld/emulparams/nios2linux.sh
index f215177..e654250 100644
--- a/ld/emulparams/nios2linux.sh
+++ b/ld/emulparams/nios2linux.sh
@@ -6,8 +6,8 @@ LITTLE_OUTPUT_FORMAT="elf32-littlenios2"
 BIG_OUTPUT_FORMAT="elf32-bignios2"
 TEXT_START_ADDR=0x2000
 OTHER_GOT_SYMBOLS='
-  _gp = ALIGN(16) + 0x7ff0;
-  PROVIDE(gp = _gp);
+  HIDDEN (_gp = ALIGN(16) + 0x7ff0);
+  PROVIDE_HIDDEN (gp = _gp);
 '
 ARCH=nios2
 MACHINE=

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH, nios2] Fix linker provided _gp symbol
  2014-05-09 12:57 [PATCH, nios2] Fix linker provided _gp symbol Chung-Lin Tang
@ 2014-05-09 15:33 ` Sandra Loosemore
  0 siblings, 0 replies; 2+ messages in thread
From: Sandra Loosemore @ 2014-05-09 15:33 UTC (permalink / raw)
  To: Chung-Lin Tang; +Cc: Binutils

On 05/09/2014 06:57 AM, Chung-Lin Tang wrote:
> Hi Sandra,
> As I mentioned earlier, here's a fix for the nios2-linux emulation to
> make _gp/gp hidden, analogous to the same issue Maciej fixed earlier for
> MIPS:
> http://sourceware.org/ml/binutils/2012-08/msg00064.html
>
> Okay for trunk and 2.24 branch?
>
> Thanks,
> Chung-Lin
>
> 2014-05-09  Chung-Lin Tang  <cltang@codesourcery.com>
>
> 	ld/
> 	* emulparams/nios2linux.sh (OTHER_GOT_SYMBOLS):
> 	Wrap _gp in HIDDEN(), and gp in PROVIDE_HIDDEN.
>

Yes, this looks OK.

-Sandra

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-05-09 15:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-09 12:57 [PATCH, nios2] Fix linker provided _gp symbol Chung-Lin Tang
2014-05-09 15:33 ` Sandra Loosemore

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).