* [PATCH] ld/aarch64: xfail non-PIC shared object tests on aarch64
@ 2014-05-16 14:26 Will Newton
2014-05-16 14:36 ` Richard Earnshaw
2014-05-19 8:26 ` Marcus Shawcroft
0 siblings, 2 replies; 5+ messages in thread
From: Will Newton @ 2014-05-16 14:26 UTC (permalink / raw)
To: binutils
aarch64 does not support building non-PIC shared objects, so mark
tests for these as xfail.
2014-05-16 Will Newton <will.newton@linaro.org>
* ld-shared/shared.exp: Mark non-PIC shared object tests
as xfail on aarch64.
---
ld/testsuite/ld-shared/shared.exp | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ld/testsuite/ld-shared/shared.exp b/ld/testsuite/ld-shared/shared.exp
index 9996ece..c723ef7 100644
--- a/ld/testsuite/ld-shared/shared.exp
+++ b/ld/testsuite/ld-shared/shared.exp
@@ -244,6 +244,7 @@ if ![ld_compile "$CC $CFLAGS $SHCFLAG" $srcdir/$subdir/main.c $tmpdir/mainnp.o]
if [ string match $shared_needs_pic "yes" ] {
setup_xfail "arm*-*-linux*"
}
+ setup_xfail "aarch64*-*-linux*"
shared_test shnp "shared (non PIC)" mainnp.o sh1np.o sh2np.o shared
# Test ELF shared library relocations with a non-zero load
@@ -270,6 +271,7 @@ if ![ld_compile "$CC $CFLAGS $SHCFLAG" $srcdir/$subdir/main.c $tmpdir/mainnp.o]
if [ string match $shared_needs_pic "yes" ] {
setup_xfail "arm*-*-linux*"
}
+ setup_xfail "aarch64*-*-linux*"
shared_test shnp "shared (non PIC, load offset)" \
mainnp.o sh1np.o sh2np.o shared \
"-T $srcdir/$subdir/elf-offset.ld"
@@ -326,6 +328,7 @@ if ![ld_compile "$CC $CFLAGS $SHCFLAG $picflag" $srcdir/$subdir/main.c $tmpdir/m
if [ string match $shared_needs_pic "yes" ] {
setup_xfail "arm*-*-linux*"
}
+ setup_xfail "aarch64*-*-linux*"
shared_test shmpnp "shared (PIC main, non PIC so)" mainp.o sh1np.o sh2np.o shared
}
} else {
--
1.9.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ld/aarch64: xfail non-PIC shared object tests on aarch64
2014-05-16 14:26 [PATCH] ld/aarch64: xfail non-PIC shared object tests on aarch64 Will Newton
@ 2014-05-16 14:36 ` Richard Earnshaw
2014-05-16 14:41 ` Will Newton
2014-05-19 8:26 ` Marcus Shawcroft
1 sibling, 1 reply; 5+ messages in thread
From: Richard Earnshaw @ 2014-05-16 14:36 UTC (permalink / raw)
To: Will Newton; +Cc: binutils
On 16/05/14 15:26, Will Newton wrote:
> aarch64 does not support building non-PIC shared objects, so mark
> tests for these as xfail.
>
> 2014-05-16 Will Newton <will.newton@linaro.org>
>
> * ld-shared/shared.exp: Mark non-PIC shared object tests
> as xfail on aarch64.
> ---
> ld/testsuite/ld-shared/shared.exp | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/ld/testsuite/ld-shared/shared.exp b/ld/testsuite/ld-shared/shared.exp
> index 9996ece..c723ef7 100644
> --- a/ld/testsuite/ld-shared/shared.exp
> +++ b/ld/testsuite/ld-shared/shared.exp
> @@ -244,6 +244,7 @@ if ![ld_compile "$CC $CFLAGS $SHCFLAG" $srcdir/$subdir/main.c $tmpdir/mainnp.o]
> if [ string match $shared_needs_pic "yes" ] {
> setup_xfail "arm*-*-linux*"
> }
> + setup_xfail "aarch64*-*-linux*"
Shouldn't this (and the other cases) be inside the test immediately
above (shared_needs_pic)?
> shared_test shnp "shared (non PIC)" mainnp.o sh1np.o sh2np.o shared
>
> # Test ELF shared library relocations with a non-zero load
> @@ -270,6 +271,7 @@ if ![ld_compile "$CC $CFLAGS $SHCFLAG" $srcdir/$subdir/main.c $tmpdir/mainnp.o]
> if [ string match $shared_needs_pic "yes" ] {
> setup_xfail "arm*-*-linux*"
> }
> + setup_xfail "aarch64*-*-linux*"
> shared_test shnp "shared (non PIC, load offset)" \
> mainnp.o sh1np.o sh2np.o shared \
> "-T $srcdir/$subdir/elf-offset.ld"
> @@ -326,6 +328,7 @@ if ![ld_compile "$CC $CFLAGS $SHCFLAG $picflag" $srcdir/$subdir/main.c $tmpdir/m
> if [ string match $shared_needs_pic "yes" ] {
> setup_xfail "arm*-*-linux*"
> }
> + setup_xfail "aarch64*-*-linux*"
> shared_test shmpnp "shared (PIC main, non PIC so)" mainp.o sh1np.o sh2np.o shared
> }
> } else {
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ld/aarch64: xfail non-PIC shared object tests on aarch64
2014-05-16 14:36 ` Richard Earnshaw
@ 2014-05-16 14:41 ` Will Newton
0 siblings, 0 replies; 5+ messages in thread
From: Will Newton @ 2014-05-16 14:41 UTC (permalink / raw)
To: Richard Earnshaw; +Cc: binutils
On 16 May 2014 15:35, Richard Earnshaw <rearnsha@arm.com> wrote:
> On 16/05/14 15:26, Will Newton wrote:
>> aarch64 does not support building non-PIC shared objects, so mark
>> tests for these as xfail.
>>
>> 2014-05-16 Will Newton <will.newton@linaro.org>
>>
>> * ld-shared/shared.exp: Mark non-PIC shared object tests
>> as xfail on aarch64.
>> ---
>> ld/testsuite/ld-shared/shared.exp | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/ld/testsuite/ld-shared/shared.exp b/ld/testsuite/ld-shared/shared.exp
>> index 9996ece..c723ef7 100644
>> --- a/ld/testsuite/ld-shared/shared.exp
>> +++ b/ld/testsuite/ld-shared/shared.exp
>> @@ -244,6 +244,7 @@ if ![ld_compile "$CC $CFLAGS $SHCFLAG" $srcdir/$subdir/main.c $tmpdir/mainnp.o]
>> if [ string match $shared_needs_pic "yes" ] {
>> setup_xfail "arm*-*-linux*"
>> }
>> + setup_xfail "aarch64*-*-linux*"
>
> Shouldn't this (and the other cases) be inside the test immediately
> above (shared_needs_pic)?
shared_needs_pic is rather misnamed. It means "does this ARM compiler
emit MOVW instructions".
>
>> shared_test shnp "shared (non PIC)" mainnp.o sh1np.o sh2np.o shared
>>
>> # Test ELF shared library relocations with a non-zero load
>> @@ -270,6 +271,7 @@ if ![ld_compile "$CC $CFLAGS $SHCFLAG" $srcdir/$subdir/main.c $tmpdir/mainnp.o]
>> if [ string match $shared_needs_pic "yes" ] {
>> setup_xfail "arm*-*-linux*"
>> }
>> + setup_xfail "aarch64*-*-linux*"
>> shared_test shnp "shared (non PIC, load offset)" \
>> mainnp.o sh1np.o sh2np.o shared \
>> "-T $srcdir/$subdir/elf-offset.ld"
>> @@ -326,6 +328,7 @@ if ![ld_compile "$CC $CFLAGS $SHCFLAG $picflag" $srcdir/$subdir/main.c $tmpdir/m
>> if [ string match $shared_needs_pic "yes" ] {
>> setup_xfail "arm*-*-linux*"
>> }
>> + setup_xfail "aarch64*-*-linux*"
>> shared_test shmpnp "shared (PIC main, non PIC so)" mainp.o sh1np.o sh2np.o shared
>> }
>> } else {
>>
>
>
--
Will Newton
Toolchain Working Group, Linaro
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ld/aarch64: xfail non-PIC shared object tests on aarch64
2014-05-16 14:26 [PATCH] ld/aarch64: xfail non-PIC shared object tests on aarch64 Will Newton
2014-05-16 14:36 ` Richard Earnshaw
@ 2014-05-19 8:26 ` Marcus Shawcroft
2014-05-19 10:41 ` Richard Earnshaw
1 sibling, 1 reply; 5+ messages in thread
From: Marcus Shawcroft @ 2014-05-19 8:26 UTC (permalink / raw)
To: Will Newton; +Cc: binutils, Richard Earnshaw
On 16 May 2014 15:26, Will Newton <will.newton@linaro.org> wrote:
> aarch64 does not support building non-PIC shared objects, so mark
> tests for these as xfail.
>
> 2014-05-16 Will Newton <will.newton@linaro.org>
>
> * ld-shared/shared.exp: Mark non-PIC shared object tests
> as xfail on aarch64.
Looks OK to me, if Richard doesn;t come back in the next 24h go ahead.
Cheers
/Marcus
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ld/aarch64: xfail non-PIC shared object tests on aarch64
2014-05-19 8:26 ` Marcus Shawcroft
@ 2014-05-19 10:41 ` Richard Earnshaw
0 siblings, 0 replies; 5+ messages in thread
From: Richard Earnshaw @ 2014-05-19 10:41 UTC (permalink / raw)
To: Marcus Shawcroft; +Cc: Will Newton, binutils
On 19/05/14 09:26, Marcus Shawcroft wrote:
> On 16 May 2014 15:26, Will Newton <will.newton@linaro.org> wrote:
>> aarch64 does not support building non-PIC shared objects, so mark
>> tests for these as xfail.
>>
>> 2014-05-16 Will Newton <will.newton@linaro.org>
>>
>> * ld-shared/shared.exp: Mark non-PIC shared object tests
>> as xfail on aarch64.
>
> Looks OK to me, if Richard doesn;t come back in the next 24h go ahead.
> Cheers
> /Marcus
>
This is fine. It would be nice if the misnamed stuff could be sorted
out, but that's a separate issue.
R.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-05-19 10:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-16 14:26 [PATCH] ld/aarch64: xfail non-PIC shared object tests on aarch64 Will Newton
2014-05-16 14:36 ` Richard Earnshaw
2014-05-16 14:41 ` Will Newton
2014-05-19 8:26 ` Marcus Shawcroft
2014-05-19 10:41 ` Richard Earnshaw
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).