From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by sourceware.org (Postfix) with ESMTPS id 9FC9A3857C60 for ; Tue, 12 Dec 2023 08:41:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9FC9A3857C60 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9FC9A3857C60 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::335 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702370512; cv=none; b=Yp+QEGB7QRQ44uzbOolLnDHY6kCVfByvlQSpw265tzmIAXMC1vdcq5W7bwA3rV0oQfQPwC9zwryvO+jLX1Bn4INN3xduCjSlcSEjxN7JeIcdccr6/AjFPTDAKlA5e81tf0T95qXbxD0NI/EFA/JvLQQgR4pNNDgJ3Ts5gBL6UIw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702370512; c=relaxed/simple; bh=MVNK63xiVXg7hJtW0Fi5KuAopPyJ+2LAVWtw0QnkzAM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=N8DS6yCA6jYrBkrTRtFEzmicRbv5SUVxVB9Oq5M0V6Ov2cxEBcnGG0cHFZWyTOzbihL1SA3rqLuPQbtsxBDcgLnPHOeciB1+nQnNwWvQarFH2DxHSAgWIbdPs/r+xp2AnhTjFXUukNwOnDD0eX8kHlcM1rTCVt9aDqwWfPQRB5g= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-40c3f68b79aso32438295e9.0 for ; Tue, 12 Dec 2023 00:41:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1702370509; x=1702975309; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Hqa2fabrmz93ClhIr2r05qNolzLpU/7fMyVVsVQSw1E=; b=Uj1je6HaIAbLCNrCpDcxT2vuxuzeYJ1jm30i3GAANvBeaMT+KjJn1FvEl7HpgS/Mxx 5ejb6rCLJwtjAoBvpLVf+HhHrzEy+U610lTddq1qKW13p2TF6NiB9nWLhgdUwHcTc4oe f/zYE1KjCBhqy7KIf9Rwg36fkJk7W+gMcRflhSv4F80/u+Mh6YwYTpKZ67ESRyveio/N 8p2wyPh8KtxwwXJTyXgnT7nsioB00yueS1B0N58uChOtKb9znA7Fi8zS+oxg9ZsEBuIu hg2Ts15SsjnKjIPCe8PHF2eW3lw8R5edQaZnSr6pOCmAL3N5FDi2V4o1DOCLNI7kW08J a+EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702370509; x=1702975309; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Hqa2fabrmz93ClhIr2r05qNolzLpU/7fMyVVsVQSw1E=; b=TSP0qpWEEUxfKHiRFtIcCWkU1+IESnF+q1xFdGeaVTgbMb8S/u1uBL/wO+Dd7x/5jc gKPPu0JrKAnKW+yoOTNi87vRDJU8OvdUYe4ax8c3RF7LRdlGD76ZRruzaY7qPYfYVHvu bSbtXTrlPndFZ3R4eRd6hA5BYwDveUuOqpSqK9MDquwvERzHAY8qxERH3cARVqQh9KMG tcTMMzutrQKg16ho9l4Fay1Fj3sPNXElRuNbi0noF+HC3Yqu7FnfuB5LfUVxZV3sU15D QJwu1Wbbx5NLHGY94JvUNy7r4HddhXLZ7zqUbyFHfFZ34qGhdw31571svSAsFoO6nXZ1 63wQ== X-Gm-Message-State: AOJu0YzLFY8MdWcWqasV0qlhP3iP29cpbzaUugvtrSVVEPjsLvLE0P4B +qSKhutOoZ+R2bFGfA0sLFHegdNX1EyB0+FM5F9V X-Google-Smtp-Source: AGHT+IGdRmx2e8FCc4XC7THzDGDX6hTa5yPv84yHyJyhCe+d5yEautjheBhWq29/pefNoBdcJ4bBMw== X-Received: by 2002:a05:600c:1d19:b0:40b:5e1d:83a0 with SMTP id l25-20020a05600c1d1900b0040b5e1d83a0mr2971988wms.52.1702370509592; Tue, 12 Dec 2023 00:41:49 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id q14-20020a05600c46ce00b0040c4c9c52a3sm4046761wmo.12.2023.12.12.00.41.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Dec 2023 00:41:49 -0800 (PST) Message-ID: <5381d159-2a97-41ea-9e57-f53b2a474923@suse.com> Date: Tue, 12 Dec 2023 09:41:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 8/9] Support APX NDD optimized encoding. Content-Language: en-US To: "Hu, Lin1" Cc: "Lu, Hongjiu" , "binutils@sourceware.org" , "Cui, Lili" References: <20231124070213.3886483-1-lili.cui@intel.com> <20231124070213.3886483-8-lili.cui@intel.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3026.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12.12.2023 04:18, Hu, Lin1 wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: Monday, December 11, 2023 8:28 PM >> >> On 24.11.2023 08:02, Cui, Lili wrote: >>> @@ -7675,6 +7727,61 @@ match_template (char mnem_suffix) >>> i.memshift = memshift; >>> } >>> >>> + /* If we can optimize a NDD insn to legacy insn, like >>> + add %r16, %r8, %r8 -> add %r16, %r8, >>> + add %r8, %r16, %r8 -> add %r16, %r8, then rematch template. >>> + Note that the semantics have not been changed. */ >>> + if (optimize >>> + && !i.no_optimize >>> + && i.vec_encoding != vex_encoding_evex >>> + && t + 1 < current_templates->end >>> + && !t[1].opcode_modifier.evex >>> + && t[1].opcode_space <= SPACE_0F38 >>> + && t->opcode_modifier.vexvvvv == VexVVVV_DST) >>> + { >>> + unsigned int match_dest_op = can_convert_NDD_to_legacy (t); >>> + size_match = true; >> >> This would perhaps better ... >> >>> + if (match_dest_op != (unsigned int) ~0) >>> + { >> >> ... live here >> > > OK. > >> >>> + /* We ensure that the next template has the same input >>> + operands as the original matching template by the first >>> + opernd (ATT), thus avoiding the error caused by the wrong >> order >>> + of insns in i386.tbl. */ >> >> I'm sorry, but I (still) can't make sense of this last part of the comment, after the >> comma. >> > > I mean if someone support new NDD insns and put it in the wrong position, so the part will try to avoid to optimize the insn. If this is about hypothetical new templates, that would want saying so in the comment. Thus clarifying that there's no functional effect right now. I wonder what H.J.'s view on such effectively dead code is. However, there's a bigger problem with this patch as I realized only a few minutes ago when looking into Lili's reply on the NDD patch thread: NDD insns are implicitly zero-upper. Hence converting NDD to legacy insns needs to be limited to 32- and 64-bit operand size. For 8- and 16-bit operand size the results would differ, which isn't acceptable under any -O. It may be okay to do such a conversion even for the smaller sizes, but then under a separate option explicitly permitting such a functional difference. Jan