From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24024 invoked by alias); 29 May 2014 12:19:12 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 24008 invoked by uid 89); 29 May 2014 12:19:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: service87.mimecast.com Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 May 2014 12:19:09 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Thu, 29 May 2014 13:19:06 +0100 Received: from [10.1.201.52] ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 29 May 2014 13:19:04 +0100 Message-ID: <538725B9.8060102@arm.com> Date: Thu, 29 May 2014 12:19:00 -0000 From: Yufeng Zhang User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:8.0) Gecko/20111105 Thunderbird/8.0 MIME-Version: 1.0 To: Martin Storsjo CC: "binutils@sourceware.org" Subject: Re: [PATCH] aarch64: Fix the documentation on :pg_hi21: References: <1401364824-4630-1-git-send-email-martin@martin.st> In-Reply-To: <1401364824-4630-1-git-send-email-martin@martin.st> X-MC-Unique: 114052913190615901 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00265.txt.bz2 Hi Martin, On 05/29/14 13:00, Martin Storsjo wrote: > The syntax described, including a leading '#', was not supported > in practice. (For :lo12: it is optional.) I believe this is an issue in the parser; '#' should be optional in=20 either case. It looks like gas/config/tc-aarch64.c:parse_adrp () is missing the=20 skip_past_char (&p, '#') at its beginning; see parse_half () for an example. Yufeng > --- > gas/doc/c-aarch64.texi | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/gas/doc/c-aarch64.texi b/gas/doc/c-aarch64.texi > index cce4f61..1f4ce4c 100644 > --- a/gas/doc/c-aarch64.texi > +++ b/gas/doc/c-aarch64.texi > @@ -186,24 +186,24 @@ For example to load the 48-bit absolute address of = @var{foo} into x0: > @cindex ADRP, ADD, LDR/STR group relocations, AArch64 > Relocations for @samp{ADRP}, and @samp{ADD}, @samp{LDR} or @samp{STR} > instructions can be generated by prefixing the label with > -@samp{#:pg_hi21:} and @samp{#:lo12:} respectively. > +@samp{:pg_hi21:} and @samp{#:lo12:} respectively. > > For example to use 33-bit (+/-4GB) pc-relative addressing to > load the address of @var{foo} into x0: > > @smallexample > - adrp x0, #:pg_hi21:foo > + adrp x0, :pg_hi21:foo > add x0, x0, #:lo12:foo > @end smallexample > > Or to load the value of @var{foo} into x0: > > @smallexample > - adrp x0, #:pg_hi21:foo > + adrp x0, :pg_hi21:foo > ldr x0, [x0, #:lo12:foo] > @end smallexample > > -Note that @samp{#:pg_hi21:} is optional. > +Note that @samp{:pg_hi21:} is optional. > > @smallexample > adrp x0, foo > @@ -212,7 +212,7 @@ Note that @samp{#:pg_hi21:} is optional. > is equivalent to > > @smallexample > - adrp x0, #:pg_hi21:foo > + adrp x0, :pg_hi21:foo > @end smallexample > > @node AArch64 Floating Point