* [patch bfd]: Make relocbase in coff_tdata unsigned
@ 2014-06-05 9:16 Kai Tietz
2014-06-06 2:12 ` Alan Modra
2014-06-09 16:27 ` Nicholas Clifton
0 siblings, 2 replies; 3+ messages in thread
From: Kai Tietz @ 2014-06-05 9:16 UTC (permalink / raw)
To: Binutils; +Cc: Nick Clifton, Ray Donnelly
Hello,
This simple patch takes care we handle values > 2^31 as unsigned, too.
That caused on some cases to negative relocbase.
ChangeLog
2014-06-05 Kai Tietz <ktietz@redhat.com>
* libcoff-in.h (coff_tdata): Make relocbase member unsigned.
* libcoff.h: Regenerated.
Tested for i686-w64-mingw32, and x86_64-w64-mingw32. Ok for apply?
Regards,
Kai
From bd8edd9789f103035007d9244ee03dc9847fda9a Mon Sep 17 00:00:00 2001
From: Kai Tietz <ktietz70@googlemail.com>
Date: Thu, 5 Jun 2014 10:59:08 +0200
Subject: =?UTF-8?q?
*=20libcoff-in.h=20(coff=5Ftdata):=20Make=20relocbase=20?=
=?UTF-8?q?member=20unsigned.=0A *=20libcoff.h:=20Regenerated.?=
---
bfd/libcoff-in.h | 2 +-
bfd/libcoff.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/bfd/libcoff-in.h b/bfd/libcoff-in.h
index cc1e52b..367d3bc 100644
--- a/bfd/libcoff-in.h
+++ b/bfd/libcoff-in.h
@@ -53,7 +53,7 @@ typedef struct coff_tdata
unsigned long raw_syment_count;
/* These are only valid once writing has begun. */
- long int relocbase;
+ unsigned long int relocbase;
/* These members communicate important constants about the symbol table
to GDB's symbol-reading code. These `constants' unfortunately vary
diff --git a/bfd/libcoff.h b/bfd/libcoff.h
index 19ba7e7..24b9b57 100644
--- a/bfd/libcoff.h
+++ b/bfd/libcoff.h
@@ -57,7 +57,7 @@ typedef struct coff_tdata
unsigned long raw_syment_count;
/* These are only valid once writing has begun. */
- long int relocbase;
+ unsigned long int relocbase;
/* These members communicate important constants about the symbol table
to GDB's symbol-reading code. These `constants' unfortunately vary
--
1.7.9
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch bfd]: Make relocbase in coff_tdata unsigned
2014-06-05 9:16 [patch bfd]: Make relocbase in coff_tdata unsigned Kai Tietz
@ 2014-06-06 2:12 ` Alan Modra
2014-06-09 16:27 ` Nicholas Clifton
1 sibling, 0 replies; 3+ messages in thread
From: Alan Modra @ 2014-06-06 2:12 UTC (permalink / raw)
To: Kai Tietz; +Cc: Binutils, Nick Clifton, Ray Donnelly
On Thu, Jun 05, 2014 at 11:16:22AM +0200, Kai Tietz wrote:
> * libcoff-in.h (coff_tdata): Make relocbase member unsigned.
> * libcoff.h: Regenerated.
OK. I presume you have some followup patches, because this patch by
itself doesn't really do anything.
--
Alan Modra
Australia Development Lab, IBM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch bfd]: Make relocbase in coff_tdata unsigned
2014-06-05 9:16 [patch bfd]: Make relocbase in coff_tdata unsigned Kai Tietz
2014-06-06 2:12 ` Alan Modra
@ 2014-06-09 16:27 ` Nicholas Clifton
1 sibling, 0 replies; 3+ messages in thread
From: Nicholas Clifton @ 2014-06-09 16:27 UTC (permalink / raw)
To: Kai Tietz, Binutils; +Cc: Ray Donnelly
Hi Kai,
> 2014-06-05 Kai Tietz <ktietz@redhat.com>
>
> * libcoff-in.h (coff_tdata): Make relocbase member unsigned.
> * libcoff.h: Regenerated.
>
Approved - please apply.
Cheers
Nick
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-09 16:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-05 9:16 [patch bfd]: Make relocbase in coff_tdata unsigned Kai Tietz
2014-06-06 2:12 ` Alan Modra
2014-06-09 16:27 ` Nicholas Clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).